From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 165E8409615 for ; Thu, 2 Jul 2026 08:12:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782979928; cv=none; b=L5b8t4yTo1QH/+tho+xljHD8qklYmrYxHtkYph60eR8u3wIOCTGKLHtHPrGDAWVYnCTk+u4jJLXuUpoRSVyxNSFQp78ENfacLsGyJUa6k+U1xI8FGnvssbKolcVUJjLNVFKzeXCafBn/biiP7oBfwOZrJA5OK1l7vxdmHF+qZXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782979928; c=relaxed/simple; bh=hBfW1eVaVJwN36oy84l9pvJf63LCeiP5BZ+extnzSSE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CIvk2Vnkll53rmcGE32Nn+7eGem+DecfURmUXAz6UGiK3kJROpsYX4A8jBk7JUOD8utgqvOFfxIYwYPZOv4OnbSglGdpPuAi6DgMMHAVlUo0yb220O4ny98k7BUJdU0XKRSVM8da2pvQQ1LGv5VgZGrehRoYRl29pZsnT+Wr9Go= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GwcYpUnZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BISNpcv0; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GwcYpUnZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BISNpcv0" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6624iLG03591734 for ; Thu, 2 Jul 2026 08:12:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LJ/2x+XVHtMq89QE+QEJmdN3JjMlArDp2qzGS+R+kMw=; b=GwcYpUnZ3OLJJ2Qy 9N0r4k9nRP6In/WpXlrzo8y7WMQij5X54gyX9c/y++Feeo3MvKrJ7cYnXQgQ2iz+ Il/NO2CskZWD19BNojxCt/7nCVuTL1uMMbkSNQc/FuqYCYehzf1861v7JNyl4ZTu pN8NJ3VdFvpN7zcvhnAwPE4OGZjNZYLYRp8sBb9i+3/H5hq7EGt5LMvjH4uf7hsS 9l6nJ0Q+6Jt0Z7zhrACJL2Nz/VWsscpjZrNvN1/zqNRliaj0hyN2QSP548ZQ//Kw ygc+7oAN6AEgvRG4xoQuhmqurXbYEw6e4ZYa3zZRnwNb/EJsKuD6PjxnAudsCT/o k8qF7Q== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f5h7n8qfp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Jul 2026 08:12:06 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2c9f0073e20so23047215ad.1 for ; Thu, 02 Jul 2026 01:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782979926; x=1783584726; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LJ/2x+XVHtMq89QE+QEJmdN3JjMlArDp2qzGS+R+kMw=; b=BISNpcv0w5Bdikd4D3jB1RdBeZH8KoIgXz+FuZcT/1DnchhxdEqqmxjAjsad9FrSSW EeZtzRTafkern+DeOnF8RKx3aOiH8essO4YenS5X2i5izq1aOIccWYILXRTBeJ+GQTbx JAvQfQybGjcUz/nIIEmXyYQdqj6a6TYNcLBOFJGWzyEPwLpnKuGieAfff+6d9hMAWa3C 9p0uNa+sCwLUSCfx+Mpak1/SqSI9H7jZuDoKtrf9Rp/vHEqHb+a1a2Fnh5nU2HMpMuXM Niz8I+G7ZcydPClmeHCt+upu+46Vft1zk1TYjRlSlA/qUCULaxpiLn58r4vD3zbTB6MA NBzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782979926; x=1783584726; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LJ/2x+XVHtMq89QE+QEJmdN3JjMlArDp2qzGS+R+kMw=; b=dMXOP2oZv8dFsTpPylS5og1xIzRkTnlkDBg7kjeAsrj2czhhHXn0u9vDkLFWD9Xsh5 qI44S+Db5pUVUM2FuI4ClHpNi0y7Cgjg0ehh0YIbg+Bl8YxTeqQPTpW2YzAjUZ0rsfk3 0LOQrNshWG6ryOEEJLnDBHxPE+ho/+N5hmbmRSvxLMxUyeDO2tFiTCsPMYK72iiIvn3y iuLUdp9s0z+rwWkqDP6omPjaDkCvhOjg1zbkjh/15175DRg/rXuedfhyJhIYo7WPzAAk TUWhsM+chcr7+PvEwiOcFtMzpXGwYPFwQmhUd8CduEREg/mLoGEy19SPKfQILG2beGVo Ln7A== X-Forwarded-Encrypted: i=1; AHgh+Roed92XwpDGzOGIO8mWMGI9+9qVkTF70lUnlvasWGXHqLA04apIYs9cdtaMEXevQJvfIdvFmdi5OPpVmO0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/yiGI/uVai7+X90Vvus+WZa4Sa1gUkuVBpWSWlipa1Z5M66AT I598Rt3R0jof7xQqY4IdKO0cYz5riqgJXSEeLZHGNlG++ypHZMhWxxVxTzQGO8vIl3tFL3BB/ZJ q+lUf3ciswn2Ss2u4NSsOgXQsSgE6DC5OqxDIjltVExchxDGkgEODlu9B6tDefQGMiions+6rpH LLpw== X-Gm-Gg: AfdE7cl5kkw7ivB1eJ9MmRqgWaKXGhisVcDhXXdHqK68JEv3JZdFnnYfUJpRyx71/BV 6ztHUzO82MbpLwGHFYxdmxjjy4Cx/H9aYeQQgn6RHZkMud4wvQ58yqFcKU1Z5JZ+ye4bGoz8IZx jIr/gFyM3vyu2zo3b04rpiftayJZ376sfVNAA1RynqiF4gUh6hMGdQhePVjN4BvQPyUlC2gKEWK qHyRmFqWUa2gihWbCfgISw6wAj5ZOMxQNeRKBqWGV65BOovuJx0ues2AvfBA61YXrMr5FantdBH 3B/kG60ORJ0a6w77ZT/QYUtvvOz+H+WRrgyCVZAxHApKFwrMRNXH80DNQ5OPJJDKVedPly3WYos vpk25mkB+/u20GHNf/nQFU37FI4le0lGZMgpkxpkjk5pOOHTpq9ico3lHcZzPXTOdHP+Dzyojma QixIz7PUVj X-Received: by 2002:a17:903:2ac7:b0:2c9:9927:a060 with SMTP id d9443c01a7336-2ca7e751e3emr51677425ad.24.1782979925531; Thu, 02 Jul 2026 01:12:05 -0700 (PDT) X-Received: by 2002:a17:903:2ac7:b0:2c9:9927:a060 with SMTP id d9443c01a7336-2ca7e751e3emr51677085ad.24.1782979924931; Thu, 02 Jul 2026 01:12:04 -0700 (PDT) Received: from [10.133.33.211] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ca9a8dae49sm9805725ad.10.2026.07.02.01.12.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 01:12:04 -0700 (PDT) Message-ID: Date: Thu, 2 Jul 2026 16:12:00 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND] wifi: ath12k: fix MAC address copy on big endian To: Alexander Wilhelm , Jeff Johnson Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260629-fix-mac-addr-copy-on-big-endian-v1-1-3de40f74c13e@westermo.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260629-fix-mac-addr-copy-on-big-endian-v1-1-3de40f74c13e@westermo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAyMDA4MyBTYWx0ZWRfX9el5oYDVfOxv RrkocQYfJuR2aCRVzeT0ywzCALIcCSM0tWzCtTm1phqvn/ZuNMniAP11eJwPe8EtNM+LUxub6ju /DiLIDz4754ZG7HvV6n343wZwSWOjJ0AZThi52zaVrrBuQRFnzfuBO1wcvApHNQziT51tWrPTF/ 0JD3FvCYl6bz2dl/1Dmdq8Qn7v89kQOz8LQiJ88LSXT0NtFsr0ABtsxGTFC9y9XQ1ncImrN32nQ sIq2WPmiV+u9s7Q+TGQItExr8K8n7iE0htUDIkhms39ywoPQmD7jJ7N576HW9s1ASgTa3aVOHrG oxHBjBX3tOT4Y2rG3w2kyaUq35SGuw2t9a3OFJZxX/V8jN8+h+b5hs+L4cs9Vp3DmxxzCzuJ/b8 HMmprqNtEwDHD+btvwDOlYuA+B1LldvXhpDZLf8JqjeU+zC2wSjXEVc5NsWHWRM4F8Cx8ydWSpm QmpNH5q2elBNOYs8ibg== X-Proofpoint-ORIG-GUID: TOi1lPSlY5pLi1JyjeYHMLmMKjzKSN-P X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAyMDA4MyBTYWx0ZWRfXzCYO3pFQ8lLj KiWtWcpaZMBgGFNZcKqYn6+he6Y/hlo1Z/j4HB8hMQjcMgJZ+mZe/qgZrszfGpFdRMBvE2GrbaZ V7SU8u7ACsc7CncZIvL/r2Sun9a0n5k= X-Proofpoint-GUID: TOi1lPSlY5pLi1JyjeYHMLmMKjzKSN-P X-Authority-Analysis: v=2.4 cv=WMBPmHsR c=1 sm=1 tr=0 ts=6a461d56 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=N9GNhs4bAAAA:8 a=ywX3x0iTvHv4trEmZJsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=PZhj9NlD-CKO8hVp7yCs:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-02_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 priorityscore=1501 adultscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607020083 On 6/29/2026 3:55 PM, Alexander Wilhelm wrote: > The ath12k_dp_get_mac_addr function performs a simple memcpy from a > CPU-native data types into an u8 array. On a big-endian architecture, this > later results in a null‑pointer dereference. Convert the data to Alex, did you find a time to investigate the root cause of the null pointer? > little‑endian first, then copy it into the target array. > > Signed-off-by: Alexander Wilhelm > --- > drivers/net/wireless/ath/ath12k/dp.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath12k/dp.h b/drivers/net/wireless/ath/ath12k/dp.h > index f8cfc7bb29dd..50957915dbf4 100644 > --- a/drivers/net/wireless/ath/ath12k/dp.h > +++ b/drivers/net/wireless/ath/ath12k/dp.h > @@ -647,8 +647,11 @@ int ath12k_dp_arch_rx_tid_delete_handler(struct ath12k_dp *dp, > > static inline void ath12k_dp_get_mac_addr(u32 addr_l32, u16 addr_h16, u8 *addr) > { > - memcpy(addr, &addr_l32, 4); > - memcpy(addr + 4, &addr_h16, ETH_ALEN - 4); > + __le32 le_addr_l32 = cpu_to_le32(addr_l32); > + __le16 le_addr_h16 = cpu_to_le16(addr_h16); > + > + memcpy(addr, &le_addr_l32, 4); > + memcpy(addr + 4, &le_addr_h16, ETH_ALEN - 4); > } > > static inline struct ath12k_dp * > > --- > base-commit: 702847e8cfd51856836a282db2073defd7cfd80c > change-id: 20260317-fix-mac-addr-copy-on-big-endian-f1a4fea40184 > > Best regards,