From: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com>
To: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
peter.chen@oss.qualcomm.com, qiang.yu@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
ziyue.zhang@oss.qualcomm.com
Subject: Re: [PATCH v2 0/4] Add qref and refgen regulator support for QCS8300 and SA8775p PCIe PHYs
Date: Tue, 13 Oct 2026 15:27:51 +0800 [thread overview]
Message-ID: <f4d10126-e2a4-41ad-9960-ff129d92f39a@oss.qualcomm.com> (raw)
In-Reply-To: <20260916102023.2054761-1-ziyue.zhang@oss.qualcomm.com>
On 9/16/2026 6:20 PM, Ziyue Zhang wrote:
> This series adds qref and refgen regulator support for the PCIe QMP PHYs
> on QCS8300 and SA8775p platforms.
>
> The PCIe PHYs on these SoCs require dedicated qref and refgen voltage
> supplies for stable operation. Without enabling these supplies, PCIe may
> be unstable and the system can occasionally crash under certain scenarios.
>
> The refgen supply in particular works around a hardware issue where both
> QREF and the PCIe PHY are expected to depend on refgen2, but QREF actually
> depends on refgen3. This series therefore votes for refgen3 manually via
> the refgen supply.
>
> Changes in v2:
> - Expand commit message to explain why these supplies were missing and
> what issue was observed (Mani)
> - Remove redundant vdda-refgen-supply overrides from qcs9100-ride.dts
> and qcs9100-ride-r3.dts; the supplies are already defined in
> lemans-ride-common.dtsi which both files include
> Link to v1: https://lore.kernel.org/all/20260810112735.1326807-1-ziyue.zhang@oss.qualcomm.com/
>
> Ziyue Zhang (4):
> dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Add vdda-refgen and
> refgen supply properties
> phy: qcom: qmp-pcie: Add qref and refgen regulator vote for QCS8300
> and SA8775p PHY
> arm64: dts: qcom: qcs8300: Add qref and refgen supply for PCIe PHYs
> arm64: dts: qcom: sa8775p: Add qref and refgen supply for PCIe PHYs
>
> .../phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 27 +++++++++++++++++++
> arch/arm64/boot/dts/qcom/lemans-evk.dts | 4 +++
> .../boot/dts/qcom/lemans-ride-common.dtsi | 4 +++
> arch/arm64/boot/dts/qcom/monaco-evk.dts | 4 +++
> .../arm64/boot/dts/qcom/monaco-monza-som.dtsi | 4 +++
> arch/arm64/boot/dts/qcom/monaco.dtsi | 4 +++
> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 +++
> drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 16 ++++++-----
> 8 files changed, 61 insertions(+), 6 deletions(-)
Hi Maintainers,
It seems the patches get reviewed tag for a long time, can you give this
series further comment or help me to merge them ?
Thanks very much.
BR
Ziyue
prev parent reply other threads:[~2026-10-13 7:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 10:20 Ziyue Zhang
2026-09-16 10:20 ` [PATCH v2 1/4] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Add vdda-refgen and refgen supply properties Ziyue Zhang
2026-09-16 10:20 ` [PATCH v2 2/4] phy: qcom: qmp-pcie: Add qref and refgen regulator vote for QCS8300 and SA8775p PHY Ziyue Zhang
2026-10-12 15:42 ` Manivannan Sadhasivam
2026-09-16 10:20 ` [PATCH v2 3/4] arm64: dts: qcom: qcs8300: Add qref and refgen supply for PCIe PHYs Ziyue Zhang
2026-09-16 10:20 ` [PATCH v2 4/4] arm64: dts: qcom: sa8775p: " Ziyue Zhang
2026-10-13 7:27 ` Ziyue Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4d10126-e2a4-41ad-9960-ff129d92f39a@oss.qualcomm.com \
--to=ziyue.zhang@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=peter.chen@oss.qualcomm.com \
--cc=qiang.yu@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®