From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DEAE41835F for ; Fri, 21 Aug 2026 23:11:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787353883; cv=none; b=cM4v8u/4WUyxa4B2FIlT0lEN/d3eNaXWI+N8fhEfkwkNspiJC0hlFE52m9tbD8NzZasyKn8s0y/95CFe0lnt4c0aoyLZQpy8M4lp8HE2h3yVnQHrPpmOCUivqt2wWXP4MxpcUbPcxpDgEGgpn5imgPmZVDaxmV1KUIh6bmYS0lQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787353883; c=relaxed/simple; bh=Hfg4eNdHbaBARANiJABKZ+XnrxmaeCJGh7zzb5htsLI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jW4x20qWWFBPeT8G6aPDqMFEvOBGZVzMHsBSRGPrQRD9gk8rEzks9PWCUZibu0f2XosvmQyZLgY5KGPTYALQ/SQDH3unlxWzyzZFRyZgZIwWoDXJwooIoZEUo8j52SChPHIA7xvbrWeq6obenBLDetfNV/9eKBhtLBnAhWFYk78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FNg2RHM5; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FNg2RHM5" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-495437bb891so9141075e9.1 for ; Fri, 21 Aug 2026 16:11:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787353878; x=1787958678; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hLSJoNhqitBynpVd16vFcy3Vr4aNPFfC+ZBhksu/Yjg=; b=FNg2RHM5kDwd8xerFBGIuTUIozQR+CleDHWGYlVSL4OWpk91c/Tbuj3F0g1I/DWQt2 YvehEo4QnwAF8OvaOp+OYEzU0hdOm0zKzB7eQnVLJY0ZOwk7SSXXmCYuYktIuhZDHCzj twr6DCaADPp1yMFvhVfs5WdEpFYoXfP6xqt+81y/ycdQin6MS32IxCK32CwNIydnglEk P1hnCQqwNAg1i14hrnlcmr4dRChKUpkTHP8zEv3NKnfKUYbH6Mi0a6OkLF8X/yBYRggL yVYsI+JrgnyBO1xJXMlq0oDRrlyzuNPrnVE9xF40/zEojDSVqoxWYagl9BN5+kvJeQ5H ileQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787353878; x=1787958678; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=hLSJoNhqitBynpVd16vFcy3Vr4aNPFfC+ZBhksu/Yjg=; b=gFwAZeMMmaEcrvReG/U7wJSWP+/2KOcT6gEv+RF/I3NvpNvmX3Fi/4JpZdybUJu9wg Z4z0U9fAoC3t1hV7uT5BKcMwGSHAsDj3WZW1vHqWx5Ta85swjIWxoy68rSKG38p1FshB jR+eT9S9PGW4dPgh6YA38qC48aNuOMsd+GaTXfc5Spnk704IwIyRnNrsLFE+TMwOf8SN 9W1w/SF+td/MjaMU95FyQLz0S16krxNTFvDsH8O0kwA9wGEjE1Nlp2retINbgQo/omYS jgdIqGlPCLfRvteEE+5wnIcokxxBMMneHrd5PBhOt2ZNfYPcohCRGTXmI/u6/WEQu5qe /q0Q== X-Forwarded-Encrypted: i=1; AHgh+RppLyheEZ7M/t1UVplKxJbl1ZrzrQIH0x1QqYK+VI4heB+89pUA43gWbF5ec1bKa+FB7vM7cMA4ScvebWE=@vger.kernel.org X-Gm-Message-State: AFuF++lj3y/KhBFFFkib7oQNNQ/Nrh8MWiA7Ki+E9IiuaA20cO9C1P+f pqCWnuxDvPTkWEZJ1BXUdELPLcPUGuwWAdH4OWrxtFuEmL20+ksdn6Dk X-Gm-Gg: AR+sD13gy9eRyD/kfbIjSDQIQegOrGIO/bZn+QRG9lDs5QTP8QeMFQphzfM9duqN605 dhC0KplWkKcMc8jSbkqIGSr26mm0w/imXvzbndVWU6PuNbFHN9N7cDLKzF3F3YYUOsCBagR9+VE mu3Tgk6Q0dGvaKJVjHnGxdFISJTqNH3e2rmoS+VC2eLbHAMnu77+qibF82uIY5uLLAYmL3Ggupc 6UTTYM2Xb+tBJiAqvp5lXZnNqV1CcYkZmUJp8clo5zAMJ2bYj3EGwXF4apqpXfm6cJvA5Dv3Za3 g9hltdi/WHgiH2mSHar80shIItc5mPPkKk7cDKD7/5sfHGTRpu0fJDwQPhCoFQUyMDtIZc7uofO 1g5K5NxeHlZkIkCVjX+TYZA95GHgj+qu95AlJP+LFwcwbSpFrYESHhg1Mp7USGlNYSI+tdPzq/L 01nFQHGyKYwJl9gyWcRSmJ9Ht3u9r+TWFLJ9zovOZRINZyQYSQoFQSxHji/9C4HMxqzqZZN6fJ4 8ldCu85XXMpvtFvhFWyU795eBDACi+nv6QRfqoasyIIeN4TfzQAQKQ3 X-Received: by 2002:a05:600c:4e94:b0:493:f783:c46a with SMTP id 5b1f17b1804b1-499b9198005mr78347705e9.6.1787353877591; Fri, 21 Aug 2026 16:11:17 -0700 (PDT) Received: from [10.128.10.232] (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499b9a848dasm25994015e9.0.2026.08.21.16.11.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Aug 2026 16:11:16 -0700 (PDT) Sender: Julian Braha Message-ID: Date: Sat, 22 Aug 2026 00:11:15 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] irqchip: gic-v3: fix unmet dependency on ARM_PSCI_FW To: Marc Zyngier , Thomas Gleixner Cc: florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, linux@armlinux.org.uk, Frank.Li@nxp.com, s.hauer@pengutronix.de, bcm-kernel-feedback-list@broadcom.com, radu@rendec.net, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, arnd@arndb.de, Sudeep Holla , Mark Rutland , Lorenzo Pieralisi References: <20260801212235.2692694-1-julianbraha@gmail.com> <87lda2j5gs.ffs@fw13> <877bllp5fs.wl-maz@kernel.org> Content-Language: en-US From: Julian Braha In-Reply-To: <877bllp5fs.wl-maz@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Marc, On 8/20/26 09:22, Marc Zyngier wrote: > [+ SMCCC folks] > > Thanks for roping me in. > > This looks like the wrong fix altogether. Whatever the Broadcom stuff > depends on is irrelevant, and has nothing to do with GICv3. Same thing > for the NXP contraptions. > > If there is something to do *for the GIC driver*, it is to make sure > it compiles/links correctly when the platform does not select options > that are not required. Why would NXP and Broadcom care about an > erratum that is specific to NVIDIA? > > I also disagree with what the commit message asserts, ARM_PSCI_FW is > selected *globally* on arm64, not on a per platform basis (TFFT!). > The NVIDIA machine being an arm64 platform, the correct dependency fix > is to select HAVE_ARM_SMCCC_DISCOVERY on arm64. > > The overall issue is that there is no fallback to do something > sensible when HAVE_ARM_SMCCC_DISCOVERY is not selected. Random drivers > should not have to guess or add random #ifdefs all over the shop. > > I came up with the following hack, which compiles correctly on 32bit > ARM without PSCI at all. YMMV. > > Thanks, > > M. > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index 42f2278a702d0..937f17ec93a2e 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -37,7 +37,7 @@ config ARM_GIC_V3 > bool > select IRQ_DOMAIN_HIERARCHY > select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP > - select HAVE_ARM_SMCCC_DISCOVERY > + select HAVE_ARM_SMCCC_DISCOVERY if ARM64 > select IRQ_MSI_IOMMU > > config ARM_GIC_ITS_PARENT > diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h > index 4de81848fe2ee..75f9d3f1723b5 100644 > --- a/include/linux/arm-smccc.h > +++ b/include/linux/arm-smccc.h > @@ -324,6 +324,7 @@ enum arm_smccc_conduit { > SMCCC_CONDUIT_HVC, > }; > > +#ifdef CONFIG_HAVE_ARM_SMCCC_DISCOVERY > /** > * arm_smccc_1_1_get_conduit() > * > @@ -363,6 +364,12 @@ s32 arm_smccc_get_soc_id_version(void); > * When ARM_SMCCC_ARCH_SOC_ID is not present, returns SMCCC_RET_NOT_SUPPORTED. > */ > s32 arm_smccc_get_soc_id_revision(void); > +#else /* CONFIG_HAVE_ARM_SMCCC_DISCOVERY */ > +#define arm_smccc_1_1_get_conduit() SMCCC_CONDUIT_NONE > +#define arm_smccc_get_version() 0 > +#define arm_smccc_get_soc_id_version() SMCCC_RET_NOT_SUPPORTED > +#define arm_smccc_get_soc_id_revision() SMCCC_RET_NOT_SUPPORTED > +#endif /* CONFIG_HAVE_ARM_SMCCC_DISCOVERY */ > > #ifndef __ASSEMBLY__ > > Thank you for explaining. From my tests, your version resolves the unmet dependency well and doesn't introduce others. - Julian Braha