From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "André Draszik" <git@andred.net>, linux-kernel@vger.kernel.org
Cc: alim.akhtar@samsung.com, gregkh@linuxfoundation.org,
jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
"André Draszik" <andre.draszik@linaro.org>
Subject: Re: [PATCH] tty: serial: samsung_tty: remove dead code
Date: Wed, 18 Oct 2023 21:53:58 +0200 [thread overview]
Message-ID: <f4d1bb66-4d1f-47c5-a252-b64d8a505b74@linaro.org> (raw)
In-Reply-To: <3360b33c-a6ce-463f-b2d8-43a08340f3c7@linaro.org>
On 18/10/2023 21:52, Krzysztof Kozlowski wrote:
> On 18/10/2023 12:54, André Draszik wrote:
>> From: André Draszik <andre.draszik@linaro.org>
>>
>> When support for various old platforms was removed in commit
>> 1ea35b355722, s3c24xx_serial_ops also became unused here because
>
> Please use commit xyz ("foo") syntax as pointed out by checkpatch.
>
>> nothing sets port type TYPE_S3C24XX anymore.
>>
>> Remove s3c24xx_serial_ops and all the code that's unreachable now.
>>
>> Fixes: 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks")
>> Signed-off-by: André Draszik <andre.draszik@linaro.org>
>
> Rest looks good:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
.... and not entirely. You left earlycon.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-10-18 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 10:54 André Draszik
2023-10-18 19:52 ` Krzysztof Kozlowski
2023-10-18 19:53 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4d1bb66-4d1f-47c5-a252-b64d8a505b74@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=git@andred.net \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®