From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8963AC001DC for ; Wed, 26 Jul 2023 20:14:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229574AbjGZUOE (ORCPT ); Wed, 26 Jul 2023 16:14:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbjGZUOB (ORCPT ); Wed, 26 Jul 2023 16:14:01 -0400 Received: from smtp.smtpout.orange.fr (smtp-16.smtpout.orange.fr [80.12.242.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B7CC2701 for ; Wed, 26 Jul 2023 13:13:59 -0700 (PDT) Received: from [192.168.1.18] ([86.243.2.178]) by smtp.orange.fr with ESMTPA id OktPq7h8HqvVSOktPq8Ug8; Wed, 26 Jul 2023 22:13:57 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1690402437; bh=Qa7TVI44V2nKCppaEfyl+/fHa4yu5cFhIS8b3fken4U=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=CA/VvfjXbWph3QjMlDHQ2nfL0UZMtcMMOFR1D5kAh2XoZHqHl3z4Yrr4u5TmZUOJL grJlnITnUxL+MsbPUOZFnz9BqF2ZVq8M33cgrhXSTgnikx3yNtb1vY0XM0F5Ix5nhy kMK4lwLwv5hoSsGSq/0MHcD8xkuFb06vmEY9ozHVXzJKYPN5FrS55Ep994r0ZeWf/U CXfZyT4u4UbmwG1fuee9A7mLYMbG1mH7ZJcDtBNGod0l6q1Nkz4r0fdnrQ95NTGQcc fgcrFfI5T+/qUUaSGeERTRmv8VYSXM1LL2trF3d6uW1A+ut4KMdJMHmh95nAjNzLBK xcTLbmTtyhTjQ== X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Wed, 26 Jul 2023 22:13:57 +0200 X-ME-IP: 86.243.2.178 Message-ID: Date: Wed, 26 Jul 2023 22:13:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V1 1/2] regulator: aw37503: add regulator driver for AWINIC AW37503 Content-Language: fr To: like@awinic.com Cc: broonie@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, lgirdwood@gmail.com, liangdong@awinic.com, linux-kernel@vger.kernel.org, liweilei@awinic.com, robh+dt@kernel.org, wangweidong.a@awinic.com References: <20230726081612.586295-1-like@awinic.com> <20230726081612.586295-2-like@awinic.com> From: Christophe JAILLET In-Reply-To: <20230726081612.586295-2-like@awinic.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 26/07/2023 à 10:16, like-tUEr1MkLeujQT0dZR+AlfA@public.gmane.org a écrit : > From: Alec Li > > Add regulator driver for the device AWINIC AW37503 which is single > inductor - dual output power supply device. AW37503 device is > designed to support general positive/negative driven applications > like TFT display panels. > > AW37503 regulator driver supports to enable/disable and set voltage > on its output. > > Signed-off-by: Alec Li [...] > +static int aw37503_probe(struct i2c_client *client) > +{ > + struct device *dev = &client->dev; > + struct aw37503_regulator *chip; > + struct regulator_dev *rdev; > + struct regmap *regmap; > + struct regulator_config config = { }; > + int id; > + int ret; > + > + chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL); > + if (!chip) > + return -ENOMEM; > + > + regmap = devm_regmap_init_i2c(client, &aw37503_regmap_config); > + if (IS_ERR(regmap)) { > + ret = PTR_ERR(regmap); > + dev_err(dev, "regmap init failed: %d\n", ret); > + return ret; > + } > + > + i2c_set_clientdata(client, chip); > + chip->dev = dev; > + > + for (id = 0; id < AW37503_MAX_REGULATORS; ++id) { > + config.regmap = regmap; > + config.dev = dev; > + config.driver_data = chip; I think that these 3 lines could be outside of the loop. > + > + rdev = devm_regulator_register(dev, &aw_regs_desc[id], > + &config); > + if (IS_ERR(rdev)) { > + ret = PTR_ERR(rdev); > + dev_err(dev, "regulator %s register failed: %d\n", > + aw_regs_desc[id].name, ret); > + return ret; > + } > + } > + return 0; > +} [...]