From: Gal Pressman <gal@nvidia.com>
To: Tariq Toukan <ttoukan.linux@gmail.com>, Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>, Jiri Pirko <jiri@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Donald Hunter <donald.hunter@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Jonathan Corbet <corbet@lwn.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-rdma@vger.kernel.org,
Moshe Shemesh <moshe@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
Carolina Jubran <cjubran@nvidia.com>,
Cosmin Ratiu <cratiu@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Dragos Tatulea <dtatulea@nvidia.com>
Subject: Re: [PATCH net-next V9 1/5] devlink: Extend devlink rate API with traffic classes bandwidth management
Date: Wed, 14 May 2025 10:38:51 +0300 [thread overview]
Message-ID: <f4d5d337-6a08-4ca6-8fab-4b640e732c9f@nvidia.com> (raw)
In-Reply-To: <98386cab-11c0-4f74-9925-8230af2e65c8@gmail.com>
On 12/05/2025 17:27, Tariq Toukan wrote:
>> I'm going to also give you a hint that my next complaint will be that
>> there are no selftests in this series, and it extends uAPI.
>
> I have some questions, looking for answers in an official source.
>
> Most importantly, it is unclear to me when a selftest is required. What
> is the guideline?
>
> Please point me to any guidance for this selftest requirement. Is it
> generic, or networking subsystem specific?
>
> Let's make sure these things are well-defined, so we plan the extra
> effort accordingly in future features, and improve predictability.
I have also asked this question in the past, but was ignored:
https://lore.kernel.org/netdev/68e2a8cc-2371-433b-86a3-ac9dea48fb43@nvidia.com/
next prev parent reply other threads:[~2025-05-14 7:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 5:43 [PATCH net-next V9 0/5] Support rate management on traffic classes in devlink and mlx5 Tariq Toukan
2025-05-09 5:43 ` [PATCH net-next V9 1/5] devlink: Extend devlink rate API with traffic classes bandwidth management Tariq Toukan
2025-05-09 15:16 ` Jakub Kicinski
2025-05-11 6:43 ` Carolina Jubran
2025-05-12 14:27 ` Tariq Toukan
2025-05-14 7:38 ` Gal Pressman [this message]
2025-05-09 5:43 ` [PATCH net-next V9 2/5] net/mlx5: Add no-op implementation for setting tc-bw on rate objects Tariq Toukan
2025-05-09 5:43 ` [PATCH net-next V9 3/5] net/mlx5: Add support for setting tc-bw on nodes Tariq Toukan
2025-05-09 5:43 ` [PATCH net-next V9 4/5] net/mlx5: Add traffic class scheduling support for vport QoS Tariq Toukan
2025-05-09 5:43 ` [PATCH net-next V9 5/5] net/mlx5: Manage TC arbiter nodes and implement full support for tc-bw Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4d5d337-6a08-4ca6-8fab-4b640e732c9f@nvidia.com \
--to=gal@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=corbet@lwn.net \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=jgg@ziepe.ca \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®