From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81775263C69 for ; Tue, 20 May 2025 08:44:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747730686; cv=none; b=rLxeIuM+O3LlxVirDYuBlpSrhbpAXXzkhWcJgK8wpB4YUvdXn1JxB4JGP3twgv9SHNmVIBgwDT6Ax31ig2zALVzV+Fwju6x83m6CC+QWiYhJI4+/qvRQAyFXZstVfph0nssQg8J67sghl3pHxlWmV2tVPjgdwpjcPhejv7VZ7Y8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747730686; c=relaxed/simple; bh=0Xj5LvDMQmjQ3ns62cVS3HXkgT/48XqUKBDRmHe1VEg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MrJPgXb+CDKC5j8xabhXWdZGLPTdNGqLSJY/en/PjRsv1jpGAPiH9Oi/DgK6j/47ESnIGNH33cehIbaHkOGPofwBmZE3yNhLQGsM0cwyebFW8EpBmJOjrXy9NiUbY+lUo15B5tB7aG535E0iOfu/emdQ6gGOZ5iOmbW4ypyVtEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=z0Vw/Gvg; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="z0Vw/Gvg" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-442ed8a275fso66580905e9.2 for ; Tue, 20 May 2025 01:44:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747730683; x=1748335483; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yWeDYPzer5lvmBWhpmwPGHZjl/AR9knlnJlWeNFa6z8=; b=z0Vw/GvggXMPg5Tb7PfNlyIZwPymP/sKOoMu8WZ2eMbyNYg7fiskP31/hH9+eV6Ngn +z5n+YmFDLJVS2IYejKgoculwr2ItvEz5K6GEymJM9TGr4JDJ+cg6+RiKvk+u4dfLUht 3GvL+m8tmAdG7LQR+eJOpgL4wdt7tOZvwLEzYir+dOcEFmWqJy260+iAgfa1jr4aMhrK ZA+ZSXxneX8U9n03i6Y0ZI6lLCWDDur2Dx4KXLzkGTwWaOyjiaX/0Ooow8Br5U9Z8WGM 8sGhZk+PeJx6g561GNwNAopYpF5G19HlQ6fW9G0jY3PDZGOhUkQzEERHyjhgOSMIgSBH QutQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747730683; x=1748335483; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yWeDYPzer5lvmBWhpmwPGHZjl/AR9knlnJlWeNFa6z8=; b=aUfYoW8a7yMPKrMiL9zPgjvaP9PLedgIbC9sguX+Kn1wzpURnydDtUlK6VZRrjzN8e nxQWAd75aqSdg/fOnacBKox7MK0500B2hdv1h3htaVopYPdVOhXkJ3QkUrJIE+P7mdYI AGVlcBB2rHY8p0uV3tEaxUGKI5baYFXj/f7iNedvVeFGJJpoqkMnnwdMu8lXRKvpGvZD DaI8z3wr+7DPosPsuKK80aLHUIAG5/8qb3niZkHURk7wz+jeVc7hIk3tjMIL0aSZC+de X8JhVaA4jMk9cnsREEgIPlQMkAb+xj4jTLCrDc0kBt2iSuQNAgIGTIEuyiSnigpBsH7z BlkQ== X-Forwarded-Encrypted: i=1; AJvYcCU27IXA56hH6hQl4MEYFxSpMyJ1lYPsALX9KvX1lpdC6JkTFAfZaZc8w9lnTtZ1T3E9yNigAz/niM+iZuA=@vger.kernel.org X-Gm-Message-State: AOJu0YwbJqJxuT72txpCzQ4wRJTCbqf28yZCFMLMcI/IVeOA1xIYyWvd VlZM2eJSaoXvTltcMl04n8NGeIiY0kQQIHuGLdLwv0/8Y7qAp78QDNH/3xsclbCup8U= X-Gm-Gg: ASbGncuS7rIAD4pTTbb69nEPExkWUoizJDMH5yGGUJvKAxV2SzLw+K/9m1VrSDi3qjC wU58UTcCh5O4a9SvLyD52eQ2NSoluStl8evjQi/zeQphYwGoXlCa7QZ45XbXYXSRj8wjrEPHxhR 71XvnUfuHN9uDXMzniqINyOBg5LjBkHWU3b9wFrfTG4Kz0V5HnPg9B8yWiaft9bq8T8W/3AgvTp WukiOS4ApbwnPyD+gxA/VPIc4WVlRC9u7zUonFtqVMyuvGqkzMLOo0uBDtRqoxs5wESLEVrln58 6XcG4de4raWgQkXuJBEoso7E7l0ha0g2IT+yCvq9ffOzx5nzPVodH0iLEAEKJf1j8euixkHKis6 SSSu3Y/Anwmo0I6AZuw1600HTz4U= X-Google-Smtp-Source: AGHT+IF6NhADUfXiocDJ+6PeTfYhBqXsTDb3TbAMg5ZVulgBv551nMiYfKj8WbDC+p8XrLioJ6C1Bw== X-Received: by 2002:a05:600c:1e1c:b0:442:c98f:d8cf with SMTP id 5b1f17b1804b1-44302934f7bmr139974495e9.16.1747730682773; Tue, 20 May 2025 01:44:42 -0700 (PDT) Received: from [192.168.0.34] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f73d4b68sm21711235e9.23.2025.05.20.01.44.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 May 2025 01:44:42 -0700 (PDT) Message-ID: Date: Tue, 20 May 2025 09:44:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] media: qcom: camss: vfe: Stop spamming logs with version To: Krzysztof Kozlowski , Johan Hovold Cc: Robert Foss , Todor Tomov , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250429180828.950219-4-krzysztof.kozlowski@linaro.org> <3e34ce09-1207-4dba-bff8-38c01cad9b78@linaro.org> <4d942a6c-cbff-41ac-af8b-12a1ff5181aa@linaro.org> <883eb54a-fcaf-443c-a4d7-e1278fd43f5a@linaro.org> <190100e7-8a59-4cf3-8434-bcb6292cacb2@linaro.org> <8a2f2269-d07f-42b2-ab6c-dcff30a1f431@linaro.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <8a2f2269-d07f-42b2-ab6c-dcff30a1f431@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/05/2025 09:30, Krzysztof Kozlowski wrote: > On 20/05/2025 10:23, Johan Hovold wrote: >> On Tue, May 20, 2025 at 10:02:32AM +0200, Krzysztof Kozlowski wrote: >>> On 20/05/2025 09:53, Johan Hovold wrote: >> >>>> Spamming the logs as the driver currently does is clearly broken and >>>> should be fixed. Keeping a hw version dev_dbg() is generally perfectly >>>> fine, though. >> >>> My main argument, expressed in the commit msg to which no one objected, >>> is that this debug is 100% useless: deducible from the compatible, >>> always known upfront, always the same. >> >> To me that deduction does not seem straightforward, at least not without >> access to internal qualcomm docs, for example: >> >> compatible = "qcom,sc8280xp-camss"; >> >> qcom-camss ac5a000.camss: VFE:0 HW Version = 1.2.2 >> qcom-camss ac5a000.camss: VFE:1 HW Version = 1.2.2 >> qcom-camss ac5a000.camss: VFE:2 HW Version = 1.2.2 >> qcom-camss ac5a000.camss: VFE:3 HW Version = 1.2.2 >> qcom-camss ac5a000.camss: VFE:4 HW Version = 1.3.0 >> qcom-camss ac5a000.camss: VFE:5 HW Version = 1.3.0 >> qcom-camss ac5a000.camss: VFE:6 HW Version = 1.3.0 >> qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0 >> > > I understand that deduction is not straightforward, but it is also a > fixed one, meaning it will be always sc8280xp -> (vFOO, vBAR), thus the > only usefulness of above is to map each compatible to pair of two HW > versions. This can be done via debugfs interface once and stored in > public docs. No need to do that mapping every time driver probes and my > patches drop nice chunk of code, including indirect function calls. > > At least so far no one objected that same compatible maps to same pairs > of HW versions. > >> Whether the hw version is actually useful to anyone debugging this >> driver I can't say, but keeping it printed *once* seems perfectly >> alright if someone wants to keep it (e.g. as we have a long history of >> working around hw bugs based on revision information like this). > > Now if you claim that one needs access to qcom docs to deduce it, I > claim this version would be useful only to qcom people (or > qcom-NDA-access-to-HPG) folks. > > > Best regards, > Krzysztof I find the debug prints useful in that I know the hardware block has been powered on, clocked etc. I agree the number of those prints seems excessive. The reason it is printed out multiple time is the blocks get powered on/off. Personally I agree with Johan - it would be nice/useful to print it out once with DEBUG on, so that we know we have successfully powered-on and identified the blocks once. Doing it over and over again is excessive as failure to power-on will surely produce error messages anyway. --- bod