From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2F883033DE for ; Mon, 15 Jun 2026 18:09:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781546989; cv=none; b=fLm+gDx1ultySSG9KHydmCI2u2yj38g+bZwX7EmRiOQsBzKZ/0D4ft1BdkJh0M3on6GoIHaCP4TwocwHJPpYrnakRQluNraYFtw0fznEJWL1Gu9Mp+vxlw/KH/qIXyPNigP2OIS/UiSLPk+UvX2oVAQ8u+u/hyKFuaZdTBfff8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781546989; c=relaxed/simple; bh=+/YIfAZx6Y1TDdcNE4r7VNCbv7pZjjigABYxTNijrxM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d6Z6GiV9AUqIMpow6TTv4xJzDFqVnjQ3i/GgH64Z5cZa0QzvuvqukyiC7ec4sSG37KmkrHk0vbI/yjuxWhgI0Fc3PfKrpHRZpua8pSsA8kFEY7l71hxNZPZU9v15scJGkTvxSGkLzjcTxx9Cik/gZ5jD6xgGCBxdyW02kQokyuY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IpemTdun; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fhKOB5ai; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IpemTdun"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fhKOB5ai" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FFhMLu430424 for ; Mon, 15 Jun 2026 18:09:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OZXH7NQPKLN5DjAC/OW8MEpdTAtaJcMt3HJcX6yL1CQ=; b=IpemTdun7BE4c8aM G6fZoFhhPOLEPP5lstIw3n4cwYIrk3xrb4FW9e65UKhxXWlylVWLyBPrtTCm3xBc NNZSY4rCfBVEiiLyvZVssDD7+lEtafo6qK2ef74/Vw1nC3OK4mLEL1pRSZs6K+VR jw+9zYofXd9aJfzR59fYbcqXpZgFoaxvr8dKnPGy3lFCUNINRfHidm4IYMvNtDZ7 6++Ko5QqRDZcMIDzUWDL4KMLMXHNeiGspqJfvEkCloZ9leneZ8Le5RSgtM2Txkng rYhp7SzBv+Kq+/pnPHEWSGuuiRys6ki7+Scc4u/DpQKT/uACkQmXJ4bPpqVOFCfl L4Qoyg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eteyda7da-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 18:09:47 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2bf55c3f44aso34670225ad.0 for ; Mon, 15 Jun 2026 11:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781546986; x=1782151786; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OZXH7NQPKLN5DjAC/OW8MEpdTAtaJcMt3HJcX6yL1CQ=; b=fhKOB5ai1F4PYg7vn29LzT85DzXwgg69jNQL+8bn9V95EsE5IP8eB2fTYk8CzyqgVT 2tLBc/wFvFwiefRRMB5a5LxnqhctekgdvgKizi0yccbKMdz3/zVQ5FNUvhyhHkSdHR4V KVnpu3qE9WnG9Q47cJUg4hhiMAcabRJkV8UWj25yD4iDYRyxUxvqquVdOWYPHfediVnN JMxTzVWhstSOXFDKg9WC+oBcLcQZ/83s8vdK3aUqheFmDyEEmVHDeiX3/smUQRVUuE3q Tj9nyeGu0llUul5r8aT/UMzplL9zGCDnOpH9NTVdvq76d9dKfng5ItUHaKn6ovsWvhtr yOOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781546986; x=1782151786; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OZXH7NQPKLN5DjAC/OW8MEpdTAtaJcMt3HJcX6yL1CQ=; b=NiJO3XJxm5BlWU56WyhvZlB9pDLq/RFpRPSKNcFtAm8vgkNKiJjgQkrEHy3oSB3qzQ AiGhqXhiegz81ot5HTINru65uKn0aC9nVXcRXKoGmUI0ibgxpr79OXFyp/ocy2wNO6Ig N0WwUKixxuICEUq784O09758EW9snk+EoD3ow2O083CoWiYcsYRcZn+FB4qsLipkRiDF JP5VBl/pT/Up652YAqFY7l9OWIzElojXnmrihGdWKMMdgi1PVLD/D5RRW1Pe0aZ9sawT ST4+WcrRDW0/R4FXkZ/T0bxLMoOqPLhzblb3n+qbjdZW0Q75B3Wt+LI17HMe455OV6PV fZ7A== X-Forwarded-Encrypted: i=1; AFNElJ9u9hwfL6Mp7DREROSML/esH7B2buKrYxMGqaft2vsGdYWe2IRjr2HVrgRJDk+U+jS/SFRKAWZUKioHqHY=@vger.kernel.org X-Gm-Message-State: AOJu0YzStZ5sYIUQ5+DYOS91kZ31AKgiwW54AOjKmaZQRYjFp2XGzmje Wv3xeeLWa9CDPZDZoUiA401pTNkKdCfUiM/Ok8JH4+cNdEKb57EYqsHXe9HAOoUxaBsIEjoJy2z wnL5WpwI8FuDXanl/X5n7eVkstJx3+hF1AkwO+E05RDiEYAIUq1kjBjKjktwMSdRMrng= X-Gm-Gg: Acq92OGeFx+/62OL7meprbaiWvDjD/JjNA/Uh/VYYTYFna6k0Xv0guMT8054ZVljoWV 0HHiN1mOcRDU5Vno/2Ed67kksEUTPVdAH75AoUl+32yMQJ83Br9QRbjV/q6irYV63Ow578vTT2I jZRP1oW7cvKlGqEWBm/QkTG9iZtQRFrFUfj3tb82hanyfSUytrSTSdpAWDpjLZutveN6Te/mZ3b 3s5A5W97AGcN74cfN+xkJLN1shCl2mwzQC/UzXBDk3ej6O7FdhiLNArlY1B4vPcT6KZw26Evp5M BxgmfdaYQDThcJJvEgHshQ0NCMLRy+yB2owR0rCel5x4rCYajk9MABVU384rrNkzLiv/fJiILE9 dxUkLnso2ST361QCvii4rY375W1a82Y2i9lPi1SGApFkcHcaMNNtzs2Y9 X-Received: by 2002:a17:903:3a8b:b0:2bf:2d0:8877 with SMTP id d9443c01a7336-2c699b739efmr3749615ad.23.1781546986471; Mon, 15 Jun 2026 11:09:46 -0700 (PDT) X-Received: by 2002:a17:903:3a8b:b0:2bf:2d0:8877 with SMTP id d9443c01a7336-2c699b739efmr3749245ad.23.1781546985957; Mon, 15 Jun 2026 11:09:45 -0700 (PDT) Received: from [10.187.126.18] ([106.221.183.253]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f2e535csm103379135ad.6.2026.06.15.11.09.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 11:09:45 -0700 (PDT) Message-ID: Date: Mon, 15 Jun 2026 23:39:37 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 07/16] media: iris: Add platform flag for instantaneous bandwidth voting Content-Language: en-US To: Dmitry Baryshkov , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dikshita Agarwal References: <20260612-iris-ar50lt-v4-0-0abfb74d5b3c@oss.qualcomm.com> <20260612-iris-ar50lt-v4-7-0abfb74d5b3c@oss.qualcomm.com> From: Vishnu Reddy In-Reply-To: <20260612-iris-ar50lt-v4-7-0abfb74d5b3c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 6xqpSig3euWab4oWOIepxinpVHIHOKPY X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDE5MiBTYWx0ZWRfX63JZF6eGFq4W sYSH2s32qvOVnw5L1fhq4HjpwH+RV9mQg+1M/upSdwfKH8LE4F5QzJ4ayuBpOhlOpnudHaYHtdn UuMFf+4i3MixSDIHgw1mMCk5KtSX710= X-Authority-Analysis: v=2.4 cv=QrJuG1yd c=1 sm=1 tr=0 ts=6a303feb cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ym48ABLkKUHSTpi9L/JoRg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=jI4A6vEBTXP-BcUGSgUA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: 6xqpSig3euWab4oWOIepxinpVHIHOKPY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDE5MiBTYWx0ZWRfX9rOVwQMHtCm3 r0SSWyGuVMnZKOtcfVH8A9jYb2+YoiP5scGu4+RyI1YL7UJ7lQ0EWxmTuiaYkn3zFYAUjWZNSnb B/J9ira2o2eAqk8TH6O0z0io3SF8mPzcZoAICI2vaX7IGQ7NmF84KTSNr+dnAsl9khZkhu4X3R9 tEpx3KS/MF7rF/9agCjH2hlL8t+lqfoymEZyhJsXAU5LuQGXMhsLRpmb2pLEO4J3vCRPEr+oJlQ Z55ZZxi6A26K5+KsqzsgUf83gN3Zb4kXJWJG06qwBNBjz1Gv5I4f4JNdNVajBxajXx4n4DXbLKn aN3LrAlzhJt7M64IQ0b1dvr/rElK4H47SlafBQtpCQcEZKjj/+Ga2ANuHsGKYk2Ccsxse2l3iF+ XQ/aOgoKEyb6qnLASs6UFOEv3iG1/BQlzUObQHmvE4HZusWGopX01o+fa5muqc8I35joFSiTfFU UbIkS2OT/oHn0tdZepA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_04,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0 phishscore=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150192 On 6/12/2026 2:55 PM, Dmitry Baryshkov wrote: > From: Dikshita Agarwal > > AR50LT require explicit instantaneous bandwidth (IB) voting in addition > to average bandwidth (AB) when configuring interconnect QoS. This > requirement is due to QSB (Qualcomm System Bus) 128b to > QNS ( Qualcomm Network Switch) 256b conversion at video noc in AR50LT > which is not needed for other IRIS cores. > > In preparation of adding support for AR50LT core, introduce > platform-configurable IB multiplier and enable IB voting for all SoCs. > Existing platforms default to IB == AB, while AR50LT requires 2x peak > bandwidth. > > Signed-off-by: Dikshita Agarwal > Reviewed-by: Vikash Garodia > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_platform_common.h | 1 + > drivers/media/platform/qcom/iris/iris_platform_vpu2.c | 2 ++ > drivers/media/platform/qcom/iris/iris_platform_vpu3x.c | 4 ++++ > drivers/media/platform/qcom/iris/iris_resources.c | 2 ++ > 4 files changed, 9 insertions(+) > > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h > index 81fcb2854772..accc1627defd 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h > @@ -316,6 +316,7 @@ struct iris_platform_data { > u32 num_vpp_pipe; > bool no_aon; > u32 wd_intr_mask; > + u32 icc_ib_multiplier; > u32 max_session_count; > /* max number of macroblocks per frame supported */ > u32 max_core_mbpf; > diff --git a/drivers/media/platform/qcom/iris/iris_platform_vpu2.c b/drivers/media/platform/qcom/iris/iris_platform_vpu2.c > index eeef453c583f..e2fddc29abc7 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_vpu2.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_vpu2.c > @@ -97,6 +97,7 @@ const struct iris_platform_data sc7280_data = { > .num_vpp_pipe = 1, > .no_aon = true, > .wd_intr_mask = WRAPPER_INTR_STATUS_A2HWD_BMSK, > + .icc_ib_multiplier = 1, > .max_session_count = 16, > .max_core_mbpf = 4096 * 2176 / 256 * 2 + 1920 * 1088 / 256, > /* max spec for SC7280 is 4096x2176@60fps */ > @@ -128,6 +129,7 @@ const struct iris_platform_data sm8250_data = { > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_vpu2), > .num_vpp_pipe = 4, > .wd_intr_mask = WRAPPER_INTR_STATUS_A2HWD_BMSK, > + .icc_ib_multiplier = 1, > .max_session_count = 16, > .max_core_mbpf = NUM_MBS_8K, > .max_core_mbps = ((7680 * 4320) / 256) * 60, > diff --git a/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c b/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c > index 261db38a013b..64cf182d67cc 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c > @@ -116,6 +116,7 @@ const struct iris_platform_data qcs8300_data = { > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_vpu3), > .num_vpp_pipe = 2, > .wd_intr_mask = WRAPPER_INTR_STATUS_A2HWD_BMSK, > + .icc_ib_multiplier = 1, > .max_session_count = 16, > .max_core_mbpf = ((4096 * 2176) / 256) * 4, > .max_core_mbps = (((3840 * 2176) / 256) * 120), > @@ -146,6 +147,7 @@ const struct iris_platform_data sm8550_data = { > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_vpu3), > .num_vpp_pipe = 4, > .wd_intr_mask = WRAPPER_INTR_STATUS_A2HWD_BMSK, > + .icc_ib_multiplier = 1, > .max_session_count = 16, > .max_core_mbpf = NUM_MBS_8K * 2, > .max_core_mbps = ((7680 * 4320) / 256) * 60, > @@ -184,6 +186,7 @@ const struct iris_platform_data sm8650_data = { > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_vpu3), > .num_vpp_pipe = 4, > .wd_intr_mask = WRAPPER_INTR_STATUS_A2HWD_BMSK, > + .icc_ib_multiplier = 1, > .max_session_count = 16, > .max_core_mbpf = NUM_MBS_8K * 2, > .max_core_mbps = ((7680 * 4320) / 256) * 60, > @@ -214,6 +217,7 @@ const struct iris_platform_data sm8750_data = { > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_vpu3), > .num_vpp_pipe = 4, > .wd_intr_mask = WRAPPER_INTR_STATUS_A2HWD_BMSK, > + .icc_ib_multiplier = 1, > .max_session_count = 16, > .max_core_mbpf = NUM_MBS_8K * 2, > .max_core_mbps = ((7680 * 4320) / 256) * 60, > diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/media/platform/qcom/iris/iris_resources.c > index 773f6548370a..caeaf199cef7 100644 > --- a/drivers/media/platform/qcom/iris/iris_resources.c > +++ b/drivers/media/platform/qcom/iris/iris_resources.c > @@ -18,6 +18,7 @@ > > int iris_set_icc_bw(struct iris_core *core, unsigned long icc_bw) > { > + u32 icc_ib_multiplier = core->iris_platform_data->icc_ib_multiplier; > unsigned long bw_kbps = 0, bw_prev = 0; > const struct icc_info *icc_tbl; > int ret = 0, i; > @@ -36,6 +37,7 @@ int iris_set_icc_bw(struct iris_core *core, unsigned long icc_bw) > return ret; > > core->icc_tbl[i].avg_bw = bw_kbps; > + core->icc_tbl[i].peak_bw = bw_kbps * icc_ib_multiplier; > > core->power.icc_bw = bw_kbps; > break; Reviewed-by: Vishnu Reddy