From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932426AbcHLRuh (ORCPT ); Fri, 12 Aug 2016 13:50:37 -0400 Received: from us-mx1.synaptics.com ([192.147.44.131]:52792 "EHLO us-mx1.synaptics.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932307AbcHLRue (ORCPT ); Fri, 12 Aug 2016 13:50:34 -0400 Subject: Re: [PATCH v3 0/8] Input: synaptics-rmi4: Reimplement functionality from hid-rmi To: , References: <1468476475-7884-1-git-send-email-aduggan@synaptics.com> CC: Dmitry Torokhov , Linus Walleij , Jiri Kosina , Benjamin Tissoires , Vincent Huang , Nick Dyer , Chris Healy From: Andrew Duggan Message-ID: Date: Fri, 12 Aug 2016 10:50:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1468476475-7884-1-git-send-email-aduggan@synaptics.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.4.10.103] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, I wanted to check on the status of this patch series. It looks like patches 2, 3, 4, and 7 remain outstanding. For the most part all of the patches have either review or ack signoffs. The version 2 of patch 2 was reviewed by Benjamin Tissoires, but not v3. However, the changes between v2 and v3 are fairly trivial and noted in the patch under the signoff line. I think patch three is the most controversial since it generated some discussion about whether or not those parameters belong in device tree. I attempted to explain why I thought they did in one of my replies. However, if you don't think that issues has been resolved I would recommend skipping that patch instead of holding up the others. Let me know if there is anything else I need to address. Thanks, Andrew On 07/13/2016 11:07 PM, Andrew Duggan wrote: > The v3 version of this patch series makes changes to patch 1 and patch 3. > Patch 1 now uses of_get_child_by_name() instead of of_find_node_by_name() > to avoid having to increment the refcount of the of_node which avoid > that hack. Patch 3 adds "force" to the device tree parameters to help to > clarify that these parameters overwrite the default value set in the > firmware configuration. > > Thanks, > Andrew > > Andrew Duggan (8): > Input: synaptics-rmi4: Use of_get_child_by_name() instead of > of_find_node_by_name() > Input: synaptics-rmi4: Add parameters for dribble packets and palm > detect gesture > Input: synaptics-rmi4: Add dribble and palm gesture parameters to > device tree > Input: synaptics-rmi4: Add support for controlling dribble packets in > F12 > Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data > Input: synaptics-rmi4: Remove unneeded variable > Input: synaptics-rmi4: Handle incomplete input data > Input: synaptics-rmi4: Use the RMI_F11_REL_BYTES define in > rmi_f11_rel_pos_report > > .../bindings/input/rmi4/rmi_2d_sensor.txt | 10 +++ > drivers/input/rmi4/rmi_2d_sensor.c | 13 +++ > drivers/input/rmi4/rmi_2d_sensor.h | 2 + > drivers/input/rmi4/rmi_bus.c | 4 +- > drivers/input/rmi4/rmi_f01.c | 6 +- > drivers/input/rmi4/rmi_f11.c | 95 +++++++++++++++------ > drivers/input/rmi4/rmi_f12.c | 98 ++++++++++++++++++++-- > drivers/input/rmi4/rmi_f30.c | 4 + > include/linux/rmi.h | 21 +++-- > 9 files changed, 208 insertions(+), 45 deletions(-) >