mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Werner Sembach <wse@tuxedocomputers.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Armin Wolf <W_Armin@gmx.de>, Hans de Goede <hansg@kernel.org>,
	platform-driver-x86@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] platform/x86: uniwill-laptop: Enable kb backlight and lightbar for TUXEDO
Date: Fri, 18 Sep 2026 16:18:12 +0200	[thread overview]
Message-ID: <f4e1407b-64b9-4c46-ab0b-76e6a33512f2@tuxedocomputers.com> (raw)
In-Reply-To: <1bf299f1-6b97-db97-3bdf-7c0b41999022@linux.intel.com>

Hi,

Am 17.09.26 um 16:45 schrieb Ilpo Järvinen:
> On Sat, 22 Aug 2026, Werner Sembach wrote:
>
>> Enable EC controlled keyboard backlight across the board for TUXEDO
>> devices.
>>
>> This has split up the device descriptors even more, so the "featureset"
>> naming scheme was dropped in favor of a "generalized board_name" naming
>> scheme.
>>
>> Also Stellaris and Polaris Gen3 are now identified by product_sku to split
>> them up.
>>
>> Also some TUXEDO devices with lightbar still had the support missing. This
>> patch completes the list in this point.
>>
>> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
>> Reviewed-by: Armin Wolf <W_Armin@gmx.de>
> Hi,
>
> Could this change be split such that mechanical large-scale changes such
> as descriptor renames are done in own patch?

The descriptor renames are mainly because there are now more descriptors 
required and most of them after the change only apply to a few Boardnames.

So doing it in 2 steps would either mean:

- Having the old descriptor naming scheme and the new one side by side in one 
patch because more are needed and the old scheme doesn't make sense for them.

or

- Renaming the old descriptor names to new longer ones, because they apply to 
many boardnames, first, and then rename them again as soon as they get split up 
in the next patch.

Because of this connection I think it makes sense to do this atomic in one 
commit, but ofc I can try 2 commit, probably with version one. Let me know.

Best regards,

Werner


  reply	other threads:[~2026-09-18 14:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-22  0:28 [PATCH v3 1/2] platform/x86: uniwill-laptop: Fix brightness notify for 3 level keyboards Werner Sembach
2026-08-22  0:28 ` [PATCH v3 2/2] platform/x86: uniwill-laptop: Enable kb backlight and lightbar for TUXEDO Werner Sembach
2026-09-17 14:45   ` Ilpo Järvinen
2026-09-18 14:18     ` Werner Sembach [this message]
2026-08-26 21:37 ` [PATCH v3 1/2] platform/x86: uniwill-laptop: Fix brightness notify for 3 level keyboards Armin Wolf
2026-09-11 20:57   ` Armin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4e1407b-64b9-4c46-ab0b-76e6a33512f2@tuxedocomputers.com \
    --to=wse@tuxedocomputers.com \
    --cc=W_Armin@gmx.de \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®