From: Markus Elfring <Markus.Elfring@web.de>
To: Kaushlendra Kumar <kaushlendra.kumar@intel.com>, rcu@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Frederic Weisbecker <frederic@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v3] rcu/rcutorture: Improve error handling in rcu_torture_fwd_prog_init()
Date: Wed, 10 Sep 2025 16:01:55 +0200 [thread overview]
Message-ID: <f4e20f17-db56-4a3d-a673-b7349dde2495@web.de> (raw)
In-Reply-To: <20250910121427.3757718-1-kaushlendra.kumar@intel.com>
…> The improved approach:
> - Check rfp allocation immediately and return early on failure.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.17-rc5#n532
> - Separately handle fwd_prog_tasks allocation failure with proper
> cleanup of allocated resources.
> - Remove redundant kfree(fwd_prog_tasks) since it would be NULL on
> allocation failure.
Would it be cleaner to offer desirable changes by separate update steps?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc5#n81
How do you think about to increase the application of scope-based resource management?
Regards,
Markus
prev parent reply other threads:[~2025-09-10 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 12:14 Kaushlendra Kumar
2025-09-10 14:01 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4e20f17-db56-4a3d-a673-b7349dde2495@web.de \
--to=markus.elfring@web.de \
--cc=dave@stgolabs.net \
--cc=frederic@kernel.org \
--cc=josh@joshtriplett.org \
--cc=kaushlendra.kumar@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neeraj.upadhyay@kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®