mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Oza Oza <oza.oza@broadcom.com>,
	Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] NVMe Configuraiton using sysctl
Date: Mon, 15 May 2017 12:15:28 +0300	[thread overview]
Message-ID: <f4e5a2bd-9e41-8025-31a9-9bcadd2468c3@grimberg.me> (raw)
In-Reply-To: <CAMSpPPf640XfjW38=NXHmkDG0SeduavOEkKiEJuGmobq183jNg@mail.gmail.com>


>> Hi,

Hi Oza,

>> we are configuring interrupt coalesce for NVMe, but right now, it uses
>> module param.
>> so the same interrupt coalesce settings get applied for all the NVMEs
>> connected to different RCs.
>>
>> ideally it should be with sysctl.

If at all, I would place this in nvme-cli (via ioctl) instead of
sysctl.

>> for e.g.
>> sysctl should provide interface to change
>> Per-CPU IO queue pairs, interrupt coalesce settings etc..

My personal feeling is that percpu granularity is a lot to take in for
the user, and also can yield some unexpected performance
characteristics. But I might be wrong here..

>> please suggest if we could have/implement sysctl module for NVMe ?

I have asked this before, but interrupt coalescing has very little
merit without being able to be adaptive. net drivers maintain online
stats and schedule interrupt coalescing modifications.

Should work in theory, but having said that, interrupt coalescing as a
whole is essentially unusable in nvme since the coalescing time limit
is in units of 100us increments...

  reply	other threads:[~2017-05-15  9:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15  8:34 Oza Oza
2017-05-15  8:39 ` Oza Oza
2017-05-15  9:15   ` Sagi Grimberg [this message]
2017-05-15 10:59     ` Oza Oza
2017-05-15 14:44     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4e5a2bd-9e41-8025-31a9-9bcadd2468c3@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=axboe@fb.com \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=oza.oza@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®