From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751189AbdAaWOi (ORCPT ); Tue, 31 Jan 2017 17:14:38 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:34924 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbdAaWOg (ORCPT ); Tue, 31 Jan 2017 17:14:36 -0500 Subject: Re: [PATCH V3 net-next 02/14] net/ena: fix error handling when probe fails To: Lino Sanfilippo , linux-kernel@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org References: <1485469096-5271-1-git-send-email-netanel@annapurnalabs.com> <1485469096-5271-3-git-send-email-netanel@annapurnalabs.com> <174cba24-4bf4-4212-9756-2bedf4fa5a92@gmx.de> Cc: dwmw@amazon.com, zorik@annapurnalabs.com, alex@annapurnalabs.com, saeed@annapurnalabs.com, msw@amazon.com, aliguori@amazon.com, nafea@annapurnalabs.com, eric.dumazet@gmail.com From: Netanel Belgazal Message-ID: Date: Wed, 1 Feb 2017 00:14:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <174cba24-4bf4-4212-9756-2bedf4fa5a92@gmx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, You are right. I'll remove this patch. Regards, Netanel On 01/28/2017 01:33 AM, Lino Sanfilippo wrote: > Hi, > > On 26.01.2017 23:18, Netanel Belgazal wrote: >> When driver fails in probe, it will release all resources, >> including adapter. >> In case of probe failure, ena_remove should not try to >> free the adapter resources. >> >> Signed-off-by: Netanel Belgazal >> --- >> drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c >> b/drivers/net/ethernet/amazon/ena/ena_netdev.c >> index 7493ea3..cb60567 100644 >> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c >> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c >> @@ -3046,6 +3046,7 @@ static int ena_probe(struct pci_dev *pdev, >> const struct pci_device_id *ent) >> err_free_region: >> ena_release_bars(ena_dev, pdev); >> err_free_ena_dev: >> + pci_set_drvdata(pdev, NULL); >> vfree(ena_dev); >> err_disable_device: >> pci_disable_device(pdev); >> > > Is this change really a "fix"? remove() should only be called if > probe() has been successful before, otherwise not. Did you experience > something different? > > Regards, > Lino