mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>, Eric Dumazet <edumazet@google.com>
Cc: x86 <x86@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Hugh Dickins <hughd@google.com>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v2 1/2] x86, msr: add rdmsr_safe_on_cpu_resched() and use it in msr_read()
Date: Fri, 23 Mar 2018 14:30:58 -0700	[thread overview]
Message-ID: <f4e89d95-1cd8-a9c9-cc93-77c35d82e76b@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1803232221550.1481@nanos.tec.linutronix.de>



On 03/23/2018 02:27 PM, Thomas Gleixner wrote:
>
> Looking at all call sites. None of them is performance critical and all of
> them are in preemptible context.
> 
> So we simply can switch the rdmsr_safe_on_cpu() implementation over to wait
> mode completely.

SGTM, thanks for looking, I will send a v3 then.

> 
>> +/* Note: This version spins in smp_call_function_single().
>> + * Consider using rdmsr_safe_on_cpu_resched() variant instead.
> 
> Bah. This is not networking code. x86 uses sensible comment style :)

Right ;)

      reply	other threads:[~2018-03-23 21:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-19 15:25 Eric Dumazet
2018-03-19 15:25 ` [PATCH v2 2/2] x86, cpuid: allow cpuid_read() to schedule Eric Dumazet
2018-03-23 21:27 ` [PATCH v2 1/2] x86, msr: add rdmsr_safe_on_cpu_resched() and use it in msr_read() Thomas Gleixner
2018-03-23 21:30   ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4e89d95-1cd8-a9c9-cc93-77c35d82e76b@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=bp@alien8.de \
    --cc=edumazet@google.com \
    --cc=hpa@zytor.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome