mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: akpm@linux-foundation.org
Cc: mgorman@techsingularity.net, vbabka@suse.cz,
	baolin.wang@linux.alibaba.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/6] mm: compaction: skip more fully scanned pageblock
Date: Thu, 25 May 2023 20:53:58 +0800	[thread overview]
Message-ID: <f4efd2fa08735794a6d809da3249b6715ba6ad38.1685018752.git.baolin.wang@linux.alibaba.com> (raw)
In-Reply-To: <cover.1685018752.git.baolin.wang@linux.alibaba.com>

In fast_isolate_around(), it assumes the pageblock is fully scanned if
cc->nr_freepages < cc->nr_migratepages after trying to isolate some free
pages, and will set skip flag to avoid scanning in future. However this
can miss setting the skip flag for a fully scanned pageblock (returned
'start_pfn' is equal to 'end_pfn') in the case where cc->nr_freepages
is larger than cc->nr_migratepages.

So using the returned 'start_pfn' from isolate_freepages_block() and
'end_pfn' to decide if a pageblock is fully scanned makes more sense.
It can also cover the case where cc->nr_freepages < cc->nr_migratepages,
which means the 'start_pfn' is usually equal to 'end_pfn' except some
uncommon fatal error occurs after non-strict mode isolation.

Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
---
 mm/compaction.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index 3737c6591bfb..1e5183f39ca9 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1411,7 +1411,7 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn)
 	isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false);
 
 	/* Skip this pageblock in the future as it's full or nearly full */
-	if (cc->nr_freepages < cc->nr_migratepages)
+	if (start_pfn == end_pfn)
 		set_pageblock_skip(page);
 
 	return;
-- 
2.27.0


  parent reply	other threads:[~2023-05-25 12:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25 12:53 [PATCH 0/6] Misc cleanups and improvements for compaction Baolin Wang
2023-05-25 12:53 ` [PATCH 1/6] mm: compaction: drop the redundant page validation in update_pageblock_skip() Baolin Wang
2023-05-30  7:27   ` Vlastimil Babka
2023-05-31  1:44     ` Baolin Wang
2023-05-25 12:53 ` [PATCH 2/6] mm: compaction: change fast_isolate_freepages() to void type Baolin Wang
2023-05-30  7:29   ` Vlastimil Babka
2023-05-25 12:53 ` Baolin Wang [this message]
2023-05-30  7:59   ` [PATCH 3/6] mm: compaction: skip more fully scanned pageblock Vlastimil Babka
2023-05-25 12:53 ` [PATCH 4/6] mm: compaction: only set skip flag if cc->no_set_skip_hint is false Baolin Wang
2023-05-30  8:03   ` Vlastimil Babka
2023-05-25 12:54 ` [PATCH 5/6] mm: compaction: add trace event for fast freepages isolation Baolin Wang
2023-05-30  8:24   ` Vlastimil Babka
2023-05-25 12:54 ` [PATCH 6/6] mm: compaction: skip fast freepages isolation if enough freepages are isolated Baolin Wang
2023-05-30  8:32   ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4efd2fa08735794a6d809da3249b6715ba6ad38.1685018752.git.baolin.wang@linux.alibaba.com \
    --to=baolin.wang@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®