From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 725EC3563E1 for ; Wed, 19 Aug 2026 01:50:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787104247; cv=none; b=Sv/yG6XrLiHzvPlWaSPmfW7Qv9d5eA6Al7w04tJwre7rZUyffhvxX82yY4Qp3GFLiwyp5OL1z9hBXuZ4sB3WZ/sk0SQ0R4dJP14XUc15MAKNL5RbA5CIsM8jwvh32GQixZL3FVqjm++G7or2C/LoX1OCJOpmYnNDSr/91V3kaH0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787104247; c=relaxed/simple; bh=pT8P5jQD5hCdnFw7bbcrY3787tTT/uIqbzpCuSOxcq0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GJiFVvuyZVaniGByzrbWR6Gnmqor6eM1yUrDMxmZ7vrYCVG+V2No7nkUciu6Y4A3gMQ1AxHQRkXjOiNe62bzAEFTgQlTSO5tv1aCVEAmJrwdPmoJYN48U7Uxd4JUxBK2fPUi4d7bFB7VpuF3StU44KDvYevFGhFVtyoVtROsSrU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WXIqqhus; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TSiNBzHy; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WXIqqhus"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TSiNBzHy" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67INkYsm2345550 for ; Wed, 19 Aug 2026 01:50:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ty45rSCduvncTI3R+4xQH3a4ms0gZDBpX8wGB7Z8aYQ=; b=WXIqqhus/M8hg0SX p63atbjJrywGVM5wNzBIegXnhZGmD9eCdtIY4XZow1Tr3e052TKxD21rbTehjTWb uerYjWxqcK6gpWOmMItbhAaSi/RHOshWTsIsoe0bdMMfHseN864zRNnZC3h+Y5Qv XVi+A1msJ9KOnfZhWLRzsPmId37suZ/yzfcJi51d36Y+RXmendUFFaCnlOX37/L9 eqQFFAPD4ppJ0bgK453XM44e1+eWVf6j3Y6R1FbH1A08tMFWRQaf29JL3Dk/fEeN PR6+Ih1MPu08VWTw+WgfD7wxAcyWReOeO0aWjAZ3ARk83YTcHAA0KH43nY3SfjV3 tcBOlQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4yfm8s2c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Aug 2026 01:50:45 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-381250979d5so588343a91.0 for ; Tue, 18 Aug 2026 18:50:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787104244; x=1787709044; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ty45rSCduvncTI3R+4xQH3a4ms0gZDBpX8wGB7Z8aYQ=; b=TSiNBzHyzLvqFehZ3HapteCJstPIPJfIHyuqwICmr0/4EdPkb4TxqtA813BGK+Z8eZ hf09urFfaT0dS3Ju87Y4qlNiAj6HZjdsiFCeAVGkGAYAnyIqyZV+axSo6CkJPS7hzuo/ 4SlDf6SYpCSsDElO/Ba46IAy/4jOskgPj8UCp67dydFnXRpX3exLIlSgD9gJhdfV7nPd Nw/Y7IQn7tJzMQzvH+saL94ZawmziYbIRz2/6HJlCqBlM17xXcPWtuZoKaxpxKiqNj79 gRIynXFTTqzMg/TmLpkB16iF5kN2SHsyO39DOqVs5PF5o/PJsln6cygN47ngp8fi4JQ6 WmIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787104244; x=1787709044; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ty45rSCduvncTI3R+4xQH3a4ms0gZDBpX8wGB7Z8aYQ=; b=HLIR8o4RZXO4xC4n1UGQI0Zepl/EnFdPQJiF1gSsQhguB5TalnQbIuGhyWHrWbsgXr Xqy7p5X7Ip8yTSrzJ7TbzjIfrywm76M/68RjPsu1L1+Cr/P9SNq/0+vo/cQqSEQxlALK xyuidqY4nOBd4JtFTAaEgaxDNFqjDS+EQoOSsGL29QIT18eVRERl5Hjcy2spuqLIbbKd Z4lk0f7kYJoI4Bw2SH6Xh23C+yt5xabLuNBjGRBJPUVxBxkoF4W+1NcVMGJalKdh79GB +vl+Nr8xE8Po56rX8jjJLi0TokFx41s63SerapYyhCpbRwkYub5MTOoaSJfpm2T4nMiT WwRA== X-Forwarded-Encrypted: i=1; AHgh+RrqnG+idAhzgLykL1ZIzYLfSB8jbeoVVGK9qsQ0kifviW8ve9R2+MPPTCUl27pPNRjgNx2M1voNl022Fx0=@vger.kernel.org X-Gm-Message-State: AOJu0YwwL5Rm8McngUvxe0ILi5XJMoi9wiE9t0eY15wtW0zqnmMB8OYP /MbGnOmdPyzuYR8tgu+gnlfG3p6v3fIFrM8xWS166xjD6eJOV3I12xa/IkXEJlbQVwLe09bnWXb NTvFXHHtjt+Ha3sHkimr8qjVEJ9z8fdPRZeBnZ0XTfRITL3JnRKPzqQp4fju04YEqkQ0= X-Gm-Gg: AR+sD111ynnpRkfMQxWgrX3QpF26xGMvnmHqmF+bJWpHgYdUDu+kkSRnpfe3fgi7/v2 rBS+9g9meTthVKqjHaH8iL+AnYTtCuoQFCabq+f3e/g9FFQ7OGRiu0G2WL4NV6KZ0vl4nG8EAVi RY8h9Em3HHr9ckXV7Exh2xjwh8vn0lbgYN2Wk7fR0a+uWzZm5zW6F67C02SRLkVwy4lEvsNJ6+a 4UuVcPj8y+dhxeoNgohUtuM7vSvtfA0eyZ/d0iC8TBFIE8b4hhSODhs8xfYQ2YkIXAzGpFbjHZj HnRTO3eaSEsx8QqVYpPPx1mnN4My76Q9k8dSi2IJCXTT5SRNIV/7jh7ID9z8JEp/vnopKmvo78M xP0k48cA9EswA+/1VjsymRw1jWca3cP0vPTzc/agsekYNeinhZ8BtzVXPbgp5t+r+CICILqivIQ == X-Received: by 2002:a17:90b:50c5:b0:366:10f1:3d91 with SMTP id 98e67ed59e1d1-3958125af57mr2184247a91.1.1787104244233; Tue, 18 Aug 2026 18:50:44 -0700 (PDT) X-Received: by 2002:a17:90b:50c5:b0:366:10f1:3d91 with SMTP id 98e67ed59e1d1-3958125af57mr2184144a91.1.1787104243724; Tue, 18 Aug 2026 18:50:43 -0700 (PDT) Received: from [10.133.33.152] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3957fb17f48sm764718a91.2.2026.08.18.18.50.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 18:50:43 -0700 (PDT) Message-ID: Date: Wed, 19 Aug 2026 09:50:39 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next] wifi: ath12k: wmi: Complete regulatory update for dropped events To: Konrad Dybcio , Jeff Johnson , Vasanthakumar Thiagarajan , Aditya Kumar Singh Cc: Jeff Johnson , linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20260818-topic-wifi_reg_fix-v1-1-18c7c289e528@oss.qualcomm.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260818-topic-wifi_reg_fix-v1-1-18c7c289e528@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE5MDAxMSBTYWx0ZWRfX02spCMqNl1Nc Kz5hUk2lpadiZRvD28OeOLhPLwKITNrLjLopfXGZbZq3A1n5Hqd68QOZ1Lr/rY7+tbgGoQ45I8V T1QO6z4hsoFu5sE3DeKo9nBwuvyrvLu+BhXpIr2okRXZbKrWo1hg6MsQWHJbSScsJJCu7P72AUN V/OyhcET1PlDl8kKx5olv1FOvVaDziWr5R/DBR/EitOHB/X0f1UZiBy0jSFwET2VYAbZqaoWyaK sF1kmPZ8KQwZ1tMkUropuXKvlh5KNPrlCvo5c92qDxML4bkaTxHnBCb6fZHkH2fcR4NzquPDBIi 89KowR6CE7PC8kC1rEFI1RFUiXdlBQ+DfqmG3sVmuPSjL4yBShuqsjzdeCLYnsJUDinBDfRdMbT 8wSmEMZZkQUyo56bW4Gv3xtuVwvOXa6ncmf33rT0ZOWO+JIsoJFm2AnWK2LP2Jrqq88X2lwxx1L ClEPRLWl5kJK7XB2Etg== X-Proofpoint-Spam-Info: AW1haW4tMjYwODE5MDAxMSBTYWx0ZWRfX0aX19EOUzCxD zq53xbpJ+9uUuC/PUixeKsGUYE01iooUCiJHRW6IVzRdCT1oaC/AXZTrJ2YfB67vn6usD+Bu+eh ctnZtXmCSVTR9eUYYBE9k/7qSr39h7U= X-Proofpoint-GUID: _8ce0kim_Ddya0RFTMuIT4NsqPKQWDwr X-Proofpoint-ORIG-GUID: _8ce0kim_Ddya0RFTMuIT4NsqPKQWDwr X-Authority-Analysis: v=2.4 cv=J+SaKgnS c=1 sm=1 tr=0 ts=6a850bf5 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=-e__KoK9oonTYIwy9uwA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-18_05,2026-08-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 adultscore=0 clxscore=1015 priorityscore=1501 spamscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608190011 On 8/18/2026 10:57 PM, Konrad Dybcio wrote: > From: Konrad Dybcio > > If ath12k_reg_validate_reg_info() returns STATUS_FALLBACK/DROP (which > are not fatal), the code then jumps to mem_free with pdev_idx still set > to 255, making the following completion never take place. > > That then results in repeating "Timeout while waiting for regulatory > update" messages, as observed e.g. on a Glymur-based ASUS Zenbook A16. > > Fix that by updating the pdev_idx right after the actually-fatal case > of not being able to extract the reg info data is ruled out. > > Fixes: 906619a00967 ("wifi: ath12k: handle regulatory hints during mac registration") > Suggested-by: Baochen Qiang > Signed-off-by: Konrad Dybcio > --- > drivers/net/wireless/ath/ath12k/wmi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c > index d5160af60e00..4ac78ba6c790 100644 > --- a/drivers/net/wireless/ath/ath12k/wmi.c > +++ b/drivers/net/wireless/ath/ath12k/wmi.c > @@ -6975,6 +6975,8 @@ static int ath12k_reg_chan_list_event(struct ath12k_base *ab, struct sk_buff *sk > goto mem_free; > } > > + pdev_idx = reg_info->phy_id; > + > ret = ath12k_reg_validate_reg_info(ab, reg_info); > if (ret == ATH12K_REG_STATUS_FALLBACK) { > ath12k_warn(ab, "failed to validate reg info %d\n", ret); > @@ -6991,7 +6993,6 @@ static int ath12k_reg_chan_list_event(struct ath12k_base *ab, struct sk_buff *sk > } > > /* free old reg_info if it exist */ > - pdev_idx = reg_info->phy_id; > if (ab->reg_info[pdev_idx]) { > ath12k_reg_reset_reg_info(ab->reg_info[pdev_idx]); > kfree(ab->reg_info[pdev_idx]); > > --- > base-commit: e6664f2b33db9b6811eb4cec109f06cb2b4f458d > change-id: 20260818-topic-wifi_reg_fix-a20c9256c5fd > > Best regards, > -- > Konrad Dybcio > there is a similar patch [1] as part of a series [2]: [1] https://lore.kernel.org/all/20260729-ath12k-regd-wait-timeout-v1-1-504aa6e7e93c@oss.qualcomm.com/ [2] https://lore.kernel.org/all/20260729-ath12k-regd-wait-timeout-v1-0-504aa6e7e93c@oss.qualcomm.com/