From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEE27450909 for ; Wed, 19 Aug 2026 10:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136355; cv=none; b=XZ94N3E+1FcA7gXXeoSsH0003uvJ5p8d6vRBkEMmcrazLDZlFbpBbQSUFNvz0cvmtb7NW1Baxa/GL2dNsV2RY7RFQvuHRqMRXXOibgztZTwZ9qOdN5DdroKOCGQQMeYE4aw1lnCtmF5t/pOMUTwZDYdJLp1gfLNxJmQP8zfzCh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136355; c=relaxed/simple; bh=7okmRphLqV8C5vyS3WimCvmgoZ6DsPPFI9j8IvYB7uM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eIvoV5H8BxvgD5TNO4ZcSU2vVywcXS05oMspuJslWt1Jgk98RNaa4ZtaOiJpFqhrpSQ0PxBjFnkU47Y1GF1PUSUMOx21cTQ4HksvIRmpsfDTa+NM5NQ0YlAd1whoycYsC/k/dx4vougEbXWiPsANW5cDQy5qGp8A7e61fg40dxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Co46MBwD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WP0h6+O7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Co46MBwD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WP0h6+O7" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67JA85IV3984229 for ; Wed, 19 Aug 2026 10:45:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7okmRphLqV8C5vyS3WimCvmgoZ6DsPPFI9j8IvYB7uM=; b=Co46MBwDfoTthz9H QUJcEP7G1NtTj/GjNlYPAmkJ4C23VHtndBZeLywQoTUXEJhm1KdLSPcefv5OtiMm kytkQfJjol1dhzLJjl7Vjsjwa4nNTFYH1bZ+EgVK3D3uwBQS0RMnUla2pPXGnSPf rTWIbigDOKCPKlzFPCfC6zFURKvyCHNJK7Hrw8xRz9nFSowDEpNvccqc+NKUuZ0l LVDR2iXxf8Rr9gNa8Cw7qk3tTOeNRQAdpba4GUGqEOIXG39waoPwiEcY0f6R2Iqb c9HhuohQxoqq5hY+zO9zY4dstT4rwIjsie8F0lt7CUrfJQRSjCDPTNsooCpzJvHw zSxYbw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4yfjju44-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Aug 2026 10:45:52 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e661ce1dcso19963285a.0 for ; Wed, 19 Aug 2026 03:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787136352; x=1787741152; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7okmRphLqV8C5vyS3WimCvmgoZ6DsPPFI9j8IvYB7uM=; b=WP0h6+O7Ja6vL0jj3f44DmPt0JNRCRwcVgTm9AJizilDwt9fA7sg93iy9XWzXS2YI+ lvIjhvc+7r8XtBnWu7qRb9VvPG5svDiG70LdDxbVdW8qYvHOeBCDT2RUy8JgchlHvsLg 4bo64pEv72viYkUZqaCP0MLM2V2AvFEIvNPMmm6TR0gjgLJ906EYzyNlzqOmWzSW3bR5 Y3WuGqYlN6MeebJ9Xu8ATE6avCqihJhTMpPAaSrzBufNAQZjhy7h1kOaG/O1LXgrnazF PXSv1JJXrOizAnGKfT1TyT7HjJag0aGnwPc7ZQG2J1bT9Pow1rrmlu5otFqXrD7NhYLG i1RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787136352; x=1787741152; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7okmRphLqV8C5vyS3WimCvmgoZ6DsPPFI9j8IvYB7uM=; b=a6aajAPRp/sCcdR9d53UXUAbgbJJz+unS+iQ6GEPtYjvNC2LWc4gQJB8KDL0VMkXhP rbUxJN5A4LuwBSgrJMhhe31bLW667fFl3Awpta+5AqINgJOm+QwtwR7jJuhzN+U2bo3i aXLPWybRrNZVYN6VFuWwmCW0xP+KxRocsDoQ4KJii6r0qwaK+cGWu+RaOH+sC5o8tnpY ieqtvIYtd3f75ZtPNfFGAdemcEKiCR74yjCs374xmFyoGARaHdL42nPXu1J7+rfp6E9/ TAWUxw0B17Rawmw7LK+5avf8ICXSWBT+hRuNNYIZRrZsg5ZYytP9F/82HLADB3JQDi6V Ro3A== X-Forwarded-Encrypted: i=1; AHgh+RrxHiCFTxM5vbCVoK8HVqlk3u8ad+L2Rt9pdf7I5cQeHHTqefvpVexiAaOkxpKsf/YgdtSilP6TezrxYIY=@vger.kernel.org X-Gm-Message-State: AOJu0YwxyxJRY9HZMF1KMpe/54tpa5tnaAyUdXlODFpbHxkIwfsX6aSG o8sWmBbNIATLtTobIv2/yeJWhyKEZ54Fq5bQN8wIh+hKdD3iu/E6FjZsvry6Lpw59SdcRy63W5v QjT3jLq7ilgGAOCVEO6S6LbF87SfltHLg4tZ5gZSjLqTUNOgnXqH2wPpBkn29NtAqd7A= X-Gm-Gg: AR+sD11VVjeulUhfRBUI7a/yTQTrTpq9e7TLIQXnm2dmwbaXiV3exW1C8I4ZUKb0ej/ 9lPtrTwyNeadqxqROV2Y/pcFnayNu30UoB/C9tc8HTNGP+yYZQ+nyvKpdpk6EUj+u0kXguVUKE1 p5ajReIqU+mjW/dhkh++kEzBBcgpKq8Vj2N99Dn1e89YtSV+dEEYAMNXLaspAODZ2X8ZW77c7Oe KW+rt7eTU8plZ27R4n/OXvaBzn6r3aipusl1DUyC2sYppBaYqzhRdUg+hZG7tHINgAr5EOxJ4FG blBBRlyoirFBTQerNfuD0VGBPq8tCVG4Ge/qLqeJo2djoXkvlZ8wOjrFj5iqZu1b9pcwFK67Nl/ ElYm9/3NPCCoC9PtJoUDTWL6g X-Received: by 2002:a05:620a:4614:b0:92e:6485:f640 with SMTP id af79cd13be357-9371e7024camr222457985a.4.1787136352002; Wed, 19 Aug 2026 03:45:52 -0700 (PDT) X-Received: by 2002:a05:620a:4614:b0:92e:6485:f640 with SMTP id af79cd13be357-9371e7024camr222455785a.4.1787136351495; Wed, 19 Aug 2026 03:45:51 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3feec9f4asm749470a12.3.2026.08.19.03.45.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Aug 2026 03:45:50 -0700 (PDT) Message-ID: Date: Wed, 19 Aug 2026 12:45:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: qcom: Add register dump support for PCIe Link Down events To: Krishna Chaitanya Chundru , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260811-regdump-v1-1-f22db3fb37c2@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260811-regdump-v1-1-f22db3fb37c2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE5MDA4MiBTYWx0ZWRfX+96nuJLLavd4 vdXokvEACq7mekbv5wdHXjOtfwn9AiY8k6SRaIh8BxL9z9+QEMET5J/Dfo66+Wu+YAdgzVEq3Eb C78/FMpnBMwfLuEZLNnNgHbHOO9W8/7qbVuxyHu4ougucUIRvXhPqNIgzedSKlZX1h/mzBzOK2p wd6atHLJdazNNEzvxwCvisEesQ9tEXypUu+W3/6v/qkrwBfNFbVFu10TKBvK3ZUCyhdjnRRFOcJ ylVcGUZA6K9ffDKyOUbl7X0lmeues0Eg5QVXuCfsBygrsDgafOZsDhDoe2hjFX678bVLcRmphye pep4YjttD80ZAzJEmFBvfwqAx8I5R0oUgwFo/8O+20g7yDvsnH8fTpMU3ohhY7JGP4x5/emL/wW B6Q/soqIlDdiIVDo0hMbWuVBh3t0gIqvT9tN0TNaWjD7b5ZjobeQ5qFrhiguCvUDeAVQWWCUHy3 TTM1Towz8WSJtnQtiZQ== X-Proofpoint-GUID: F0e02x2PJcS8Ne1O_9JxBxA04VlFn0um X-Proofpoint-ORIG-GUID: F0e02x2PJcS8Ne1O_9JxBxA04VlFn0um X-Proofpoint-Spam-Info: AW1haW4tMjYwODE5MDA4MiBTYWx0ZWRfXzO6N5ksdxHnV Z/dY0WPdc3WosIwIT/N/ZidRmdSQ5YY+avJqPwlFt2QYCVVVeG05gzno0sVcOOeSYeha/B+MiRJ i+N7tvEv5we/JVij59sbwmqg0MbVgrY= X-Authority-Analysis: v=2.4 cv=Sb7HsPRu c=1 sm=1 tr=0 ts=6a858960 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=6SV30oLp8BWL7HE82y8A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_03,2026-08-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 bulkscore=0 impostorscore=0 adultscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608190082 On 8/11/26 6:12 PM, Krishna Chaitanya Chundru wrote: > When the PCIe link goes down unexpectedly, being able to inspect the > state of key controller registers at the time of failure is valuable > for root-causing the issue. In this current form, does this patch not cause the splats to appear for non-fatal linkdowns (e.g. hot-unplug)? > If a storage endpoint is present downstream, the dump is printed > directly via dev_err() so it is visible in dmesg immediately, since a > devcoredump read from userspace could otherwise race with a storage > failure. Otherwise, the buffer is handed to the devcoredump framework > so it can be collected from /sys/class/devcoredump/ for offline > analysis. I think this is a bit too much, a single implementation is enough. Konrad