From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754655AbdBQAxi (ORCPT ); Thu, 16 Feb 2017 19:53:38 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:35056 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753869AbdBQAxg (ORCPT ); Thu, 16 Feb 2017 19:53:36 -0500 Subject: Re: [PATCH 0/2] efi: Enhance capsule loader to support signed Quark images To: "Kweh, Hock Leong" , Jan Kiszka , Andy Shevchenko References: <1bf3c9d8-56aa-818b-350f-deb62ad14e08@siemens.com> <4014c5e6-b5a0-7552-166f-a42992532c09@siemens.com> Cc: Matt Fleming , Ard Biesheuvel , "linux-efi@vger.kernel.org" , Linux Kernel Mailing List , Borislav Petkov From: "Bryan O'Donoghue" Message-ID: Date: Fri, 17 Feb 2017 00:53:46 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/02/17 03:00, Kweh, Hock Leong wrote: >> -----Original Message----- >> From: Jan Kiszka [mailto:jan.kiszka@siemens.com] >> Sent: Thursday, February 16, 2017 3:00 AM >> To: Andy Shevchenko >> Cc: Matt Fleming ; Ard Biesheuvel >> ; linux-efi@vger.kernel.org; Linux Kernel Mailing >> List ; Borislav Petkov ; Kweh, >> Hock Leong ; Bryan O'Donoghue >> >> Subject: Re: [PATCH 0/2] efi: Enhance capsule loader to support signed Quark >> images >> >> On 2017-02-15 19:50, Jan Kiszka wrote: >>> On 2017-02-15 19:46, Andy Shevchenko wrote: >>>> On Wed, Feb 15, 2017 at 8:14 PM, Jan Kiszka >> wrote: >>>>> See patch 2 for the background. >>>>> >>>>> Series has been tested on the Galileo Gen2, to exclude regressions, >>>>> with a firmware.cap without security header and the SIMATIC IOT2040 >>>>> which requires the header because of its mandatory secure boot. >>>> >>>> Briefly looking to the code it looks like a real hack. >>>> Sorry, but it would be carefully (re-)designed. >>> >>> The interface that the firmware provides us? That should have been >>> done differently, I agree, but I'm not too much into those firmware >>> details, specifically when it comes to signatures. >>> >>> The Linux code was designed around that suboptimal situation. If there >>> are better ideas, I'm all ears. >>> >> >> Expanding CC's as requested by Andy. >> >> Jan >> > > Hi Jan, > > While I upstreaming the capsule loader patches, I did work with maintainer > Matt and look into this security header created for Quark. Eventually both > of us agreed that this will not be upstream to mainline as it is really a Quark > specific implementation. What's the logic of that ? It should be possible to provide a hook (or a custom function). > > The proper implementation may require to work with UEFI community > to expand its capsule spec to support signed binary. Are you volunteering to do that with - getting the CSH into the UEFI spec ? If not then we should have a method to load/ignore a capsule including the CSH, if so then we should have a realistic timeline laid out for getting that spec work done. Hint: I don't believe integrating the CSH into the UEFI standard will happen... > > > Regards, > Wilson >