From: Valentin Schneider <valentin.schneider@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Dietmar Eggemann <Dietmar.Eggemann@arm.com>,
Tejun Heo <tj@kernel.org>,
Patrick Bellasi <patrick.bellasi@matbug.net>,
Suren Baghdasaryan <surenb@google.com>,
Quentin Perret <qperret@google.com>,
Qais Yousef <qais.yousef@arm.com>
Subject: Re: [PATCH v2] sched/uclamp: Fix overzealous type replacement
Date: Fri, 15 Nov 2019 14:29:44 +0000 [thread overview]
Message-ID: <f4fcc45e-7609-3836-162a-0a1839134bcf@arm.com> (raw)
In-Reply-To: <CAKfTPtBoi_5sUiGrTpYuV_u2vPkBK+caUzgaKxY3Ck3PKJXZiw@mail.gmail.com>
On 15/11/2019 14:07, Vincent Guittot wrote:
>> -static inline enum uclamp_id uclamp_none(enum uclamp_id clamp_id)
>> +static inline unsigned int uclamp_none(enum uclamp_id clamp_id)
>
> Out of curiosity why uclamp decided to use unsigned int to manipulate
> utilization instead of unsigned long which is the type of util_avg ?
>
I didn't stare at the discussion much, but I think it stems from the
design choices behind struct uclamp_se: everything is crammed in an unsigned
int bitfield. Let me see if I can find some relevant mails.
next prev parent reply other threads:[~2019-11-15 14:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 10:39 Valentin Schneider
2019-11-15 14:07 ` Vincent Guittot
2019-11-15 14:29 ` Valentin Schneider [this message]
2019-11-15 17:10 ` Valentin Schneider
2019-11-15 17:34 ` Vincent Guittot
2019-11-15 20:21 ` Peter Zijlstra
2019-11-15 17:38 ` Vincent Guittot
2019-11-17 9:50 ` [tip: sched/core] " tip-bot2 for Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4fcc45e-7609-3836-162a-0a1839134bcf@arm.com \
--to=valentin.schneider@arm.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=qperret@google.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®