From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752776AbdJKQhz (ORCPT ); Wed, 11 Oct 2017 12:37:55 -0400 Received: from esa7.dell-outbound.iphmx.com ([68.232.153.96]:12934 "EHLO esa7.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751961AbdJKQhx (ORCPT ); Wed, 11 Oct 2017 12:37:53 -0400 From: X-LoopCount0: from 10.166.132.195 X-IronPort-AV: E=Sophos;i="5.43,362,1503378000"; d="scan'208";a="1163692623" X-DLP: DLP_GlobalPCIDSS To: CC: , , , , , , , , , Subject: RE: [PATCH v7 04/15] platform/x86: dell-wmi: allow 32k return size in the descriptor Thread-Topic: [PATCH v7 04/15] platform/x86: dell-wmi: allow 32k return size in the descriptor Thread-Index: AQHTQq7fS3kv1qmS+Eme5zt0K0zBIaLe2NkA Date: Wed, 11 Oct 2017 16:37:44 +0000 Message-ID: References: <20171011163159.zhott3wh4fx6c76r@pali> In-Reply-To: <20171011163159.zhott3wh4fx6c76r@pali> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9BGc1Xv024965 > -----Original Message----- > From: Pali Rohár [mailto:pali.rohar@gmail.com] > Sent: Wednesday, October 11, 2017 11:32 AM > To: Limonciello, Mario > Cc: dvhart@infradead.org; Andy Shevchenko ; > LKML ; platform-driver-x86@vger.kernel.org; > Andy Lutomirski ; quasisec@google.com; rjw@rjwysocki.net; > mjg59@google.com; hch@lst.de; Greg KH > Subject: Re: [PATCH v7 04/15] platform/x86: dell-wmi: allow 32k return size in the > descriptor > > On Wednesday 11 October 2017 11:27:30 Mario Limonciello wrote: > > Some platforms this year will be adopting 32k WMI buffer, so don't > > complain when encountering those. > > > > Signed-off-by: Mario Limonciello > > --- > > drivers/platform/x86/dell-wmi.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c > > index ece2fe341f01..c8c7f4f9326c 100644 > > --- a/drivers/platform/x86/dell-wmi.c > > +++ b/drivers/platform/x86/dell-wmi.c > > @@ -624,7 +624,7 @@ static void dell_wmi_input_destroy(struct wmi_device > *wdev) > > * Vendor Signature 0 4 "DELL" > > * Object Signature 4 4 " WMI" > > * WMI Interface Version 8 4 > > - * WMI buffer length 12 4 4096 > > + * WMI buffer length 12 4 4096 or 32768 > > */ > > static int dell_wmi_check_descriptor_buffer(struct wmi_device *wdev) > > { > > @@ -674,7 +674,7 @@ static int dell_wmi_check_descriptor_buffer(struct > wmi_device *wdev) > > dev_warn(&wdev->dev, "Dell descriptor buffer has unknown > version (%u)\n", > > buffer[2]); > > > > - if (buffer[3] != 4096) > > + if (desc_buffer[3] != 4096 && desc_buffer[3] != 32768) > > Looks like that desc_buffer is not declared. Yep thanks for catching that was a mistake from all the rebasing and not compile testing this particular commit. ☹