mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Johan Hovold <johan@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Vaibhav Hiremath <hvaibhav.linux@gmail.com>,
	Alex Elder <elder@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: greybus: arche: drop dangling Kconfig symbol
Date: Wed, 14 Jan 2026 16:28:33 -0800	[thread overview]
Message-ID: <f51a80c9-bc87-442e-b2e5-0e688a4cedd1@infradead.org> (raw)
In-Reply-To: <aWdgCblk91iJE4T2@hovoldconsulting.com>

Hi,

On 1/14/26 1:21 AM, Johan Hovold wrote:
> On Mon, Dec 29, 2025 at 10:27:04PM -0800, Randy Dunlap wrote:
>> The Kconfig symbol USB_HSIC_USB3613 is not defined in the kernel source
>> tree. Drop it since it unused.
>>
>> Fixes: 2eccd4aa19fc ("staging: greybus: enable compile testing of arche driver")
> 
> As the commit message of that commit says this was done on purpose to
> allow the driver to be compile tested without the out-of-tree driver
> that never went upstream.
> 
> These days we have a USB hub driver that should probably be used
> instead, but yeah, someone would need to do the rework.

We?
Do you mean drivers/usb/core/hub.c?

> And while referencing the commit is good, I'm not sure a Fixes tag is
> warranted.
> 
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>  
>> --- linux-next-20251219.orig/drivers/staging/greybus/arche-platform.c
>> +++ linux-next-20251219/drivers/staging/greybus/arche-platform.c
>> @@ -23,14 +23,10 @@
>>  #include <linux/of.h>
>>  #include "arche_platform.h"
>>  
>> -#if IS_ENABLED(CONFIG_USB_HSIC_USB3613)
>> -#include <linux/usb/usb3613.h>
>> -#else
>>  static inline int usb3613_hub_mode_ctrl(bool unused)
>>  {
>>  	return 0;
>>  }
>> -#endif
>>  
>>  #define WD_COLDBOOT_PULSE_WIDTH_MS	30
>>  
>> --- linux-next-20251219.orig/drivers/staging/greybus/Kconfig
>> +++ linux-next-20251219/drivers/staging/greybus/Kconfig
>> @@ -206,7 +206,6 @@ endif	# GREYBUS_BRIDGED_PHY
>>  
>>  config GREYBUS_ARCHE
>>  	tristate "Greybus Arche Platform driver"
>> -	depends on USB_HSIC_USB3613 || COMPILE_TEST
>>  	help
>>  	  Select this option if you have an Arche device.
> 
> The above just seems to hide the fact that the driver currently cannot
> be used.
> 
> Can you please at least add some kind of TODO comment to indicate that
> the driver should be reworked to drop the dependency on the OOT driver?

Sure, I can add that, but I think it needs more info. Reworked how?
What should the usb3613_hub_mode_ctrl() function do?

> And it's probably best to keep the depends on COMPILE_TEST until that

ack

> has been resolved. Perhaps also wrap usb3613_hub_mode_ctrl() in
> 
> 	#ifdef CONFIG_COMPILE_TEST
> 	...
> 	#endif

Don't think so. The driver calls usb3613_hub_mod_ctrl() in 4 places,
so it needs to be there.

-- 
~Randy


  reply	other threads:[~2026-01-15  0:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-30  6:27 Randy Dunlap
2025-12-30 18:23 ` Randy Dunlap
2026-01-05 10:09   ` Dan Carpenter
2026-01-05 10:16     ` Dan Carpenter
2026-01-05 23:54       ` Randy Dunlap
2026-01-06  3:16     ` Randy Dunlap
2026-01-14  9:21 ` Johan Hovold
2026-01-15  0:28   ` Randy Dunlap [this message]
2026-01-16 10:48     ` Johan Hovold
2026-01-17  5:40       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f51a80c9-bc87-442e-b2e5-0e688a4cedd1@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=hvaibhav.linux@gmail.com \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®