From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B2F2C04AAF for ; Thu, 9 May 2019 04:43:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F0D492173C for ; Thu, 9 May 2019 04:43:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KzejU6z/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726687AbfEIEnz (ORCPT ); Thu, 9 May 2019 00:43:55 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:43556 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbfEIEnz (ORCPT ); Thu, 9 May 2019 00:43:55 -0400 Received: by mail-pf1-f196.google.com with SMTP id c6so605208pfa.10 for ; Wed, 08 May 2019 21:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=scFbWph7JHrKM6HxwUqzW/4Hy+E4AbiQZE3dZlFlEXQ=; b=KzejU6z/bMnWbc4nTdChjaRy5hh/WkrH8R6FLw32mOfxhbSvUqWnkCHjxUVy7RbBrx hUZwVYLtDDDoGsHz3299ofeiq5Ye9ZhdH3f0s14WawZJNoFWVGvXHyTG6TZqEG15Dnhr HFOzYnEIFPqIghh+tpcz8SXSm/gIL1vGazQCH9DxNc2Egq3TQLwgR0MGq5IJJHHt42Xb FL/DUn781vh/zbOVkZm7EQnitpPO3liEZcqsB6ok8pMZQl46ktUrA/m3820B5gFTVczC G2omrG+8ljOkvM/JjVzBTxJ8mdJ2E0AJZHEcvYohaIWZxFerjgyS7ozOwjOYFEAPrtGx qjSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=scFbWph7JHrKM6HxwUqzW/4Hy+E4AbiQZE3dZlFlEXQ=; b=F2UeaiG5YGOHtVSdFYo1mJ+HljMiG+FO5YonzBSYW5ZE+xeqgu8BFnrGdHbj0DVqD3 M8/bk+IaqdITXk9kS2xBpAi/VuPQoRIwiPbrpI+16PPY0WbeqzlS53Mu/oTTJmxO8psA omyg5cGe2gNIlssE31uxxznCP8dPqTPMlwb+19aZolQFT70YoJluzJw32W4ZE5kuCLsT m+JQTVczqYh4VRffb2aYEkVonVfMBQfC4pZnidE/D+Trd9CDOk/sLGLeFMp3LxujJCd8 io2T/Cvf1Q7Tm6mEZOtd17EjXoVIHY0TXcTYCCbR4a8M3VwNBXpVSfFcIdc5rvvjzWH5 Q/Hw== X-Gm-Message-State: APjAAAWzd3oVdZh/9b/i1IBh1H30kts7QF2yKuzSMHgmAhDoRcJhO7wC /Khj3x2mduZ1leCuOAN2zLNsjw== X-Google-Smtp-Source: APXvYqzV+0CkkiDLf+k1unw85tkvpSJ+MfJTPDGU0ZVjs6Y/iHv0OKTrQElaAp497FA00+KeSVZtjQ== X-Received: by 2002:a63:d345:: with SMTP id u5mr2699553pgi.83.1557377034409; Wed, 08 May 2019 21:43:54 -0700 (PDT) Received: from localhost ([122.172.118.99]) by smtp.gmail.com with ESMTPSA id c137sm1254639pfb.154.2019.05.08.21.43.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 May 2019 21:43:52 -0700 (PDT) From: Viresh Kumar To: Wolfram Sang Cc: Viresh Kumar , Vincent Guittot , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] i2c: sh_mobile: Fix compilation warning Date: Thu, 9 May 2019 10:13:46 +0530 Message-Id: X-Mailer: git-send-email 2.21.0.rc0.269.g1a574e7a288b MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This currently generates a warning: drivers/i2c/busses/i2c-sh_mobile.c: In function 'sh_mobile_i2c_isr': drivers/i2c/busses/i2c-sh_mobile.c:399:26: warning: 'data' may be used uninitialized in this function [-Wmaybe-uninitialized] Though the code looks okay and shouldn't ever use the variable uninitialized. Fix the warning by moving the code around and getting rid of 'data'. Compile tested only. Signed-off-by: Viresh Kumar --- drivers/i2c/busses/i2c-sh_mobile.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c index 8777af4c695e..945eb8504fb7 100644 --- a/drivers/i2c/busses/i2c-sh_mobile.c +++ b/drivers/i2c/busses/i2c-sh_mobile.c @@ -369,7 +369,6 @@ static int sh_mobile_i2c_isr_tx(struct sh_mobile_i2c_data *pd) static int sh_mobile_i2c_isr_rx(struct sh_mobile_i2c_data *pd) { - unsigned char data; int real_pos; /* switch from TX (address) to RX (data) adds two interrupts */ @@ -390,13 +389,11 @@ static int sh_mobile_i2c_isr_rx(struct sh_mobile_i2c_data *pd) if (real_pos < 0) i2c_op(pd, OP_RX_STOP); else - data = i2c_op(pd, OP_RX_STOP_DATA); + pd->msg->buf[real_pos] = i2c_op(pd, OP_RX_STOP_DATA); } else if (real_pos >= 0) { - data = i2c_op(pd, OP_RX); + pd->msg->buf[real_pos] = i2c_op(pd, OP_RX); } - if (real_pos >= 0) - pd->msg->buf[real_pos] = data; done: pd->pos++; return pd->pos == (pd->msg->len + 2); -- 2.21.0.rc0.269.g1a574e7a288b