From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752828AbdLYReu (ORCPT ); Mon, 25 Dec 2017 12:34:50 -0500 Received: from mout.web.de ([217.72.192.78]:64416 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbdLYReq (ORCPT ); Mon, 25 Dec 2017 12:34:46 -0500 To: linux-gpio@vger.kernel.org, James Hogan , Linus Walleij Cc: LKML , kernel-janitors@vger.kernel.org, Grant Likely , Rob Landley From: SF Markus Elfring Subject: [PATCH] pinctrl: tz1090-pdc: Delete an error message for a failed memory allocation in two functions Message-ID: Date: Mon, 25 Dec 2017 18:34:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:LJXAx73532u3Dh9bagHI86QNZ8pTfKlMy7lz3QHA5YyW0kL4qlx EMMVc52OMACgDwHFA9P6x5VgPjT6HlgA8buGHFdvF+QMncdV5xyM/h8e5PU+rV3GoGfNGpd Ir9XO7icBGQF/lzhdnuqHb5wKLjnFxDonn9udjqK0dmsDbtv7/mi93IArXU/QssRMd+qVxU 5kd+s4/WlIB7NCACvfxtA== X-UI-Out-Filterresults: notjunk:1;V01:K0:BEvv+H7PFIk=:hSC8tpqjRvrGFD2hi5zZ0l 1Mc3iXCtbRylhjl5F9qOgVmE6WYTMH4nw321CoKBHqcf1fD9h/zihHXPZHV/RKcV6jIpCjJZU VgMk9cL9fGjDhi3t+2L8u4TW68ZuaoBDI4BRbdyyVzKEJoDBaJxMNTzGZtMwQay9ybkwogYIo UPIFweWqE3VnpHg03Kfv51wJ6zEk5G9qDv1hJ/dZJdQqV1wqt8ptXeyl+bB8ymsEsK8cZtvvp P/6EFj3wNPmdJvPKBgwF0MleRsryRAn22nY29fQCDKYd3i7QM/Wurcvv5cBUir7TLBmJV08es bI4KchQxMbe7OpuvYYd2UwmSOfQzrDo8xs8FSSWPzB9q+u+MdAiO2CBMqIm0Any2JpcttD+Gy QH+YoxzyGfXjOezxDZqKcd4o0Vv2Ey5zB2QJ0ZaVfzNYJWfM5D3dBAiPX4ATGtfRHqO5NEeAe 0aAlK3H/NWGylZtc7jZ4y29y1BdpsQ3ud7P4P0FQ+UXaVJsWf/uCMeUimKUeJFW9Dut5juNSZ KrJoZox0UKdZM6v6FVgffZHvRUvpoV8pZhHxs4oZZb/QRzOawTOUfzEMqCbsOVuFG8k6Zh/fY qPhc3JV57n2GqoemEB8btiVk2IRE1dsMmCneVN56B87iLTOSr9y/zis39nxoEmE6Te50hzH0M BBLyUZtZtqTrjh3h2axNXvEXGx8FvSr05aa0QnRC0kWjXYvgd5+EI8sikJdtjQYPaEempK+Wa FKbCgltzz8lmV7L491WiyY+pHNv0ToZ0MXv1uBGErLp09ZbX/BCAJlUU+29Ja5jZEIqWrdwHA tScG3sUkYklHRiijWoUFsHUgtc0DZvtDFgPHVe5MFQbWVFBFIQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 25 Dec 2017 18:28:02 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pinctrl/pinctrl-tz1090-pdc.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-tz1090-pdc.c b/drivers/pinctrl/pinctrl-tz1090-pdc.c index 5cfa93cecf73..b16d1c96b7eb 100644 --- a/drivers/pinctrl/pinctrl-tz1090-pdc.c +++ b/drivers/pinctrl/pinctrl-tz1090-pdc.c @@ -357,10 +357,8 @@ static int add_map_configs(struct device *dev, dup_configs = kmemdup(configs, num_configs * sizeof(*dup_configs), GFP_KERNEL); - if (!dup_configs) { - dev_err(dev, "kmemdup(configs) failed\n"); + if (!dup_configs) return -ENOMEM; - } /* * We support both pins and pin groups, but we need to figure out which @@ -931,10 +929,9 @@ static int tz1090_pdc_pinctrl_probe(struct platform_device *pdev) struct resource *res; pmx = devm_kzalloc(&pdev->dev, sizeof(*pmx), GFP_KERNEL); - if (!pmx) { - dev_err(&pdev->dev, "Can't alloc tz1090_pdc_pmx\n"); + if (!pmx) return -ENOMEM; - } + pmx->dev = &pdev->dev; spin_lock_init(&pmx->lock); -- 2.15.1