From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B883B470426 for ; Wed, 12 Aug 2026 18:21:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786558904; cv=none; b=ELwUq6YXq/7t78SmKLHxHz60kNZUCS8gNw1fiJB+UTLY6CO/3mU3Qq+UdbTSrQVAvXQDNPB/iaPe5yAKy/TTx9F02rJTV+WApYdo01UAxtCBPJDpsLvKOBrBKURGV7N+0nmZvjffCxqv9oXojFL0jPmOpUhPUEgRuVTlzcKSnII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786558904; c=relaxed/simple; bh=iI9esAdOdZlw1uReZnabVvg5nHlPrIbNW3n2cPWAZXU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qwVTUzcrqXz7FeZWEoBJzyE7ofqjlwscnNdpduezC/kz/hRxfyvhtGOI+YzM7rakEXCztdcRlBbf9VnuKTm/Gp3FrAWv8ke4t1cEYxcSTyLKdbgan1dIl8EDEbD3GldFiTgCNR7zjBlJ3FDsNqJchKwFJi+cyt5hO0dKstE2hQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=of6jBEj/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Rc77VqAo; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="of6jBEj/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Rc77VqAo" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CI8s2k382594 for ; Wed, 12 Aug 2026 18:21:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +LND2pBW8ZOPxUjxOrCRIPueAW7jiZZxzW3Hs+XmLEY=; b=of6jBEj/9M//BZJv iVVG9dOOSLGlZULaKtZu0wDId03BF9r/zDUQDjPU0yacJeWSr4m1MjxBpf0zgvHU s1ixF4rQaJ5thA/ZczSKcH7qXXLK74I+Qb4QHMtH3T9uDVNGbjsGyc0CJExdvQWz KVFDunHCFva+URsqsOAUQCJYHQxjzoNxwvqH/7uBzynDWZyUG6K3DtQfMO7hUjpi ENn7ZevD6ZZYrFFT4pCSS5ve9Y+xQxQTYNx4PzJ/BmNjdXLtjncCEGKiJPPrwgKd 79PYfb5pihBzA/VsJVHoSx80+OZDDl+vtgPtJe208Bdem0VyvBCyU1MyqTB3J/BC pVNXlw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0jgrkb3t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 18:21:41 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cccfa32670so17435375ad.2 for ; Wed, 12 Aug 2026 11:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786558901; x=1787163701; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+LND2pBW8ZOPxUjxOrCRIPueAW7jiZZxzW3Hs+XmLEY=; b=Rc77VqAorG8Na0nuVZvXE/K8IpAUNtH2xCod4xoiVaGdtO+epRri2GVlZK22V/L/vK 2g20v/9xuccMOuyeQyZzGRNelppinr7Fo9aCw7rkzZh0kFtqjeS8ZMfbI3GF7lKqs2cK B+IkrGyk3NCSBX30ESy9xLmeBArJz1SpYJrnJtDEvALy0ao4e8Dxbqwyt5GUeBcqKxJN lASnG6fA9CPsZbDDlTusZip8uaEOq/4z8t7yUmpgSiV26ouG0UK/gfEpjvy0utL1riP6 uxQldGSwRYZQrRINpbYU2PQWt6+netLMXrEoCyfmsXMMMKmKU6oxB7MSdl5T9HNKF3IV 6igg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786558901; x=1787163701; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+LND2pBW8ZOPxUjxOrCRIPueAW7jiZZxzW3Hs+XmLEY=; b=SRHi+bZ9UmCkpxIZPOcwfm2jTgSHPPBQg1hCmgjPwJtdJRsC8GZdi4vjrBILsz59JY DzsCxCAiJ4Bp4Eul2PQDC9902S9+3q9r34OhF21HjFiqg8AQEAQt8TopXy/eXsO/YBHA zA3+WMKdlIMx4opLQVZw1+7rMYq3ebdtp57nWWaqbLounznWwssKhgPr60rjpH1sh2Q7 s5sA0pt9kym2C1dFU+J1RM9ov4j+COlHITzjCsxR9qcP2aTvb+K6sdrK9xdI3XNQLBrc DvTXlFzJWpiTC3qs5EW1cTKeNzErIkfhhw9vZKC0iQwK4LiUHKCrf7bDHaoQM0wowOCI 3Pfg== X-Forwarded-Encrypted: i=1; AHgh+RpL8tsx1jKxIZCFEhtjhr3Ah7B2u8jIyTK8ZpCm9Jrxujv4K3EeVaQRz6/au/7vq4XvM6D4dpfg7Vvvx2g=@vger.kernel.org X-Gm-Message-State: AOJu0YxrdTVlDHUf8WJWoceFpra3rAPJfk6XtWRMlZZhNoJIn0341S7p 8JhWKPjPAMFV+62Bfru22DWRSRsT3LU8pg9NdZRhoEIsU6lcqsJYvU4Vp3CBSrGAtMre9mLCGwf asCC77ncoee77K4TEfuM9Q37HafqkqS0P+6lqINrP/ckhPItKhQenXVmu9sjTn3jz48s= X-Gm-Gg: AR+sD10t8ROZosqvsT+3eHMirf4nm3I6cffqUgH1Xna5RjbX0NaGsKoJAonYs+O1qhU D5pP6jP2Bvt1BALXHUdHIrHv8R92tg8/BQ6VvM5OAYFIs2ycaFBoAb1iyb/QcO3uOLB8DELmRpm Dg+ZMrPtUFxi2IN/1RNHNmtJh2+Q21SXKqFtdpXSNLqgzwWi6ieLVgajsUl3J+FkS50Kuggmqjo TY6r9YZGkSgiDHxBh0QxCcOTi2Qzg9eAL/g4qfwo7l95TPJa+UUrOfaPtAPN2P0PC2W6ZKntpKd OKW+tfGnrU39R1d3q8nArT2x9Ox+FJ03okYMT6b+5APQTfwlmV/VVQyXzDD2jDfKnNkdH1iVPYI hjyZtgzMH7RvZWdLelWQlhKEM+BCMNSVcrA== X-Received: by 2002:a17:903:40d1:b0:2c7:ebfb:618f with SMTP id d9443c01a7336-2d34556662bmr88759455ad.14.1786558900424; Wed, 12 Aug 2026 11:21:40 -0700 (PDT) X-Received: by 2002:a17:903:40d1:b0:2c7:ebfb:618f with SMTP id d9443c01a7336-2d34556662bmr88758575ad.14.1786558899929; Wed, 12 Aug 2026 11:21:39 -0700 (PDT) Received: from [192.168.1.15] ([106.222.235.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d37c24a371sm537155ad.28.2026.08.12.11.21.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Aug 2026 11:21:39 -0700 (PDT) Message-ID: Date: Wed, 12 Aug 2026 23:51:34 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] dt-bindings: i2c: Add Qualcomm I2C target controller To: Krzysztof Kozlowski Cc: Mukesh Kumar Savaliya , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260802-i2c-qcom-slave-v2-0-27653118fa75@oss.qualcomm.com> <20260802-i2c-qcom-slave-v2-1-27653118fa75@oss.qualcomm.com> <20260804-airborne-impala-of-proficiency-a9a8d9@quoll> Content-Language: en-US From: Viken Dadhaniya In-Reply-To: <20260804-airborne-impala-of-proficiency-a9a8d9@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDE0NyBTYWx0ZWRfX7sY/DNn7ET8i 2PJa0RznHGa2SGSaCKylKD2vNqrnoZqLlhyvt82jGG7uL1EV+TZWlnZukvNbJ6f5LVFN5Ex/3TR BCkgElcfhQqTonT2ChpmMB9FhMyNc0t+Qu3POOLFHsCx82mebcH/RWye36NJQYHrCKHYLTj3OB0 q6owD5/YH8mQT2LS/RC5zPJAkppAiFEpNKcXd03FW4GZ8oIJxJ3YU7L5VdnJazDtgiSD7hkd6FS ZBCKZq9Boh6mdwRfEKDZpNrvcAxxoCD84Iq1q627ViWgbgFHb37n4S1/sa10kVuBkZD1dxj2Ra0 LHwWbf3ywmbnnH6IuklBPzkkjDsrSElLefz50kKXPefGhgj35GzyC3bptLsg1dGgP8PDVyPd+tc RbEw82IGfO0lgdriyO2M7h/imaR686v5iFODn04/mNG4SSRem4E4S0ayWfJahYsb+mriXBqTv6A X8skCYnjQ/cSm0OKYGA== X-Proofpoint-ORIG-GUID: lYGtdnQ48gLePZfOK6uQwaRogd_1Mqlg X-Authority-Analysis: v=2.4 cv=TNJ1jVla c=1 sm=1 tr=0 ts=6a7cb9b5 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=NH2SoAXOXKK5768fTBPIkg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=gEfo2CItAAAA:8 a=EUspDBNiAAAA:8 a=RP_QtRrjLn2U0etmI9oA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-GUID: lYGtdnQ48gLePZfOK6uQwaRogd_1Mqlg X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDE0NyBTYWx0ZWRfX0JWmuCmmhskd e7lHwyAfcPjB6vBiVsFxJdH90FxQ4tsW3Px5zAXFk4gVPFI4VTXwtfOvjauFizNy6hF2D2i4Psn 4nghHe1r0dsvGF3LfEpZ2S4Lr9U6eh8= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 suspectscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120147 On 8/4/2026 1:14 PM, Krzysztof Kozlowski wrote: > On Sun, Aug 02, 2026 at 06:43:30PM +0530, Viken Dadhaniya wrote: >> QDU1000 and related Qualcomm SoCs include a dedicated I2C target >> controller that operates exclusively in target mode. It is a distinct >> IP from the Qualcomm I2C master controllers (GENI, QUP) with a >> different register interface, so it requires its own binding. >> >> Document the MMIO region, interrupt, XO and AHB clocks, interconnect >> path, and optional pinctrl states for the controller. >> >> Signed-off-by: Viken Dadhaniya >> --- >> .../devicetree/bindings/i2c/qcom,i2c-target.yaml | 84 ++++++++++++++++++++++ > > Filename must match compatible. Sure, will update it. > >> 1 file changed, 84 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-target.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-target.yaml >> new file mode 100644 >> index 000000000000..1e34e874cc4c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-target.yaml >> @@ -0,0 +1,84 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/i2c/qcom,i2c-target.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm I2C Target Controller >> + >> +maintainers: >> + - Mukesh Kumar Savaliya >> + - Viken Dadhaniya >> + >> +description: >> + Dedicated hardware IP found on Qualcomm SoCs that operates exclusively >> + as an I2C target (slave) device on the bus. Supports FIFO (PIO) mode >> + for data transfer. >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,qdu1000-i2c-target >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + items: >> + - description: XO reference clock >> + - description: AHB bus clock >> + >> + clock-names: >> + items: >> + - const: xo >> + - const: ahb >> + >> + interconnects: >> + maxItems: 1 >> + >> + interconnect-names: >> + const: i2c > > Pretty useless name, drop the interconnect-names. Sure. will remove it. > >> + >> + pinctrl-0: true >> + pinctrl-1: true >> + >> + pinctrl-names: >> + items: >> + - const: default >> + - const: sleep >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + - clock-names >> + - interconnects >> + - interconnect-names >> + >> +allOf: >> + - $ref: /schemas/i2c/i2c-controller.yaml# > > This wasn't here before. Is this a controller or a target? Now I am > confused. It is a target. Wrong ref, will remove it. > >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + #include >> + >> + i2c@88ca000 { >> + compatible = "qcom,qdu1000-i2c-target"; >> + reg = <0x88ca000 0x64>; >> + clocks = <&gcc GCC_SM_BUS_XO_CLK>, <&gcc GCC_SM_BUS_AHB_CLK>; >> + clock-names = "xo", "ahb"; >> + interrupts = ; >> + #address-cells = <1>; >> + #size-cells = <0>; > > How is this valid? > > What sort of children the target has? What does it do with these > children? This controller is an I2C target only — it has no DT children. Will remove those lines. > >> + interconnect-names = "i2c"; >> + interconnects = <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_SMBUS_CFG 0>; >> + }; >> +... >> >> -- >> 2.34.1 >>