From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35438C43332 for ; Wed, 20 Jan 2021 17:36:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AF42233F6 for ; Wed, 20 Jan 2021 17:36:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731446AbhATR3m (ORCPT ); Wed, 20 Jan 2021 12:29:42 -0500 Received: from protonic.xs4all.nl ([83.163.252.89]:57018 "EHLO protonic.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732034AbhATOsd (ORCPT ); Wed, 20 Jan 2021 09:48:33 -0500 Received: from fiber.protonic.nl (edge2.prtnl [192.168.1.170]) by sparta.prtnl (Postfix) with ESMTP id 86D9144A022A; Wed, 20 Jan 2021 15:47:23 +0100 (CET) MIME-Version: 1.0 Date: Wed, 20 Jan 2021 15:47:23 +0100 From: robin To: Oleksij Rempel Cc: Mark Rutland , Rob Herring , Sascha Hauer , Shawn Guo , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , devicetree@vger.kernel.org, Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , David Jander , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v1 4/7] ARM: dts: imx6dl-prtvt7: add TSC2046 touchscreen node Reply-To: robin@protonic.nl In-Reply-To: <20210120142217.29652-5-o.rempel@pengutronix.de> References: <20210120142217.29652-1-o.rempel@pengutronix.de> <20210120142217.29652-5-o.rempel@pengutronix.de> User-Agent: Roundcube Webmail/1.4.8 Message-ID: X-Sender: robin@protonic.nl Organization: Protonic Holland Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-01-20 15:22, Oleksij Rempel wrote: > Add touchscreen support to the Protonic VT7 board. > > Co-Developed-by: Robin van der Gracht > Signed-off-by: Robin van der Gracht > Signed-off-by: Oleksij Rempel > --- > arch/arm/boot/dts/imx6dl-prtvt7.dts | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts > b/arch/arm/boot/dts/imx6dl-prtvt7.dts > index d9cb1e41cc10..63ae2065834c 100644 > --- a/arch/arm/boot/dts/imx6dl-prtvt7.dts > +++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts > @@ -266,6 +266,26 @@ &ecspi2 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_ecspi2>; > status = "okay"; > + > + touchscreen@0 { > + compatible = "ti,tsc2046"; > + reg = <0>; > + pinctrl-0 = <&pinctrl_tsc>; > + pinctrl-names ="default"; > + spi-max-frequency = <100000>; > + interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>; > + pendown-gpio = <&gpio3 20 GPIO_ACTIVE_LOW>; > + > + touchscreen-inverted-x; > + touchscreen-inverted-y; Please remove both inverted properties since it's not inverted. > + touchscreen-max-pressure = <4095>; > + > + ti,vref-delay-usecs = /bits/ 16 <100>; > + ti,x-plate-ohms = /bits/ 16 <800>; > + ti,y-plate-ohms = /bits/ 16 <300>; > + > + wakeup-source; > + }; > }; > > &i2c1 { Robin