From: John Garry <john.g.garry@oracle.com>
To: Yihang Li <liyihang9@huawei.com>,
martin.petersen@oracle.com,
James.Bottomley@HansenPartnership.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com, liuyonglong@huawei.com,
prime.zeng@hisilicon.com, "linux-ide@"@vger.kernel.org
Subject: Re: [PATCH 1/5] scsi: hisi_sas: Add host_tagset_enable module param for v3 hw
Date: Sat, 29 Mar 2025 08:50:57 +0000 [thread overview]
Message-ID: <f53505e6-9bfa-4553-91cc-497512a6977f@oracle.com> (raw)
In-Reply-To: <20250329073236.2300582-2-liyihang9@huawei.com>
On 29/03/2025 07:32, Yihang Li wrote:
+
> From: Xingui Yang<yangxingui@huawei.com>
>
> After driver exposes all HW queues and application submits IO to multiple
> queues in parallel, if NCQ and non-NCQ commands are mixed to sata disk,
> ata_qc_defer() causes non-NCQ commands to be requeued and possibly repeated
> forever.
I don't think that it is a good idea to mask out bugs with module
parameters.
Was this the same libata/libsas issue reported some time ago?
> Add host_tagset_enable module parameter to expose multiple queues
> for v3 hw.
>
> Signed-off-by: Xingui Yang<yangxingui@huawei.com>
> Signed-off-by: Yihang Li<liyihang9@huawei.com>
next prev parent reply other threads:[~2025-03-29 8:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-29 7:32 [PATCH 0/5] hisi_sas: Misc patches and cleanups Yihang Li
2025-03-29 7:32 ` [PATCH 1/5] scsi: hisi_sas: Add host_tagset_enable module param for v3 hw Yihang Li
2025-03-29 8:50 ` John Garry [this message]
2025-03-29 9:49 ` yangxingui
2025-03-31 7:43 ` John Garry
2025-04-01 1:12 ` yangxingui
2025-03-31 8:40 ` Niklas Cassel
2025-03-31 10:29 ` Yihang Li
2025-04-01 1:18 ` yangxingui
2025-03-29 7:32 ` [PATCH 2/5] scsi: hisi_sas: Use macro instead of magic number Yihang Li
2025-03-29 7:32 ` [PATCH 3/5] scsi: hisi_sas: Code style cleanup Yihang Li
2025-03-29 7:32 ` [PATCH 4/5] scsi: hisi_sas: Call I_T_nexus after soft reset for SATA disk Yihang Li
2025-03-29 7:32 ` [PATCH 5/5] scsi: hisi_sas: Wait until eh is recovered Yihang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f53505e6-9bfa-4553-91cc-497512a6977f@oracle.com \
--to=john.g.garry@oracle.com \
--cc="linux-ide@"@vger.kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=liyihang9@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=prime.zeng@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®