From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753066AbdDDIxo (ORCPT ); Tue, 4 Apr 2017 04:53:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56960 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752040AbdDDIxm (ORCPT ); Tue, 4 Apr 2017 04:53:42 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2AC5D80F7B Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 2AC5D80F7B Subject: Re: [PATCH 1/3] extcon: intel-cht-wc: Make error messages consistent To: Chanwoo Choi , MyungJoo Ham References: <20170403112630.30625-1-hdegoede@redhat.com> <58E33ADC.1000005@samsung.com> Cc: Takashi Iwai , linux-kernel@vger.kernel.org From: Hans de Goede Message-ID: Date: Tue, 4 Apr 2017 10:53:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <58E33ADC.1000005@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 04 Apr 2017 08:53:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 04-04-17 08:19, Chanwoo Choi wrote: > Hi, > > The intel-cht-wc.c[1] was merged on only extcon-next branch. > I think that this patch better to be squashed with patch[1]. > [1] commit 6786e42f31637 ("extcon: intel-cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver") > > How about it? That is fine with me. Regards, Hans > > On 2017년 04월 03일 20:26, Hans de Goede wrote: >> Before this commit the error messages were a mix of "Failed to ..." and >> "Error ...ing ...". >> >> This commit makes all the error messages consistently use "Error ...ing". >> >> Signed-off-by: Hans de Goede >> --- >> drivers/extcon/extcon-intel-cht-wc.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/extcon/extcon-intel-cht-wc.c b/drivers/extcon/extcon-intel-cht-wc.c >> index 0a05cc3..f1c43af 100644 >> --- a/drivers/extcon/extcon-intel-cht-wc.c >> +++ b/drivers/extcon/extcon-intel-cht-wc.c >> @@ -252,7 +252,7 @@ static int cht_wc_extcon_sw_control(struct cht_wc_extcon_data *ext, bool enable) >> val = enable ? mask : 0; >> ret = regmap_update_bits(ext->regmap, CHT_WC_CHGRCTRL0, mask, val); >> if (ret) >> - dev_err(ext->dev, "Failed setting sw control: %d\n", ret); >> + dev_err(ext->dev, "Error setting sw control: %d\n", ret); >> >> return ret; >> } >> @@ -288,7 +288,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev) >> /* Register extcon device */ >> ret = devm_extcon_dev_register(ext->dev, ext->edev); >> if (ret) { >> - dev_err(ext->dev, "Failed to register extcon device\n"); >> + dev_err(ext->dev, "Error registering extcon device: %d\n", ret); >> goto disable_sw_control; >> } >> >> @@ -301,7 +301,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev) >> ret = devm_request_threaded_irq(ext->dev, irq, NULL, cht_wc_extcon_isr, >> IRQF_ONESHOT, pdev->name, ext); >> if (ret) { >> - dev_err(ext->dev, "Failed to request interrupt\n"); >> + dev_err(ext->dev, "Error requesting interrupt: %d\n", ret); >> goto disable_sw_control; >> } >> >> @@ -310,7 +310,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev) >> (int)~(CHT_WC_PWRSRC_VBUS | CHT_WC_PWRSRC_ID_GND | >> CHT_WC_PWRSRC_ID_FLOAT)); >> if (ret) { >> - dev_err(ext->dev, "Failed to write the irq-mask: %d\n", ret); >> + dev_err(ext->dev, "Error writing irq-mask: %d\n", ret); >> goto disable_sw_control; >> } >> > >