From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01FC5C77B70 for ; Wed, 5 Apr 2023 19:55:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233676AbjDETzF (ORCPT ); Wed, 5 Apr 2023 15:55:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233855AbjDETzA (ORCPT ); Wed, 5 Apr 2023 15:55:00 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D52818F for ; Wed, 5 Apr 2023 12:54:59 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-75d1e0ff8ecso1521139f.0 for ; Wed, 05 Apr 2023 12:54:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; t=1680724498; x=1683316498; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VQhohcoSfZ+TXrTocJ4dFpG6ihZhTRmLCl7ysvHMbVU=; b=FhKhafVmcp7gRPH9mLZ6WMv1WP6cwFfcSTpdwK1fJgcTI7MMQ2QM2IA9Dg60YmBtmh oP7SIiv5orRC+LEgE6uEWQrjd30KMJj2TFfuOhMbnh0FpPtNwyV7LSVHj4/QGPP4FHC1 XM1wc7q1S5aJaN0A/e+ZOHgIecq4UhvgtlPpCXSPBTunwhXxW7qQh391dlff3lWI6upj vqgDpTNl3QbmlNJ51Hlt/LLkJYKNOJ1OhdXbGIHV9IvSS2tR/bK4YSs26/T8LHY8XZR6 1hdaUFQZN+dDV/gqj+3Eoz/y29mQw3sxvVyaJFwzgMxoJYjk1QJUCF94oWvs8UHzpWHh FcfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680724498; x=1683316498; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VQhohcoSfZ+TXrTocJ4dFpG6ihZhTRmLCl7ysvHMbVU=; b=gEoaIq7w49xsI2XXKDVhrwRJOFEAnhJo0Ile8PmGDJdgJ79bys0xUT39wcbqQjrMcd tmQA1TnwtsZlw7RTgZ2wADdFQHgRSUii0hcSp0bfRuI0HNkW6SUt+2ZcNhS9Lf8tJmrV yaj3KIcO4ENEP6RdfDfzCAuI1m1haax4+YTCTmywtwk1ANjC9ZK+Wnc9dBWVZIN++3k1 nrxG1LGPxm+n5LBpbmmsp0iK/KyMonCwn60zwvPBoaNnSsk7GQiDUDkmrFiaJjxMPWd6 KAJdA/B/1m/JZGUTCP2bdRuVtRftc9pUkkJeEIh6WHqUW9+y6nQ+foczXsFUqyzwuGrz kxfA== X-Gm-Message-State: AAQBX9c+x78kgHebW/u2H59pw4xdmlKqu/wozV672dPpHUEm1eMGP2TI pR9zMZNjGhP9fpWPbMjYAutXww== X-Google-Smtp-Source: AKy350YUu/y57XeMmrwciQfeApPTgA/J9vVl+orfxC6zXtuDbf6ys2L0P8ouilkvuX4zyCz+OzcdCA== X-Received: by 2002:a05:6e02:bee:b0:319:5431:5d5b with SMTP id d14-20020a056e020bee00b0031954315d5bmr1537610ilu.1.1680724498566; Wed, 05 Apr 2023 12:54:58 -0700 (PDT) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id z3-20020a029383000000b004062e2fdf23sm4140975jah.74.2023.04.05.12.54.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Apr 2023 12:54:58 -0700 (PDT) Message-ID: Date: Wed, 5 Apr 2023 13:54:56 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [RESEND PATCH v2] eventfd: use wait_event_interruptible_locked_irq() helper Content-Language: en-US To: Wen Yang , Alexander Viro Cc: Eric Biggers , Christoph Hellwig , Dylan Yudaken , David Woodhouse , Fu Wei , Paolo Bonzini , Michal Nazarewicz , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Brauner References: <43fd324c-585c-d85b-230c-5b086e1aaa2c@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/5/23 1:40 PM, Wen Yang wrote: > > 在 2023/4/6 03:26, Jens Axboe 写道: >> On 4/5/23 1:20 PM, wenyang.linux@foxmail.com wrote: >>> From: Wen Yang >>> >>> wait_event_interruptible_locked_irq was introduced by commit 22c43c81a51e >>> ("wait_event_interruptible_locked() interface"), but older code such as >>> eventfd_{write,read} still uses the open code implementation. >>> Inspired by commit 8120a8aadb20 >>> ("fs/timerfd.c: make use of wait_event_interruptible_locked_irq()"), this >>> patch replaces the open code implementation with a single macro call. >>> >>> No functional change intended. >> Looks pretty reasonable to me. How did you test it? >> > Thanks. > > We have verified it in some local testing environments, and the intel-lab-lkp has also tested it more than a month, as follows: > > https://github.com/intel-lab-lkp/linux/tree/wenyang-linux-foxmail-com/eventfd-use-wait_event_interruptible_locked_irq-helper/20230217-023039 Nice, you can add my: Reviewed-by: Jens Axboe to it as well. Adding Christian as well, as I guess this should go through his/al/vfs tree. -- Jens Axboe