From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BC05342158; Wed, 26 Nov 2025 20:27:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764188856; cv=none; b=jGdFhELLfHhVHsSH84LHenLyHjLshC/EDTs7vKYzcwVpQaWs5Qn18xtdnfWl7sYonF22Vf2xDcnD5iEinokXisDHo3VF3IQwYZhw5/qZwIQD4s+FVifR7PifW4Jcg/99ttoAfkttj5GRQMzJcE22ST0Oa+jfQ/HDXWg95QTrXgw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764188856; c=relaxed/simple; bh=OpcbLyKYxZlxHhsaZdpZh0uLt6gJOnXWPmZWcJ0p0KY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hcJEPLvQDu3agjUs8JxXg3RvULMHrIUpW6GFxtVDVasDtOv+XUwkYbfAtle+J3iIrGPriA9olePCNUUw/wuG9Vrplp1yMw6eT6BLujE7ehzyW9TZCKBkDSEQFMBQkLMQ0nmX8zY5XE+IiSIXqP1O793ajLttt2NViNEohvbCi2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=ok95PXRf; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="ok95PXRf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1764188851; bh=OpcbLyKYxZlxHhsaZdpZh0uLt6gJOnXWPmZWcJ0p0KY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ok95PXRf1zTCFm0YnE0co+79ZEXCN6iHKtdfeBvVFGEnFfol70oUDdzQnxPoNtNhA 4vgiQgF8zBakJ4YELldWOM95ZlndMvGGD6x9j6wPtfZqb0VQM7QS0ZfQYA4Zq2aAZg B9VNerwVPKXD2Isn7jYFoVYmkbVLzAvmDo5AGTYlgMgiqqIi4wWYdJp0nIWMuAundz GBE34vN2Borx3yFEHTqArWTmMki2+u09xe+JI123WkPlp0YFyHt6i6W6PtO1FO48Ci TT/dGWd1oEhVvzp7yJxUPwhCPH5O0eV3b2mb7Gf79I6HsLVJKpvrX7/ENQ1NyaHeU+ ehucfjHs5TzgQ== Received: from [10.40.0.100] (185-67-175-126.lampert.tv [185.67.175.126]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: mriesch) by bali.collaboradmins.com (Postfix) with ESMTPSA id 7E64117E101A; Wed, 26 Nov 2025 21:27:30 +0100 (CET) Message-ID: Date: Wed, 26 Nov 2025 21:27:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH next] media: rockchip: rkcif: fix off by one bugs To: Dan Carpenter Cc: Mehdi Djait , Mauro Carvalho Chehab , Heiko Stuebner , Sakari Ailus , Hans Verkuil , Bryan O'Donoghue , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: Content-Language: en-US From: Michael Riesch In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Dan, Thanks for the patch, good catch! On 11/19/25 09:09, Dan Carpenter wrote: > Change these comparisons from > vs >= to avoid accessing one element > beyond the end of the arrays. > > Fixes: 1f2353f5a1af ("media: rockchip: rkcif: add support for rk3568 vicap mipi capture") > Signed-off-by: Dan Carpenter Reviewed-by: Michael Riesch Best regards, Michael > --- > .../media/platform/rockchip/rkcif/rkcif-capture-mipi.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/platform/rockchip/rkcif/rkcif-capture-mipi.c b/drivers/media/platform/rockchip/rkcif/rkcif-capture-mipi.c > index 1b81bcc067ef..a933df682acc 100644 > --- a/drivers/media/platform/rockchip/rkcif/rkcif-capture-mipi.c > +++ b/drivers/media/platform/rockchip/rkcif/rkcif-capture-mipi.c > @@ -489,8 +489,8 @@ static inline unsigned int rkcif_mipi_get_reg(struct rkcif_interface *interface, > > block = interface->index - RKCIF_MIPI_BASE; > > - if (WARN_ON_ONCE(block > RKCIF_MIPI_MAX - RKCIF_MIPI_BASE) || > - WARN_ON_ONCE(index > RKCIF_MIPI_REGISTER_MAX)) > + if (WARN_ON_ONCE(block >= RKCIF_MIPI_MAX - RKCIF_MIPI_BASE) || > + WARN_ON_ONCE(index >= RKCIF_MIPI_REGISTER_MAX)) > return RKCIF_REGISTER_NOTSUPPORTED; > > offset = rkcif->match_data->mipi->blocks[block].offset; > @@ -510,9 +510,9 @@ static inline unsigned int rkcif_mipi_id_get_reg(struct rkcif_stream *stream, > block = stream->interface->index - RKCIF_MIPI_BASE; > id = stream->id; > > - if (WARN_ON_ONCE(block > RKCIF_MIPI_MAX - RKCIF_MIPI_BASE) || > - WARN_ON_ONCE(id > RKCIF_ID_MAX) || > - WARN_ON_ONCE(index > RKCIF_MIPI_ID_REGISTER_MAX)) > + if (WARN_ON_ONCE(block >= RKCIF_MIPI_MAX - RKCIF_MIPI_BASE) || > + WARN_ON_ONCE(id >= RKCIF_ID_MAX) || > + WARN_ON_ONCE(index >= RKCIF_MIPI_ID_REGISTER_MAX)) > return RKCIF_REGISTER_NOTSUPPORTED; > > offset = rkcif->match_data->mipi->blocks[block].offset;