From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C9381FDE14 for ; Wed, 8 Jan 2025 15:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736349460; cv=none; b=pFqxLHz8B5QRkZNowI1FFL1kjPB4eX6UyvmeYK8jvCIkLJx3ESW6dDsC01LnMbLu0DHW8CrvxnsX9lf9d9i1g+99G/pAx64Nz3+EEpnOISTyR5cqGusZ2JZGbyMjH5TPrxFSZX7F54JsoKtI99UtD/k8F1WtZ+wcerAxgE5q9Uc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736349460; c=relaxed/simple; bh=Ebeg1TL2BeajKrP6fpDxuqrt/iS+ncCHefaCK9FF0No=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DzUqthAmXzz1NuB5aCmpn64+VdbzI4aeI1FObDQd3Ku2oXj98JWW2Bc66iErpBiavdVhNjRGOAW6x++CbcCvM+DddVv6e6qi/zcKetNzz2Cx5t+tG2/K7af3V/mAPZl7Wg2BfsfodZermNyiDivUvAI8FUyhxVVHl1yRSc9Gwd8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=R8ZJzvlq; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="R8ZJzvlq" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3ebbe804913so4866826b6e.0 for ; Wed, 08 Jan 2025 07:17:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736349456; x=1736954256; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=alG1j42X6iRKjZ4baHXWov29C3FPDTojvMLiPpX80+0=; b=R8ZJzvlqXsnKt3Ka9F5l9TeFqxa+10QsBWZ93oc5V5ApkSMO8KL7/HCdT4kx98iTE7 OujbcRWIdadEleoxFDLPftBEVIw5wXK9uUKoysXyCnJ7ty6GEMFaqtwmvtXRAupk5+Of BKYCKsMFLsTzqdr4KfEkt+CXM2Kn+vrsemmLGkPSLM+SextJtdalYLzbKOCH2quTbK/M mejLNysoh7rnl/orlBP3llT4JYXHAjmxfUMN+NPl9xXDyFxCyv4HppiqHoRBM5Cl/JMf oUmrjJPtQdb66mHoy18cGWAm21P5BJefXXbMLIuli/baqgrVxYE9JKqlJURkGpFUCAd2 05Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736349456; x=1736954256; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=alG1j42X6iRKjZ4baHXWov29C3FPDTojvMLiPpX80+0=; b=B0FT1XGjqtJaDD8YIeZdkYVLw9v6kixCU4OJ7umdSSIp72R6mxrnyDohIL+PpT75PW nyG/7djzFG/X2pDk3Sf1+C80VSyezIeELAoyZIXptmZt+QfQ1+Z8PbilIIm1I1KEnv4Z pyEsgUnssrLmXs3vVF6dZVmfNlWjnJ7EhsxNYYf2JZcfD7X8XXtoRauG3BlCHoVyCtjR z8In5jGwDaHoEXZ9hGYpwbuqGBmiBZqhkk/P1cuNMjbZg82P71ChFw0K27PPMzlaaJu1 trL42VfbuKc6pci6hjLh1f6uLzaGGu+6V8tmSzZJf20+bP+zU1mHJ4rJ1JH8EOgtfClW lEPw== X-Forwarded-Encrypted: i=1; AJvYcCUE8o217gj4+DUAYkW5EI3yChpiR3dsRMdE64OkxAqMI8YVm3tVxdwfdtqz6pr3PIauQjwrMC0jl6pEBHc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+NDVrfzQ9YDpAu+ZnpyMjY6gnZCszh5IX3LEg8VCwUkTf3GzA weEe4G6NqnZjy0hIQHJoi45rrHTsLhmzlAYT+UB+ZXkzRi5/+FPriBFtTKVciYQ= X-Gm-Gg: ASbGnct4thbovyAH/siW7LtWMWYbmFaS0yWGMa9iXLBvUoGz14bCPv68kWjKBa6BWFJ x7azbnY4Y9UF6zTEL0LRli7uq2B/HSISnEjzOmQrlEA0/nKXrIs1x813BjFtU5x5unRjDnMuVjK M8OYO4X5AkxDGqcS6ofVtsTQutX2nk8mFwzvhkCX1MLXiDALco4+MrM+wSyfdmcqQMrRWj0DEwb ImFeJZ8vGMJMlAM3aHpwoge+n937VAZgtR45ZZFO000gXDBVPUau/0Hj7R47enX2u7skeFFSBR3 gb+trstNSPOKsqquJg== X-Google-Smtp-Source: AGHT+IGwVgCGjQbO/qqRqSgc1J+RRMGG/noUnXoE/RftuE6fGYBcA6ytF5/pzERHkiy1D6obDhsWMg== X-Received: by 2002:a05:6808:1825:b0:3e6:1057:21af with SMTP id 5614622812f47-3ef2eeb424amr1616812b6e.41.1736349456457; Wed, 08 Jan 2025 07:17:36 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3ece2549542sm11552313b6e.32.2025.01.08.07.17.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 07:17:34 -0800 (PST) Message-ID: Date: Wed, 8 Jan 2025 09:17:32 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/5] iio: adc: ad7380: add alert support To: Julien Stephan , Lars-Peter Clausen , Michael Hennerich , =?UTF-8?Q?Nuno_S=C3=A1?= , Jonathan Cameron , Jonathan Corbet Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20250108-ad7380-add-alert-support-v4-0-1751802471ba@baylibre.com> <20250108-ad7380-add-alert-support-v4-4-1751802471ba@baylibre.com> From: David Lechner Content-Language: en-US In-Reply-To: <20250108-ad7380-add-alert-support-v4-4-1751802471ba@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/8/25 6:49 AM, Julien Stephan wrote: > The alert functionality is an out of range indicator and can be used as > an early indicator of an out of bounds conversion result. > ... > +static int ad7380_get_alert_th(struct ad7380_state *st, > + enum iio_event_direction dir, > + int *val) > +{ > + int ret, tmp; > + > + switch (dir) { > + case IIO_EV_DIR_RISING: > + ret = regmap_read(st->regmap, > + AD7380_REG_ADDR_ALERT_HIGH_TH, > + &tmp); > + if (ret) > + return ret; > + > + *val = FIELD_GET(AD7380_ALERT_HIGH_TH, tmp); > + ret = IIO_VAL_INT; > + break; > + case IIO_EV_DIR_FALLING: > + ret = regmap_read(st->regmap, > + AD7380_REG_ADDR_ALERT_LOW_TH, > + &tmp); > + if (ret) > + return ret; > + > + *val = FIELD_GET(AD7380_ALERT_LOW_TH, tmp); > + ret = IIO_VAL_INT; > + break; > + default: > + ret = -EINVAL; > + break; > + } > + > + return ret; We can just return directly in each case instead of using break (preferred style in IIO). > +} > + Reviewed-by: David Lechner