From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751140AbdHZT05 (ORCPT ); Sat, 26 Aug 2017 15:26:57 -0400 Received: from mout.web.de ([212.227.17.12]:52881 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751062AbdHZT04 (ORCPT ); Sat, 26 Aug 2017 15:26:56 -0400 To: sparclinux@vger.kernel.org, "David S. Miller" , Rob Herring Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] sbus: Delete an error message for a failed memory allocation in uctrl_probe() Message-ID: Date: Sat, 26 Aug 2017 21:26:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:QCqH3Jpz5k75RxyIAkbVk5XFQePFdBgIbECrCn8/NJT2Ho/CWE2 HJ+Dp1YJDJvDQ5y+kpz6JlpIW1FvyGfOu7auBY2je6dlLWwIFZd5gDIHq+ZlIfqZ2wHnsf4 RR30twXyCgIM7AAl6XbRGU5ZeDTzAPeNUZNHfPXrq6hZ1BgxE7p2mDNUZ7nDM0dW8zWrC0V 1cpZTlCADb4kqed8z8PYQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:ef/ucZtDe68=:UJnlG/WrcICvZymWAB34b7 RFQKcf0yW8KRvqXvoajS7Fmrn9RLK4wScc4hIvftTWV5oXGuc3MKmAp0JAsOoshBz6VzhCdwu b7xCgochRlNWSKDiMiNSpzictRx8PArBQPOF6fiNYCeT4QPe51NW2wpH8P1vAcbzFn3q1RzGF WvvU/CCluCdXzXuL9ZsBSOoGZOxdfsUO5TXXq8+6QWbvZ3eK9zEl1oym64qC34oTZgh/uHFJU mqRqSz5WGqqp1DnE1Bqq8mx/6gNB8CSsWC2sgZCmBzlSft0NwJKZtl20RMt1jUJ9SSZ2jxlDG 2N2H4/v7Ykvx1fTS5I02I6mvDRLX4/eZFRohxcHwdUSwVD3dTxT6YlGCvSTAORRuxZMhR7PQn R9e6lX/3wQJpVb0Ea0hMiYsKoJnPHDEOVXtTRPI89Ux63i5S601ADZ7zjdNokv7AP9YcZOk7x G0GFmnIrY1VOkNvf5O9eH04RTgsDsLRIOhGC8RUKWvyvV/35FN23PTW8Zg4ZU1A9Fp8it+Tq5 gmj8UOX3EXbJPor3xjc3ig98y7c96JH36A96g2QeSSkVdUNHa+sbvktzBeorwXBhdkl6+fP+W RomJgDKfByG5MmDY3iW2YhZG8kPhZWfv+gogJ27IABQqHAkG7HQ5vb4YweZyMQHUL3j6EIWpS rcWasU1WopSD50Rm1C62Dygk1dAFUAIB1nJnlzbn9ZtL7GF+yqn0Ban8g6rMUm5dV7bCLvsqO F5WTMhU79acemEPJkzFraElogjrvtZg62GRC5YCqer8MmJ6G2wan1RxiI5moOt71N7IN0in7e 2kEcil2+8vRTOQujNr5mQoKtvxAT9y2bssX2HcfDUPGtu75qxI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 26 Aug 2017 21:21:33 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/sbus/char/uctrl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/sbus/char/uctrl.c b/drivers/sbus/char/uctrl.c index 0a5013350acd..f3b9f7e87ffa 100644 --- a/drivers/sbus/char/uctrl.c +++ b/drivers/sbus/char/uctrl.c @@ -352,10 +352,8 @@ static int uctrl_probe(struct platform_device *op) int err = -ENOMEM; p = kzalloc(sizeof(*p), GFP_KERNEL); - if (!p) { - printk(KERN_ERR "uctrl: Unable to allocate device struct.\n"); + if (!p) goto out; - } p->regs = of_ioremap(&op->resource[0], 0, resource_size(&op->resource[0]), -- 2.14.0