From: Randy Dunlap <rdunlap@infradead.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
Len Brown <len.brown@intel.com>,
linux-pm@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>
Subject: Re: [PATCH] kernel.h: add comments for system_states
Date: Thu, 1 May 2025 18:28:15 -0700 [thread overview]
Message-ID: <f5402d7e-78d0-4efe-bc35-c30dcdf9f98a@infradead.org> (raw)
In-Reply-To: <CAJZ5v0gnsFM7YcBqO8Mbkr72ipQxT8nJ=i94z74Q0XM1csnTYw@mail.gmail.com>
On 12/10/24 10:55 AM, Rafael J. Wysocki wrote:
> On Fri, Nov 29, 2024 at 5:57 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> Provide some basic comments about the system_states and what they imply.
>> Also convert the comments to kernel-doc format.
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
>> Cc: Pavel Machek <pavel@ucw.cz>
>> Cc: Len Brown <len.brown@intel.com>
>> Cc: linux-pm@vger.kernel.org
>> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
>
> Fine by me.
>
> Acked-by: Rafael J. Wysocki <rafael@kernel.org>
>
Please merge...
Thanks.
>> ---
>> include/linux/kernel.h | 14 ++++++++++++--
>> 1 file changed, 12 insertions(+), 2 deletions(-)
>>
>> --- linux-next-20241125.orig/include/linux/kernel.h
>> +++ linux-next-20241125/include/linux/kernel.h
>> @@ -176,9 +176,19 @@ extern int root_mountflags;
>>
>> extern bool early_boot_irqs_disabled;
>>
>> -/*
>> - * Values used for system_state. Ordering of the states must not be changed
>> +/**
>> + * enum system_states - Values used for system_state.
>> + * Ordering of the states must not be changed
>> * as code checks for <, <=, >, >= STATE.
>> + *
>> + * @SYSTEM_BOOTING: %0, no init needed
>> + * @SYSTEM_SCHEDULING: system is ready for scheduling; OK to use RCU
>> + * @SYSTEM_FREEING_INITMEM: system is freeing all of initmem; almost running
>> + * @SYSTEM_RUNNING: system is up and running
>> + * @SYSTEM_HALT: system entered clean system halt state
>> + * @SYSTEM_POWER_OFF: system entered shutdown/clean power off state
>> + * @SYSTEM_RESTART: system entered emergency power off or normal restart
>> + * @SYSTEM_SUSPEND: system entered suspend or hibernate state
>> */
>> extern enum system_states {
>> SYSTEM_BOOTING,
>>
--
~Randy
prev parent reply other threads:[~2025-05-02 1:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 4:57 Randy Dunlap
2024-12-10 18:55 ` Rafael J. Wysocki
2025-05-02 1:28 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5402d7e-78d0-4efe-bc35-c30dcdf9f98a@infradead.org \
--to=rdunlap@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®