From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA547479868 for ; Wed, 22 Jul 2026 08:28:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784708900; cv=none; b=g/70eFEHPZy2SdhWLJXYHJMXpYHsAnU3z7IL3nBuoxRyKFVvnFo3ZeYwKJbRKzZjxaelu4yeuK9nE5RgejtYwmvBp+WJydw5ZqUmq03SKlbYj/Jq/WVecsW3O3qjZCkKxxl1tzUHi84qfvGMQN7uLvG/p7g3H4eT5vt9t8H1C/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784708900; c=relaxed/simple; bh=TkK8+LPz3NLYgchZpLtTgVE409WX1AzhZy1O6ggVhyQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=urMqGC0kmK5YAOrIGud3G12LTYGODlzBoJR8IBQdd2vDynDwB7WlAU83NzY0pQnRLlFfJRkLg/0eBWiUMKgodeHN9AgAjEgRAR0vKBoKBWq6fVyPBzKuofqAqPynkleRCXphSzcGfXa+kzdAz9lESq/a33nLzZI2RzuOfpMZcZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TkhDpZ4t; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KuFeEGAg; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TkhDpZ4t"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KuFeEGAg" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66M53cwD3767564 for ; Wed, 22 Jul 2026 08:28:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mIsymjFuprG4so7Q98HuwxLOIzy0qsmeHV37HSxMH4Q=; b=TkhDpZ4tS7+g6FSu V7hA31jvtXYwG8KYuedqPWY2GzKy10BPTSi76qlCpspHrBvRIpDD6sZjr8tRdJyD 5SgMYd+5tUtvFIDkcPUR89Kej60q2/cRRhTMCmLCdTGmXacX8Skz6H3KSqYwF02E KuQS5Tw5yjxdY3+IWY3rCoYvAyp+VLz4uO6svqk8oRV7umNEedPcP4tytvgAQ/D6 2L7ulhngw4C6rA7P4W1zZzCJSAOhIa+TEDiJ/ZJ1zEQZoXZfCdMyndzNnV5CGCcy GjBKW7wLRhJIDe4XFZThZM03+utPhHYrJrUFW5giJBeoVJdGpBvbwVvGmPqzednG 3SExMA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fjnu4s454-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Jul 2026 08:28:03 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e5110c89eso269718785a.3 for ; Wed, 22 Jul 2026 01:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784708882; x=1785313682; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mIsymjFuprG4so7Q98HuwxLOIzy0qsmeHV37HSxMH4Q=; b=KuFeEGAgvF+vZl5wdpo+I3s3KtYfiXzcl1ww7ofB4rGIEgf1f4lKntUwH8+Qodz/38 iZ5+iwh6+7VbQ8XPb5uL/L7hDYXCFszuGXUP+UwYcxygBKByO9F+Tp3jWNuiR/FrnGSO EgGWaCUOA4NUqqjnbERY4WysIH1tNTvrb3DePTQtHBoyQN1D20jFU9RwRrjzgxMHeS8U /wk6z9pcd/oY0fR7jhHmM68Es5TWt1h5SBUthFkp99/bixn2+ng4Jc2LAUW3RmNuFPSY Rl+MprY+5WFtKYMvg5KEXjmh5wcClNCrvBNp/uoJBCwx4M7d0erpjZx85N97yHecmvtR Zg5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784708882; x=1785313682; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mIsymjFuprG4so7Q98HuwxLOIzy0qsmeHV37HSxMH4Q=; b=JYNQahxNnG5spNuE/zLDoLsDLqtnfWsFC2l5mjV6W6QDJ7LGhSuIweIqdiRiLEU+xP KtnXKKEf43UtKqtsN1FaYsG/3lU3A6wqqvLJ7i2YDklKWnp4ge/YbzKq6P3HQE9KyODV QIYrVEE8DVlIIFfrGOA6EfHnu6d7gZVCLBK2Dcl4eks+8IbPgLEVwpvvx1WWYT9PqVKq 8yvH8e/IEqRCkluO2S+ixr+h3i4UXhBOmZWcAv6XOqg4lR2FIpAtPF4W6oRS/eQoS9cY 7A6DhP4Wek1+6TzWj5qYk1insCgeF3bxbrLJdWgI3fV7r/JuSmDtjGGGWE00nmnHDBjH 5NHA== X-Forwarded-Encrypted: i=1; AHgh+RodRpeSbwbHqBxvMOnUH/XsI90fbHatj0QmhhGF32CWw5pL0+B7niFEdNlBOwb39gaFHD0N9WkV3wXR25I=@vger.kernel.org X-Gm-Message-State: AOJu0Yw28Rjj8BXQ/BnYr7ZoLKXzrvC9bmCZ7bIUgAqLvgW7WbzxGjpD FJqKrUIFJLWLjFnb4iCT1IobrLZwe0yuInfRmJ3HQSe2xfGgJWXxb4xt+kngv6XQ85W33osidwh w9IVBore8Wif4WjytkL8BATDIfu+1Tg2yMyTogX87LUQxfRx0IDD6iy2IRyxO4ODhJ8I= X-Gm-Gg: AR+sD10vAF9nsLmi4azv+lN30KuHhFmA06qf4QpQ8+YRsKXPzwp/+kj/yna1DQukvbH PBES/+Y4JVq3EH0xgu2moCtIMrABtdekDDqsg35lauwjozs2xvpjOsKzWrg4tp4WOKV+v2ZXoMf XbE9zwYp6MkXC4n4tNdPDEIDsMmmgrhxdN5zhyu3g15fSiBscZQrg7qAOu++I2KeHPFzhyXJifh 3qwsJecllp2AaKWbocJ+PgGfBuhyThAWgn42s6KtsWhTIEBTQlhf6G7YO03muDYRvhNHeH0CAdP 55kWizMytUbgsY/0Yp0DdvoDBy2wP1pIDZXxi2hPdbCnHAn4OCIt+0I93GAEjukF7X9CV2sQt/k 2baEvpN2Yfh/Ntae0eiHa3JZK X-Received: by 2002:a05:620a:1709:b0:92e:705f:1626 with SMTP id af79cd13be357-930f458fd0emr196446685a.6.1784708882436; Wed, 22 Jul 2026 01:28:02 -0700 (PDT) X-Received: by 2002:a05:620a:1709:b0:92e:705f:1626 with SMTP id af79cd13be357-930f458fd0emr196445785a.6.1784708882047; Wed, 22 Jul 2026 01:28:02 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69f34ba67f0sm621763a12.12.2026.07.22.01.27.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2026 01:28:00 -0700 (PDT) Message-ID: Date: Wed, 22 Jul 2026 10:27:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] usb: typec: ps883x: fixes for older Thunderbolt 4 / USB4 docks To: Sebastian Reichel , "Dr. David Alan Gilbert" Cc: jens.glathe@oldschoolsolutions.biz, Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Abel Vesa , Heikki Krogerus , Bjorn Andersson , Konrad Dybcio , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, stable@vger.kernel.org References: <20260718-ps883x-disable-usb4-v1-0-cec86d0b909e@oldschoolsolutions.biz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Tuf75JuIgSsXg_BYZ5Br0Ed1NV4FbaL- X-Authority-Analysis: v=2.4 cv=KLhqylFo c=1 sm=1 tr=0 ts=6a607f13 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=B0dxQpQml5LPzYmAcjoA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=lhd_8Stf4_Oa5sg58ivl:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDA3OCBTYWx0ZWRfX7AGcYmvThYE1 rqRgGP9n2BgzoiLqVAM6MxJKYD/4KqYNKXm2BHapVg2Jl588pzAxeJUz1aeYOcYT99XHZSvkvvl 9nOgpdTZj9CL0Rxaar+Zx8tyK5VjnDdrsjj6GkB4GunKYL++jzhgi7r7af/H8JFXxjAUEe6VZzV BVKPFMn7tEJLVJ1VxlXCQpHz94Deci6GlzSHBEqQeifUcEYUPBX3KV5/8AYzxcuvlOFXPNriElF n2dBCwL37QcS3sqV8RiWQ6luJyqAM8RDBO4L2mgha6CHXpAzXDuUn5lg7pSw0kaPEk0vHolVNLO BXViaVixkIgvxRwwb7bZSa4L4ZsaavwPATOICizoDq/5ITOQ6yLaz0EsVAhy09YovqephvinPSb poYv4XxsN6iWgvMWwsCdniRsD48+m6sIaEjCWOxpZrByQmuOEKPP6ofaOvaFY0KC4AyE347RzOZ CfHN09c0NlfsKZnqNlw== X-Proofpoint-ORIG-GUID: Tuf75JuIgSsXg_BYZ5Br0Ed1NV4FbaL- X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDA3OCBTYWx0ZWRfX66z2yZLvmnqF EBhkgjciII8Ei0LqRnvJ336CnKUII2OZdgLEe1X/GHg/SkZx9Ty9ibt/7XuYo52ceHdjHTKESb0 0fXyBm7L8gPNrmGVDcfnrtTUT7Ll8MM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-22_02,2026-07-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607220078 On 7/22/26 1:34 AM, Sebastian Reichel wrote: > Hi, > > On Tue, Jul 21, 2026 at 04:24:06PM +0000, Dr. David Alan Gilbert wrote: >> * Sebastian Reichel (sre@kernel.org) wrote: >>> On Sat, Jul 18, 2026 at 07:06:28PM +0200, Jens Glathe via B4 Relay wrote: >>>> On Qualcomm X1E80100 platforms (e.g. Lenovo ThinkPad T14s Gen 6) >>>> using the Parade PS883x retimer, connecting USB4-capable docks such >>>> as the Lenovo 40B0 via a regular Type-C cable (which forces the dock >>>> into Type-C fallback mode) often results in working USB but no >>>> DisplayPort output. [...] > AFAIK only Qcom and Apple M series support it. A quick search > suggsts Apple used an Intel retimer in the past and a custom one > nowadays. From the looks of it the x86 world cannot use this driver > either and probably handles retimers transparently in ACPI, so it's > effectively Qcom specific until other vendors start adding USB4 > support. The only thing announced potentially running into this > would be the Nvidia RTX Spark, which first needs to be released, > then find a bunch of people motivated to implement upstream support. > Nothing with USB4 capabilities has been announced from Mediatek or > Rockchip. So I wouldn't hold my breath for another user and still > suggested adding the machine check instead of simply disabling USB4 > for everyone ;) The PS883x is used on x86 machines too. Apart from I2C, it also ""speaks thunderbolt"" - the bus has a way for retimers to enumerate and communicate with the routers (controllers) through a sideband UART-like interface. But for that, it still probably needs the platform firmware to program it into the right mode over I2C, which Linux is unaware of (as it effectively should be). FWIW, we do the same on X2. An MCU takes care of setting it up. Konrad