From: Hans de Goede <hdegoede@redhat.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH v2] vboxsf: Remove redundant assignment to out_len
Date: Fri, 25 Feb 2022 10:24:30 +0100 [thread overview]
Message-ID: <f54a44e7-1ae5-1e09-9e62-2039dd5639dc@redhat.com> (raw)
In-Reply-To: <20220225074838.553-1-jiapeng.chong@linux.alibaba.com>
Hi,
On 2/25/22 08:48, Jiapeng Chong wrote:
> Clean up the following clang-w1 warning:
>
> fs/vboxsf/utils.c:442:9: warning: variable 'out_len' set but not used
> [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> Changes in v2:
> -Delete " out_len += nb;".
>
> fs/vboxsf/utils.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/vboxsf/utils.c b/fs/vboxsf/utils.c
> index e1db0f3f7e5e..7f2838c42dcc 100644
> --- a/fs/vboxsf/utils.c
> +++ b/fs/vboxsf/utils.c
> @@ -439,7 +439,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
> {
> const char *in;
> char *out;
> - size_t out_len;
> size_t out_bound_len;
> size_t in_bound_len;
>
> @@ -447,7 +446,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
> in_bound_len = utf8_len;
>
> out = name;
> - out_len = 0;
> /* Reserve space for terminating 0 */
> out_bound_len = name_bound_len - 1;
>
> @@ -468,7 +466,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
>
> out += nb;
> out_bound_len -= nb;
> - out_len += nb;
> }
>
> *out = 0;
prev parent reply other threads:[~2022-02-25 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 7:48 Jiapeng Chong
2022-02-25 9:24 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f54a44e7-1ae5-1e09-9e62-2039dd5639dc@redhat.com \
--to=hdegoede@redhat.com \
--cc=abaci@linux.alibaba.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®