From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 857BA276050 for ; Mon, 16 Feb 2026 11:18:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771240698; cv=none; b=jUOdHXS9sZhTccDcu6AYM325AfkKH5hl89VU2zTDvGWZ0JG0uanrxDqNSu5NBNFnLgLOhfwyAN+cphTADFZwq/vPl5GQ+O9DTKOBrWuEN2ibD7Qnwi6pNsGJ6XZDUjbXOKFzy0elfShGUghwfvp+gjJGzcRyi/lrMQookMaNVrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771240698; c=relaxed/simple; bh=ad85B4rdRDGUPF7BGuuP0i7dKAVWLVlLV2lYoMUmcy0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TyHwh+h7YN8D2gHHT1sJa5qWzu6x23AsJvLX8tpH2f8c84g5kkP9QN6KJvG61VkJQhg9OD0pPdxrkk4GjJUwIbI4MY5BnjnBIJhzKQGQK9I1A6bfIZOsekAHJvMI3T7xkXjcPjVHVt3If6GuV252bHNi7ZWdM9bKvnbbOrKHB9Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HnnyZSVT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GZTGUIHj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HnnyZSVT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GZTGUIHj" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61G9IxnD2550111 for ; Mon, 16 Feb 2026 11:18:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= t2hNIzX5BNkAETmCDKWT6OzqUx76/RGNDM+ucplj4ws=; b=HnnyZSVTAJl61FAY mg+rL3wOxhzT/vPsNM+k7FZkBq8blMNQShNg9UW+emBiCUQF9wQdzlzjQiQP0nHW ZM+v4for7oy6209ibJUVx1GdRhA5k57ETUg5q4rN1GZ+Xhyw0K8bcfQaDzDZuKef StG8xY1YpWSpEzDb7ra1jT2LTT+GRk/l1DKYsH58F1XURTn5Q9mcfWUpFFRVKjIP 6d1xG55xw4QnBfhcIs896o9EeYGAj0CI457Tzm+9NRSQHS4Ah1hAdYm3VqEHa9aI dEl707XOi7zQNU++RVGcdHXUy4MfsKlWWh9vltue57nsdSPaJ4JQtLA5Abd/XEYC mOGL5g== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cah4smbrc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Feb 2026 11:18:16 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb38a5dc3cso176205485a.3 for ; Mon, 16 Feb 2026 03:18:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771240696; x=1771845496; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=t2hNIzX5BNkAETmCDKWT6OzqUx76/RGNDM+ucplj4ws=; b=GZTGUIHjQnvWG5sDItFYBIQcYa1hZ2MZlf61HnLDeQebekm/MO50+dEM6W36WsN5MQ r34FM2HglreQ2biyaZrxKwA4k5fpP/ODf7+wfpWTbaXFou7zdl6i91FTGzbYcAICFMl4 MdEJdt/OZYW1M6YqjAs2cBpCOG1ZS3S2lzRfgBexHakNLKJeu9uoQU0mf29F6x8ae9+V aCZhKrsStWYc/20IXUo5dzuWEX+KU/I7FbpMSTYS5wjlDIs4q8k3jOdFM7cKvIyIjqkF wU2cjOLCQluDF64D++1D+REMq3pva3zG0a0kbg5nIkyGxNxIjYFxGkfzSfqtL78OJGxr UpRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771240696; x=1771845496; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t2hNIzX5BNkAETmCDKWT6OzqUx76/RGNDM+ucplj4ws=; b=BKRyMhExoKa57+X+Cg5MtvOllWbJKGHA8dAba2qRDSMkkm1zOnrdeUr6CaqUueVsQP t74l4ujlQtund78LvNeCfQYF+DAcySx/wsJiwrdjY/+D6OxqTxji5/+oS2gjDXNW7wJP 7Y4k7xhkxKgxfMLhBpRdvs6QNlPpseSjceVzHLK2o9wvrZqs60uj9waQ3o+w3YLnAg9D U6JMyOY/8TYOxEtCA/UisbnPHhnYF31sA2GAyrbNTgWhDgYVbcJ5z8hTP85GNBO9poPM ABQMJdXUqFPgQMVB5rx4Yr/QGwCw+eeSAn2FkuTquoDRetUzfEhtLQaP5rbdUdteTLEZ FAOg== X-Forwarded-Encrypted: i=1; AJvYcCVi9afQ2UOJYOqenBrJXr5uceqdqh6Gx3aAzHRAvc3kdjDzX254zS4+VHTNuTe84BkCch4inSe1x4sPwis=@vger.kernel.org X-Gm-Message-State: AOJu0YztzRVmS0pThPu2B2LhHGyokcfC3X30G5LncwNCWoWPVcex7GPL G/9GhGNtYOuzHXUDXf2hy7Y2hQazTMBgMFlji7doZwQbo6i9pMNUgZV/e9dstjDtK+Mc5sJcVk5 n1zTjM98VqMjLxxNW0MVRpq+goZJMxS+jeU4Fc0Av9p8B386jvyC/eGoYrQXYgCwxmSXruAOD7p c= X-Gm-Gg: AZuq6aIIbFrBk0kJOROuhoVpZXN3Q8Bxy0A9oxoIBykkcqDev3cEM9+pQI0N2kvOJDn hk0JthsXImustzd+OFf+fpQckMJdAEGH3giw4BIrKH+0MWVw/KIsC17tyZqtMikajaiB7DjExkW 0NvvRSaGsbRSCoahcC1y8ZthsLVG9KQsxJu8nUX6bAGVB7N76BA581qBbP6DR4s5ECo02/ipDWf CqAMkTrh20WzfFHtGfSc16fiMpiQsIDhWkXTTxedc1mN/Z+ikpPp2R/BNCu48wA6UeDJU09gopp 6JyV2prln0i9dQcaxTeMaMyLju1B8EtuEbrdEj9Nf6Ft8SBSiuhtudddeayd5+w4+JXUNOwA7lb G9lixwxSbv1tBMWJUe0bYEzvbm0vwM7NnLT4EDwwhh/ApGqE7+dks6hdX2zyezi1+BCswY2YjTs 1hSvo= X-Received: by 2002:a05:620a:4441:b0:8cb:1d7a:3f33 with SMTP id af79cd13be357-8cb4084bbe4mr1016713085a.4.1771240695603; Mon, 16 Feb 2026 03:18:15 -0800 (PST) X-Received: by 2002:a05:620a:4441:b0:8cb:1d7a:3f33 with SMTP id af79cd13be357-8cb4084bbe4mr1016709285a.4.1771240695011; Mon, 16 Feb 2026 03:18:15 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc7691c48sm248837566b.59.2026.02.16.03.18.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Feb 2026 03:18:14 -0800 (PST) Message-ID: Date: Mon, 16 Feb 2026 12:18:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree To: adamp@posteo.de, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260215-wiko-chuppito-v1-0-9ee6b89606a0@posteo.de> <20260215-wiko-chuppito-v1-3-9ee6b89606a0@posteo.de> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260215-wiko-chuppito-v1-3-9ee6b89606a0@posteo.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE2MDA5NSBTYWx0ZWRfX94SuM9H9OzY4 3EVDtK/+gllqjekpllqiTy61+3uh3NsdPRf8jc3DjRr1ydXojtZSU0R6n92k7N9kb39gWOYvBPK 4gXR4HdHm+Fqq2O6+8T5s2Bo6JaHaE5bOAWz5kuddhCsi+h+AHwyHrDvvewYNXGHr//I2nbU+kb gBGV7BBs/El3Gbd/jlt6PXbIgtW1b/O2o0qhhweunRzgNp6I56NZzSnn/bLRKWm3R5ZHihb+Phl DQnNIYnqU3zL8i3IZz++ooMndYUq81ho3MU0cVW0ZdQ0z2ezwKER5wqC8H1AWRLc/ICycZnhw/f 9SqwgkAKFkHspdQ3H3Lf4BBX6BF7g0hy48NrLRfyPHiLnkPfWY1KUbtsGtZqp3lhhfL5h49fJbz 1eLufnyH8npHVz3IgrxEtSJodyA9ZRU8uDEwycCjT+P9TlCDYFs0NYcNaCnnefcu3QRFDDfzzqZ mxhqMWDYVx9jOuMBPsw== X-Proofpoint-GUID: uvDvEmeSUpdXJHwWJsVNsmrQifQMBJgA X-Proofpoint-ORIG-GUID: uvDvEmeSUpdXJHwWJsVNsmrQifQMBJgA X-Authority-Analysis: v=2.4 cv=EbXFgfmC c=1 sm=1 tr=0 ts=6992fcf8 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=L2tLbZxQM9psbuxyGx8A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-16_04,2026-02-16_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 impostorscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602160095 On 2/15/26 9:02 PM, Paul Adam via B4 Relay wrote: > From: Paul Adam > > Add an initial device tree for Wiko PULP 4G. > Includes support for: > - UART > - USB (no OTG) > - Internal storage > - MicroSD > - Volume keys + Power button > - Touchscreen > - Backlight > - Accelerometer: Invensense MPU6880 > - Magnetometer: Asahi Kasei AK09911 > - Hall sensor: Rohm BU52021HFV > - Proximity sensor > - Vibrator > - Earpiece > - Microphone 1 > - Headphones > - Wifi > - Bluetooth > - GPU > > Signed-off-by: Paul Adam > --- Hello, just a couple comments below [...] > + chosen { > + stdout-path = "serial0"; > + }; > + backlight: backlight { Please add a \n above to separate these blocks > + compatible = "pwm-backlight"; > + pwms = <&pm8916_pwm 0 100000>; > + brightness-levels = <0 255>; > + num-interpolated-steps = <255>; > + default-brightness-level = <255>; > + enable-gpios = <&tlmm 119 GPIO_ACTIVE_HIGH>; > + pinctrl-0 = <&button_backlight_default>; > + pinctrl-1 = <&button_backlight_off>; > + pinctrl-names = "default", "off"; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-0 = <&gpio_keys_default>; > + pinctrl-names = "default"; > + label = "GPIO Buttons"; I think the GPIO prefix is unnecesary here and below > + > + button-volume-up { > + label = "Volume up"; > + gpios = <&tlmm 107 GPIO_ACTIVE_LOW>; > + linux,code = ; > + }; > + }; > + > + gpio-hall-sensor { > + compatible = "gpio-keys"; > + pinctrl-0 = <&gpio_hall_sensor_default>; > + pinctrl-names = "default"; > + label = "GPIO Hall Effect Sensor"; [...] > + proximity@48 { > + // downstream devicetree only specifies "stk,stk3x1x" > + compatible = "sensortek,stk3310"; Looks like the driver has a number of CHIP_IDs - you can be sure which chip specifically this is by printing it out [...] > +// make sure gcc is probed with display disabled. > +&gcc { > + clocks = <&xo_board>, <&sleep_clk>, <0>, <0>, <0>, <0>, <0>; > +}; Do things break if you remove this line? > + > +&gpu { > + status = "okay"; > +}; > + > +&mdss { > + status = "okay"; > +}; > + > +&mpss_mem { > + reg = <0x0 0x86800000 0x0 0x5600000>; > +}; > + > +&pm8916_l6 { > + regulator-always-on; Is there a reason for this? [...] > +&sound { > + audio-routing = > + "AMIC1", "MIC BIAS Internal1", Please unbreak this line after '=' Konrad