Re: [PATCH] drivers/media/pci/sta2x11: replace legacy GPIO APIs

[Song Chen <chensong_2000@189.cn>]

ok, then remove it.

what about drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c,
it has the same problem, are you going to remove it as well?

Song

在 2024/12/3 15:32, Arnd Bergmann 写道:
> On Tue, Dec 3, 2024, at 08:27, Song Chen wrote:
>> GPIO subsystem is moving toward a descriptor-based approach
>> from global GPIO numberspace, but some of legacy GPIO APIs
>> callings still remain in sta2x11.
>>
>> This patch mainly replaces gpio_request with gpiod_get_index
>> and removes including gpio.h.
>>
>> Signed-off-by: Song Chen <chensong_2000@189.cn>
>> ---
> 
> This is a step in the right direction, but realistically we
> should just remove this driver. I'm planning to send a patch
> to remove the sta2x11 platform from arch/x86 in a few days
> as we had discussed years ago but never actually done.
> 
>        Arnd
>