From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CAFA312826 for ; Wed, 10 Jun 2026 13:50:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781099418; cv=none; b=mf1KAPDTp3BvMm/dpVDF8KrS4vHtOf0kf3ub0jQYy47ImCSTZxrDQKFcYAFZDDBmicLi7q+sxwMEQCuJZoe4qxihZB0xHIph3n4tb3S4KYArTkU1EjBbiQ52iXO5t0Eo+9HGmVFvFGrm+4K5iG9rOFOpWYDqdUzN5JKehoynTz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781099418; c=relaxed/simple; bh=m1tGw26woFdfkPZTDBW7hW0NfQPofXVFfIcHxqyVtMw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LQCOUYgRy8eACSloj726DDlX9zZVQrabgAgQ5R10tRcQt7TlBF+hkgM0wOCT3cwDGAvZqy/wZ3/0lnqnOxrR8SCnKkv50/jaYg9DKE/rqOfmmE9FYTwDPKrtbSl8t6KmQYrPpAh+DcBlKJ1WfY4Gd+euRGTAedm/dbZlhCMhf78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=G+vkeQnV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=frQrIuke; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="G+vkeQnV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="frQrIuke" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65ACBdTg3763309 for ; Wed, 10 Jun 2026 13:50:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= O9+j/9QqiibbtkTIvcjHm7NyyCtGmfMJomJooe7wuxU=; b=G+vkeQnVe72weTGC g7FgPBXZmLHvDIHws+NRZL1bMFAxxNJx6hnT80CtXCqVoXm/mtgLCLOzBojyBKZ5 PANR7VltJ3lV8Z3VuB3IFWP8Ultnm3YueekmfkZ4Yhy49tdOIAR/48kEqnDlXjry +Cb0uMDy5AEDvCi6aEow9zUlKlEHEEB5P0iiG89yPCEEBUz5ARLOrEOi9SVazPzA S9xHLwPLlX6H02ggqgnEBh2nXUPy+k+EG0RcCB/OMVCEyKVykfr27IsbC31p8hfX W18Ig7oucRR9KKfgQdmCmLJdiNULD/QoafouERXUIUJ2eZNSGKi0IQhjVShKr2W6 uUL/dQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epwnetqrw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 13:50:16 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5177b12d7bbso12192181cf.1 for ; Wed, 10 Jun 2026 06:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781099416; x=1781704216; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=O9+j/9QqiibbtkTIvcjHm7NyyCtGmfMJomJooe7wuxU=; b=frQrIukeYuNpY5SHEL0zo5WG+T4+zo28s7wNY5ZIWVL5o3+U6tXwFQEfMvMSgGjNQC sHuf8wAMV6FAWatrLTb1u8Z0cFDqR5c0vAVJQC7GntmIO7ZJ/WZJoPznCn4RVfajXsQx iUvkhh0riBYFaXIxH0oYv6tzJq2xerEeTdXgvQGQ9p5XhUHV9a1Ghfv4CvA03TSUo5RC imNL49moBUuTLXHEs9IobBxQd8fw0VPaumVnjIYteecRvRZlJoQVKdRfiFPbIWlYFHVn FQ/aflQxOpHa2+3Dpmqpm4jCrwRMeX8iusMsr3AOIJQuw6FnpGKAySbiNrIlshu2Kthg Lsag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781099416; x=1781704216; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=O9+j/9QqiibbtkTIvcjHm7NyyCtGmfMJomJooe7wuxU=; b=RLoSqzIUN0v+ac8P238MRvHVV/CBFl0Nu+6lAt/nXUIWxNZt/j2f/fFsIZcVGFVOOG GOYNc8DR5Z4n53BS6roCJEM6kKlKsrT7BhMIF4SG0Brq71NipzfHYtOPcQkRVhDUgBHZ nTxKEYYv3ReSqByd67obiEVjCThaaPnyar7pBmtvehoJcq8IdOdJ0okKlzU0ijIIXzo6 F7B8WAVFY6gziaocjj816M+SAoBnIYeztQviU53OTFomjLpXleykUE3WAHlbh9WimARP eWfCWjDoAfcSo0g5XK0U6x3gAs0yf5888ZoWPzQZKhxqM6ececmV9+WHNDhPn/pDV819 WBAA== X-Forwarded-Encrypted: i=1; AFNElJ8PtnMDwzNeu+SrKLKUlw33EBO+pTtiQhX8vxjH6JavP2G5E/s0b0HB0HvTIjCI6VK+7BjxGSoAaT7yRgU=@vger.kernel.org X-Gm-Message-State: AOJu0YyuuG4wyAMSf8rm0EL937tYMFZ5gfKqNWo7xSjuwuJr7p/ZwduB PSFVtR91sq9ogi+X+qXvzWO/IrpMczRvt/bs1MWSUyQ5pgY2ANv7g35XqGQMFtoOrlnXT5yjtX5 u7+9I8aXgOfcLxuCI6dHGbQ7HGg/RUyygp/f24M0te4QvS1Ea0jtJ/uC6mvJ9ZAxMeF4= X-Gm-Gg: Acq92OGEjvVb9KqO+RuGllNLyU4OVgoZLFJLvdAFD/tj7LubSfpf9+s4N5eZM/runCE OY6KGQ0rNXLSiDPGUMpf7MaC6kMtzb2uybdaZFZap1Ne1PXmujHBPP6ah5CbeXjDubeZ4wUY/qX 6RsHqG2ow8NDkD97y4K4ApNUIzINI1K9vfijfVpv1ZUliYJojNhiggtoQ55Q8IKzNQKtXAnbGlq N6SJxGTXe2GTNk2bcCvQCaYMRObVETUVAXzkzU4/yELrdE5Sz7OeIYBfYp/643NrkCqN5hbaCRI oeySktAFbgfPaiZ+1JNWNi+5VFxv8CriGwegsq3ItAKdfyBvggnxh8oQzeMo7GgpCMS33DVzrHn 4cZ330FA+HIyIQiDkdP2kxrT/yZITL+viBPOenaSey9rdx0aM7ZVkYzgv X-Received: by 2002:ac8:5f50:0:b0:50b:5286:f757 with SMTP id d75a77b69052e-51795c1b7ffmr228447591cf.4.1781099415779; Wed, 10 Jun 2026 06:50:15 -0700 (PDT) X-Received: by 2002:ac8:5f50:0:b0:50b:5286:f757 with SMTP id d75a77b69052e-51795c1b7ffmr228447151cf.4.1781099415315; Wed, 10 Jun 2026 06:50:15 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf055303fc6sm1205291566b.42.2026.06.10.06.50.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 06:50:14 -0700 (PDT) Message-ID: Date: Wed, 10 Jun 2026 15:50:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/12] clk: qcom: gcc-mdm9607: Drop incorrect apss_tcu_clk_src To: Stephan Gerhold , Bjorn Andersson Cc: Michael Turquette , Stephen Boyd , Georgi Djakov , Shawn Guo , Bryan O'Donoghue , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260609-qcom-clk-mdm9607-fixes-v1-0-5e9717faf842@linaro.org> <20260609-qcom-clk-mdm9607-fixes-v1-7-5e9717faf842@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260609-qcom-clk-mdm9607-fixes-v1-7-5e9717faf842@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: tQpiUUyoMOCncgZ93XNNeKygLRqZ7W_l X-Authority-Analysis: v=2.4 cv=ebYNubEH c=1 sm=1 tr=0 ts=6a296b98 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=j8Cu_9a8AAAA:8 a=VwQbUJbxAAAA:8 a=Et88DFpTZsi3nXjlyzQA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=A2jcf3dkIZPIRbEE90CI:22 X-Proofpoint-ORIG-GUID: tQpiUUyoMOCncgZ93XNNeKygLRqZ7W_l X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDEzMiBTYWx0ZWRfXxt5Fwg+2Ej7w swyCpkaA6qACHcTM8+l+2T6OxfHhHaPvH0/v4lvnxmxacHeEPzotwAs+F9K2AinBkEQv1z6gfTh 6j6RmxZJzdyEWYJQgeHVr8MLbIW7R+D8sX52DYexLXA4MD/ZvyzXZUrBnUZujXUQyZ5Bzu5EWbg Ku6+xmzKEapCspixJ3r4sCay2KUlU5BLydPS6t5eN7VaYNzQOoRgt7l9MtGz382r364xXPNq5Lh c9QB58bXb0gdmSEEah9Re3jjY59C8JGqm03k/Mr/K7FaNgcGonGT0E4NFAMlu4JSiMyTqUaWT1o VW1Aruc1UAfGvxn+MnPiEUmxQ9/gPbd/kZkv5y0ZcsMjZwCsjiMuYp7mgnQxFXYKBe6dl0e8qjE zD3tF0SIxPVJnVxcNlaCJSNkTffwf3m2LsvYEOXIj2GjF+MUgKJ8nIWT/VqqtU/muW0dF8+UMZ/ 0rmXw24REOBynX0peHw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_03,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 spamscore=0 bulkscore=0 clxscore=1015 suspectscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100132 On 6/9/26 4:14 PM, Stephan Gerhold wrote: > From: Stephan Gerhold > > This clock does not seem to exist on MDM9607. Reading/writing the registers > always results in 0 or crashes. The math in the frequency table is also > broken. GPLL2 on MDM9607 runs at 480 MHz, so: > > - F(155000000, P_GPLL2, 6, 0, 0), // 480 MHz/6 = 80 MHz, not 155 MHz > - F(310000000, P_GPLL2, 3, 0, 0), // 480 MHz/3 = 160 MHz, not 310 MHz > > Presumably, this definition was mistakenly copied as-is from gcc-msm8916 > (which uses 930 MHz for GPLL2). There are no branch consumers of this root > clock inside gcc-mdm9607 (notably, gcc_apss_tcu_clk has bimc_ddr_clk_src as > parent instead of this clock), so we can just drop it. > > Cc: stable@vger.kernel.org > Fixes: 48b7253264ea ("clk: qcom: Add MDM9607 GCC driver") > Signed-off-by: Stephan Gerhold > --- It does, CMD_RCGR @ 0x37000 Interestingly, there's also an SMMU instance.. although downstream doesn't seem bothered with it Konrad