From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F06D30BBAB for ; Mon, 9 Feb 2026 08:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770626747; cv=none; b=OGUcbiTje+GQBF3IN66FJeolxEev0tPWUJPvLFCT322+z5nZ9gEiIJEPTU53MuGRD9b7vaWLrRJjNksh0Hnl4ehUxXSR9dNcNJKqmcMvylvE6QNSQLOs4yEBN9aWubaPRM7yXKDVZjD4j87KUIkbMMDSwGg4xbgcuR2hkN2Z8h8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770626747; c=relaxed/simple; bh=Mc/d/BijOjqO29N1HEQjWPn+Z1VbV+gB5KK51oU08Is=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gU4w/dk3VPlNbN3lo/g04Rw1GxbtPU6q29/e939bCo0v1PS56xsfTJUnVDNkuRw5i9IbpxCZeiwCR4j7WVxdcSr+1/zgiQoLpnrtECoBk6BOIXwtBvMYDnzBYX3O+hAYK32SLa6BcKdgonHeOGnve6RUL5cCNjVXWEhq8OvQ2LA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Nq/mnx5s; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nq/mnx5s" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-81dab89f286so2033482b3a.2 for ; Mon, 09 Feb 2026 00:45:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770626746; x=1771231546; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DmVyyltTZXCiISWlqL6e2pkka9bcBWHjYQjn85OjRHg=; b=Nq/mnx5s45girV61/fFzUn/LI/8qNMkKjM5U7EbYuw59LizoGJXzvBknjOWdmNXI6l fA9XRA8uLWe8lujgjm1kvGX6HoZxdxrUOmUreEl5iERiRjJWyIlX5SxL3NKfQcgGO6kN qVWd2Up3Vuv6ix1N2gdMxbV02+7wsR+6J72XQ9+uVY1emYxfFTrbSdVeG/z2LTdvRd7Q 6tflZF4ItRBvwefGwMRXk+1riknKvFeKBPf3H0LRGhSOn1C0dPRtQr8c9ngjpv6kRbbT 01/opxwhO7lFW3OjiSYA/3D3b3hDe/j2OcyOfdTmeMSPig47XueQnDkuRaWX+DRmUYdD lEXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770626746; x=1771231546; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DmVyyltTZXCiISWlqL6e2pkka9bcBWHjYQjn85OjRHg=; b=o/cLouq+E/BLCZKMugaSU+ilWUH35YUEYsZ23kFgaH4AjtO46piqBe40uwExyxuv0R zxcYJndsC+eS6uvEqYvV6Dl26DTBS/NTK8B3TdVy5tRoV9Ukq0mzeUvCIFbC69yvMv+D gXDmxvDaPreeIvTh5Ldk3Bv9Nk3syx+zTvA+ld3k1rleYyH00nUmnPl/KOAunmHRUf55 noLF0fAHwuSyBib8RhOLhIjirYTtEAzQ+L0PdeHj2mqgFfFrTmtOSzqQW25+2YbpM4Tw ctkeK9jvz5rXYUPvWi+5+DIrz8XQ2nsXoG8qrG+XsI2JUgTvu2pzPI6zXav+pF29yDa3 tg6g== X-Forwarded-Encrypted: i=1; AJvYcCVzXS7tqvHyca+InObvdZ6LlkG032LFfCxwmiRMDFpr0jbOHI+pG3dDml+wXndNiZsJBaX14SiUfL2Ent8=@vger.kernel.org X-Gm-Message-State: AOJu0YziYU7memGhDJIYPXgaEx4A5uirCbVXLxJzlrHA8TnmeSwRnHG2 ue+m5M41fJWTLHzUTybpHoAifoH5JLxvcQsVopLuoRjIH8UwLDlqUbXWfmG9MoRA X-Gm-Gg: AZuq6aIRnRErdKMobfykEqzWWDBvJBRab5wJECwmxi0CxZL0jZf+ebhReAT88YQZezO aIW73c4LtB6/xGMfbBSLUdDVFHqVbuiClJMn4r3juxbr3pD5iSZVJaU8an2KaGBXfnw7AZpNhTS uPu+6v5p4KioXJOzs2ZqX8igOpiOn+ga/dWUvDpnNS//C23LqX+YuRKc0PzPQPqfGRM5gEJTKlc eRih2pk4MiaDzi4fXMbQNvLPO9W+IIzeqnDImE7qB1v91hWNAT8xdY8F35YAFPyW/mebnDHFttC 7O8xMOa0yeOcmPG0vn/AoTHA0DIODTBqKMjrq8fAdf2InMaN2BKJ301/Yxsh82I8ZufPPC9qyrN 1tln51SZP83BK/Tg3Xa8P/f/i/CUxXx3d4yIsEVBdk9NZu9aRM6sqJXFFovGk+Gncinz2zCqZNK WDCU+l7qyIzxOjjuy+J1f+BwHOkFft5D54Gp6wERIHNXWGqmHV5XqwvxGkIr0OoZ/z X-Received: by 2002:a05:6a00:1949:b0:822:6830:5900 with SMTP id d2e1a72fcca58-82441609809mr8859019b3a.6.1770626746380; Mon, 09 Feb 2026 00:45:46 -0800 (PST) Received: from [192.168.0.100] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82441695f7dsm10130745b3a.23.2026.02.09.00.45.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Feb 2026 00:45:45 -0800 (PST) Message-ID: Date: Mon, 9 Feb 2026 16:45:40 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] drm/nuvoton: add MA35D1 display controller driver To: Icenowy Zheng , airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260129040532.382693-1-a0987203069@gmail.com> <20260129040532.382693-4-a0987203069@gmail.com> <8806eaf82fbef4cd51bb4e4bb44d60894b3504b4.camel@icenowy.me> Content-Language: en-US From: Joey Lu In-Reply-To: <8806eaf82fbef4cd51bb4e4bb44d60894b3504b4.camel@icenowy.me> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/6/2026 11:09 PM, Icenowy Zheng wrote: > 在 2026-01-29星期四的 12:05 +0800,Joey Lu写道: >> ========== 8< ============ >> +#endif >> diff --git a/drivers/gpu/drm/nuvoton/ma35_regs.h >> b/drivers/gpu/drm/nuvoton/ma35_regs.h >> new file mode 100644 >> index 000000000000..0f4a7a13e7d8 >> --- /dev/null >> +++ b/drivers/gpu/drm/nuvoton/ma35_regs.h >> @@ -0,0 +1,88 @@ >> +/* SPDX-License-Identifier: GPL-2.0+ */ >> +/* >> + * Nuvoton DRM driver >> + * >> + * Copyright (C) 2026 Nuvoton Technology Corp. >> + * >> + * Author: Joey Lu >> + */ >> + >> +#ifndef _MA35_REGS_H_ >> +#define _MA35_REGS_H_ >> + >> +#define MA35_FRAMEBUFFER_CONFIG                   0x1518 > Please check my Verisilicon DC8200 driver, which is already part of > drm-misc-next now. > > The display controller here seems to be a earlier one from > Verisilicon.it looks like a DC8000, or maybe a more earlier one? The DCU is a Vivante DCUltra IP rather than a DC8000 series. It's an earlier generation display controller and was customized for Nuvoton, so it doesn't have a public model ID. Because of that lineage, parts of the register layout and functionality remain similar to older DC IPs. Please refer to MA35D1 datasheet for more details. >> +#define MA35_FRAMEBUFFER_ADDRESS                  0x1400 >> +#define MA35_FRAMEBUFFER_STRIDE                   0x1408 >> +#define MA35_HDISPLAY                             0x1430 >> +#define MA35_HSYNC                                0x1438 >> +#define MA35_VDISPLAY                             0x1440 >> +#define MA35_VSYNC                                0x1448 >> +#define MA35_PANEL_CONFIG                         0x1418 >> +#define MA35_DPI_CONFIG                           0x14B8 >> +#define MA35_CURSOR_ADDRESS                       0x146C >> +#define MA35_CURSOR_CONFIG                        0x1468 >> +#define MA35_CURSOR_LOCATION                      0x1470 >> +#define MA35_CURSOR_BACKGROUND                    0x1474 >> +#define MA35_CURSOR_FOREGROUND                    0x1478 >> +#define MA35_FRAMEBUFFER_UPLANAR_ADDRESS          0x1530 >> +#define MA35_FRAMEBUFFER_VPLANAR_ADDRESS          0x1538 >> +#define MA35_FRAMEBUFFER_USTRIDE                  0x1800 >> +#define MA35_FRAMEBUFFER_VSTRIDE                  0x1808 >> +#define MA35_INDEXCOLOR_TABLEINDEX                0x1818 >> +#define MA35_INDEXCOLOR_TABLEDATA                 0x1820 >> +#define MA35_FRAMEBUFFER_SIZE                     0x1810 >> +#define MA35_FRAMEBUFFER_SCALEFACTORX             0x1828 >> +#define MA35_FRAMEBUFFER_SCALEFACTORY             0x1830 >> +#define MA35_FRAMEBUFFER_SCALEFCONFIG             0x1520 >> +#define MA35_HORIFILTER_KERNELINDEX               0x1838 >> +#define MA35_HORIFILTER_KERNEL                    0x1A00 >> +#define MA35_VERTIFILTER_KERNELINDEX              0x1A08 >> +#define MA35_VERTIFILTER_KERNEL                   0x1A10 >> +#define MA35_FRAMEBUFFER_INITIALOFFSET            0x1A20 >> +#define MA35_FRAMEBUFFER_COLORKEY                 0x1508 >> +#define MA35_FRAMEBUFFER_COLORHIGHKEY             0x1510 >> +#define MA35_FRAMEBUFFER_BGCOLOR                  0x1528 >> +#define MA35_FRAMEBUFFER_CLEARVALUE               0x1A18 >> +#define MA35_DISPLAY_INTRENABLE                   0x1480 >> +#define MA35_INT_STATE                            0x147C >> +#define MA35_PANEL_DEST_ADDRESS                   0x14F0 >> +#define MA35_MEM_DEST_ADDRESS                     0x14E8 >> +#define MA35_DEST_CONFIG                          0x14F8 >> +#define MA35_DEST_STRIDE                          0x1500 >> +#define MA35_DBI_CONFIG                           0x1488 >> +#define MA35_AQHICLOCKCONTROL                     0x0000 >> +#define MA35_OVERLAY_CONFIG                       0x1540 >> +#define MA35_OVERLAY_STRIDE                       0x1600 >> +#define MA35_OVERLAY_USTRIDE                      0x18C0 >> +#define MA35_OVERLAY_VSTRIDE                      0x1900 >> +#define MA35_OVERLAY_TL                           0x1640 >> +#define MA35_OVERLAY_BR                           0x1680 >> +#define MA35_OVERLAY_ALPHA_BLEND_CONFIG           0x1580 >> +#define MA35_OVERLAY_SRC_GLOBAL_COLOR             0x16C0 >> +#define MA35_OVERLAY_DST_GLOBAL_COLOR             0x1700 >> +#define MA35_OVERLAY_CLEAR_VALUE                  0x1940 >> +#define MA35_OVERLAY_SIZE                         0x17C0 >> +#define MA35_OVERLAY_COLOR_KEY                    0x1740 >> +#define MA35_OVERLAY_COLOR_KEY_HIGH               0x1780 >> +#define MA35_OVERLAY_ADDRESS                      0x15C0 >> +#define MA35_OVERLAY_UPLANAR_ADDRESS              0x1840 >> +#define MA35_OVERLAY_VPLANAR_ADDRESS              0x1880 >> +#define MA35_OVERLAY_SCALE_CONFIG                 0x1C00 >> +#define MA35_OVERLAY_SCALE_FACTOR_X               0x1A40 >> +#define MA35_OVERLAY_SCALE_FACTOR_Y               0x1A80 >> +#define MA35_OVERLAY_HORI_FILTER_KERNEL_INDEX     0x1AC0 >> +#define MA35_OVERLAY_HORI_FILTER_KERNEL           0x1B00 >> +#define MA35_OVERLAY_VERTI_FILTER_KERNEL_INDEX    0x1B40 >> +#define MA35_OVERLAY_VERTI_FILTER_KERNEL          0x1B80 >> +#define MA35_OVERLAY_INITIAL_OFFSET               0x1BC0 >> +#define MA35_GAMMA_EX_INDEX                       0x1CF0 >> +#define MA35_GAMMA_EX_DATA                        0x1CF8 >> +#define MA35_GAMMA_EX_ONE_DATA                    0x1D80 >> +#define MA35_GAMMA_INDEX                          0x1458 >> +#define MA35_GAMMA_DATA                           0x1460 >> +#define MA35_DISPLAY_DITHER_TABLE_LOW             0x1420 >> +#define MA35_DISPLAY_DITHER_TABLE_HIGH            0x1428 >> +#define MA35_DISPLAY_DITHER_CONFIG                0x1410 >> +#define MA35_DISPLAY_CURRENT_LOCATION             0x1450 >> + >> +#endif