From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1864334DCEC for ; Mon, 12 Jan 2026 10:53:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768215196; cv=none; b=tS/fDJvRL3RelQDk5s8PgPNfmhyGtIexzXA8gp2RqZxzGh/1GFORglOoIoy1pcUh+92r6FNr3SnZIAD2tKvl79z8xyw63pjPmSJJozn9ZJ0ymY66vH2V60BqOTtc7AeItloqRnCqdnIGE+SJ1tc5ctFet9RNRxSVXJKSV6Uv1iA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768215196; c=relaxed/simple; bh=rlpIv0ycJjkCAsKg+mMdi4WwvlUgHV7XC3sdtp0sf9g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CAsw4mT//QzC4zjkTDW1KM28/jjvq28Qmr0lvhGbSbiMCTD7suGofE0m4NrAonD4Kn95TIDpaiEa83LQW0qhnurvce4OJaKnqnduJeDEJT8L8B2nv3yEFIGPoQnaxk3XKaunwer1/prNkeV0kXPNaIuI7sWlFNh3AVB6bSmRXy4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KpialMrg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gj7rfta9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KpialMrg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gj7rfta9" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60C9F1dD1091976 for ; Mon, 12 Jan 2026 10:53:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OkgnGiPcXZE1+IL3sJO0MEHpll3AaDBeVk5e9Q9pCTw=; b=KpialMrgxgvEkQHP nFMg8Ih4zdclL8k4rCzcvKPx9G4OGDA6Ww1XrU5SlzrOmcM0wSNpkd7O00irHmSI Rcq24hYEaW97zNQFsSj2NV/ILL21pNcs/S+qhOmxUSZnUCVjfT6c/q1Uf2vqJTSE oCXqHPrcbHxa1ieQ4nM5yWUUGbupDJOjPUTwQ5Lrb8h1IxaitOMrUvDTWvi62kHL AsXEos1OX6qg9H/ecpnEM0diL5qFyNevv9/R27++p7UfVYlpN8fy6PNwC7Qj65GI sAApmQpNL5SMAFOxdieK6oPQM+bHHOf6YL+9uN622EamCLWD47cC63TuRIQc+K3m 8YxOHA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bmx5mg9p7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 12 Jan 2026 10:53:13 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ee05927183so11566501cf.0 for ; Mon, 12 Jan 2026 02:53:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768215193; x=1768819993; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OkgnGiPcXZE1+IL3sJO0MEHpll3AaDBeVk5e9Q9pCTw=; b=gj7rfta9y70gXKSlQksQ0mKPJvccIXW9dDu8Aeh0YF7SbLHKmECd65v6sdj/gs+RTk TA/sryyQox5hmF29LKEsEOD4usVGjOAorwMLjnyKvsKVKEgG4x72gmPheiLGbuAQMR7u ReLiuzduHoiTVxGMzsdtbc+88b2T/jRbaEBGP2WAvAOeRXFO5P0Gs1HnV1ixaew6z9iS UjZO0QOFhiN+q+xxn30kndtUT0hwNnyur3wqacF/rqKa551eBkzAY8thN2URr5jBMIkR mxxw3ZsX2oG9JPkZvPXBsKsBxTYpF3IKGE/JdVXC4r2jjXWVPxeXH52NxDjSrZ48kC1c h+hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768215193; x=1768819993; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OkgnGiPcXZE1+IL3sJO0MEHpll3AaDBeVk5e9Q9pCTw=; b=XmPVnIJWqgDcpv9ZzazBRgijzzMQj24QH8MtW+6yOyA4rQW1DOEf7qnOmebBHyamp5 7RpSgVHUnaW+JgDBftDSeIo1uT20DfbXLaSBigMWMEQpCpho4yYaLxtsektzFopMWffZ ENU4A0AwcyOEIPL2b1lOGllygsyt6R/hQIb5YS1QAfIN1f664mlREIbgc5K54NLiqNIS qIX2pkbu9y8vgl/TX5yK8Stt53Uruc8suIuTRd2mX4+PYD4gS2oXqrMC+mgQRmgo8UMb XIT8VldLNv5vvLj8OzlCeSZVjXKcqbW9i8iGSQjfeRccH1Oc4s7q+Zqo3aKebG3xvdbB 5J2w== X-Forwarded-Encrypted: i=1; AJvYcCWWPOpiYZcqJtMZwdSdxkrLvKej4x1iwSNzBis8cZjYyx1BFGUI6EbNR86a7X+XYAMA8hJHeQZybTyyN+k=@vger.kernel.org X-Gm-Message-State: AOJu0YzS++4NHnItoX+Ls5Yys1yV6dL2lco9+aBKbvRdkv0J4pH4kbsH XvWWVAcItFK2KeGskd+LquKB3BTFPmMsIdvId7kSUk8Lzmlxdck1u/WzMQe89KHW1xlcGRVFdFx lrTKVj/0OWiz0IXQod9ybm9EVAK7uDTyb2+t3OqbM8ZoD225zFEHsiQ0G7/ZKFm5ShYE= X-Gm-Gg: AY/fxX6XIMinhZd3BiF/W0Mq6W/3k5fkzP3J92umzEl3NCMkv+ltqY7J07W+Y1bvmVU PanKDHLeO5RyeMnmXWOr8Ns0h4KYg5M4FB+OaRHI+Ixvb1pDkA81WtIEFDzpktfpkw4VdL4SB/s 6bs0NySzZxzPnURlLmMbvVbMbenmGWGWWfqP5Cp+PhGPyrXMWBHcUhkDFWZTC88o2NzCzvMQ/Vb gMwu/03jfxGndX8uT33lQR+jyjeydX2NDNt0/6ia+5oLkV7zwySLYZykUNW4WM5NQaAcbyUTpyo Yac355hUgWYqCZxiFxopuyG9Xtg9MvMcrBuz6Z02IEXYcZGULPurj6tqtTB8UpHtrdmExcnRz/C L4JurgyTxJDvUqxuk+8PWx6099ZX9SRxyYc6duu6Wf+jwlmKoW5O/SyP4265yGUcmoo0= X-Received: by 2002:a05:622a:282:b0:4ed:b7f0:c76e with SMTP id d75a77b69052e-4ffb4a3ff5cmr192922021cf.8.1768215193413; Mon, 12 Jan 2026 02:53:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IEBBDe3WY5BWTxclmarfUgDXSl0bKvw604XZyLa/A/MdaMvkOzX7Nt+RyRpTimruxD4LgaGDw== X-Received: by 2002:a05:622a:282:b0:4ed:b7f0:c76e with SMTP id d75a77b69052e-4ffb4a3ff5cmr192921841cf.8.1768215193033; Mon, 12 Jan 2026 02:53:13 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507be65197sm17379733a12.19.2026.01.12.02.53.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jan 2026 02:53:12 -0800 (PST) Message-ID: Date: Mon, 12 Jan 2026 11:53:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] arm64: dts: qcom: Add support for ECS LIVA QC710 To: Val Packett , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260111085726.634091-2-val@packett.cool> <20260111085726.634091-6-val@packett.cool> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260111085726.634091-6-val@packett.cool> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEyMDA4NiBTYWx0ZWRfX8mmyaa87+4Kf htPX9MPb3boJ9Z+/mfHLTnzC5cL6/h78V/eytP6ua4LbLQnoPWeVG1Ln2TPg9PZXUFZ1tLI2dDg g2Nv7CZWBpVR0RE7l9X3fPj1hOMpqM518WF7R89C3pbYjAw2dZNKsEdlsL8PlB+bmlWQr/yoP3Y f72EORTWQB5vFz/XnVqNqZi3+HwGl9b14XZaJJ8bRku5t9fZIK7Dz+LOAlOHpgBru/vsvl2widG yNY3+kuCafl2UOHMReH6bM+286oY959QT+5bhcgPC699Y0PcFwUt/74xhg4fTecN/KSAR6WJdqC URCc+mkZ6dUEtPkLHEIJBujBMpuyZn5ow7Fc+ZGfsSuMndJ6evHedK2oIVdkkzZ7Wy6gbwBScot qR6zc4FqhJcgcbhA1Iw3VORvUoXmDxHLDCVDPr3o18eIWf2vxHQA3wqVG7g/0NEdC9lI9l79EZZ tJDVyNp3iEzoEh8YT/Q== X-Proofpoint-ORIG-GUID: L0agJQ1ZvOxp71-kufvjtYn1O3j9RQYg X-Proofpoint-GUID: L0agJQ1ZvOxp71-kufvjtYn1O3j9RQYg X-Authority-Analysis: v=2.4 cv=Q8zfIo2a c=1 sm=1 tr=0 ts=6964d299 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=GqzvmWBP9S_r8vv4g3cA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-12_03,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 spamscore=0 priorityscore=1501 phishscore=0 malwarescore=0 adultscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601120086 On 1/11/26 9:35 AM, Val Packett wrote: > Add a device tree for the ECS LIVA QC710 (Snapdragon 7c) mini PC/devkit. [...] > +&mdss_dp { > + pinctrl-names = "default"; > + pinctrl-0 = <&dp_hot_plug_det>; please keep the order of: property-n property-names throughout the file [...] > +&remoteproc_adsp { > + memory-region = <&adsp_mem>; > + firmware-name = "qcom/sc7180/ecs/liva-qc710/qcadsp7180.mbn"; > + status = "okay"; And a consistent \n before 'status' [...] > +&usb_1_dwc3 { > + dr_mode = "host"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + hub@1 { > + compatible = "usb5e3,608"; > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + r8152: ethernet@4 { You don't need this label > + compatible = "usbbda,8152"; > + reg = <4>; > + }; > + }; > +}; > + > +&usb_1_hsphy { > + vdd-supply = <&vreg_l4a_0p8>; > + vdda-pll-supply = <&vreg_l11a_1p8>; > + vdda-phy-dpdm-supply = <&vreg_l17a_3p0>; > + qcom,imp-res-offset-value = <8>; > + qcom,preemphasis-level = ; > + qcom,preemphasis-width = ; > + qcom,bias-ctrl-value = <0x22>; > + qcom,charge-ctrl-value = <3>; > + qcom,hsdisc-trim-value = <0>; Have you verified these values (e.g. by reading back the related registers in Windows)? [...] > +&apps_rsc { > + regulators-0 { > + compatible = "qcom,pm6150-rpmh-regulators"; > + qcom,pmic-id = "a"; > + > + vreg_s1a_1p1: smps1 { > + regulator-min-microvolt = <1128000>; > + regulator-max-microvolt = <1128000>; > + }; Similarly, have you verified these? > + soc_bkoff_default: soc-bkoff-deault-state { > + pins = "gpio10"; > + function = "gpio"; > + drive-strength = <16>; > + bias-disable; > + }; This entry is unused Konrad