From: Dinh Nguyen <dinguyen@kernel.org>
To: Rounak Das <rounakdas2025@gmail.com>
Cc: bp@alien8.de, tony.luck@intel.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCHv4 3/4] EDAC/altera: Fix code leak on dci allocation failure
Date: Wed, 9 Sep 2026 09:36:03 -0500 [thread overview]
Message-ID: <f5636589-1d1b-4b64-9e82-cf4b249ebef8@kernel.org> (raw)
In-Reply-To: <CAPYTKoOmFpCzw5EydwxRdq3LhKP6p+osY=gxvy+KOZWQsXu-qg@mail.gmail.com>
On 9/9/26 09:33, Rounak Das wrote:
> Hi Dinh,
>
>> if (!devres_open_group(device->edac->dev, altr_portb_setup, GFP_KERNEL))
>> + edac_device_free_ctl_info(dci);
>> return -ENOMEM;
>> + }
>
> This file will not compile since the braces are wrong, there is no starting {.
>
> Also, another thing that I noticed is that 2/4's Fixes tag is missing
> its closing
> quote after "probe()".
Argh..Thank you for catching that!
>
> I will rebase and resend my of_node_put fix once this series lands.
>
Dinh
next prev parent reply other threads:[~2026-09-09 14:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 13:12 [PATCHv4 0/4] EDAC/altera: Address sashiko reviews part 1(v4) Dinh Nguyen
2026-09-09 13:12 ` [PATCHv4 1/4] EDAC/altera: Do not allow driver unbinding Dinh Nguyen
2026-09-09 13:12 ` [PATCHv4 2/4] EDAC/altera: Drop __init from ECC setup paths for re-probe safety Dinh Nguyen
2026-09-09 13:12 ` [PATCHv4 3/4] EDAC/altera: Fix code leak on dci allocation failure Dinh Nguyen
2026-09-09 14:33 ` Rounak Das
2026-09-09 14:36 ` Dinh Nguyen [this message]
2026-09-09 13:12 ` [PATCHv4 4/4] EDAC/altera: Fix use-after-free in error paths Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5636589-1d1b-4b64-9e82-cf4b249ebef8@kernel.org \
--to=dinguyen@kernel.org \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rounakdas2025@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®