mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Bart Van Assche <bvanassche@acm.org>,
	Chaitanya Kulkarni <chaitanyak@nvidia.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
	"damien.lemoal@opensource.wdc.com"
	<damien.lemoal@opensource.wdc.com>,
	"johannes.thumshirn@wdc.com" <johannes.thumshirn@wdc.com>,
	"ming.lei@redhat.com" <ming.lei@redhat.com>,
	"shinichiro.kawasaki@wdc.com" <shinichiro.kawasaki@wdc.com>,
	"vincent.fu@samsung.com" <vincent.fu@samsung.com>,
	"yukuai3@huawei.com" <yukuai3@huawei.com>
Subject: Re: [PATCH V2 4/7] null_blk: don't use magic numbers in the code
Date: Tue, 15 Nov 2022 03:49:35 +0000	[thread overview]
Message-ID: <f563e7d4-6409-5571-9cba-045c1e42d5f9@nvidia.com> (raw)
In-Reply-To: <475fba10-c471-4922-91d5-3b84c4cce149@acm.org>

On 11/14/22 16:40, Bart Van Assche wrote:
> On 10/5/22 20:18, Chaitanya Kulkarni wrote:
>> Insteasd of using the hardcoded value use meaningful macro for tag
> 
> Insteasd -> Instead?
> 
>> available value of -1U in get_tag() and __alloc_cmd().
>>
>> While at it return early on error to get rid of the extra indentation
>> in __alloc_cmd().
> 
> Thanks,
> 
> Bart.
> 

thanks for your comment Bart, I'll send out V3 with fixes..

-ck


  reply	other threads:[~2022-11-15  3:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06  3:18 [PATCH V2 0/7] null_blk: allow REQ_OP_WRITE_ZEROES and cleanup Chaitanya Kulkarni
2022-10-06  3:18 ` [PATCH V2 1/7] null_blk: allow REQ_OP_WRITE_ZEROES Chaitanya Kulkarni
2022-10-06  3:18 ` [PATCH V2 2/7] null_blk: code cleaup Chaitanya Kulkarni
2022-10-06  3:18 ` [PATCH V2 3/7] null_blk: initialize cmd->bio in __alloc_cmd() Chaitanya Kulkarni
2022-11-15  0:39   ` Bart Van Assche
2022-10-06  3:18 ` [PATCH V2 4/7] null_blk: don't use magic numbers in the code Chaitanya Kulkarni
2022-11-15  0:40   ` Bart Van Assche
2022-11-15  3:49     ` Chaitanya Kulkarni [this message]
2022-10-06  3:18 ` [PATCH V2 5/7] null_blk: remove extra space in switch condition Chaitanya Kulkarni
2022-10-06  3:18 ` [PATCH V2 6/7] null_blk: add param to set max disacrd sectors Chaitanya Kulkarni
2022-10-06  3:18 ` [PATCH V2 7/7] null_blk: add param to set max write-zeroes sects Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f563e7d4-6409-5571-9cba-045c1e42d5f9@nvidia.com \
    --to=chaitanyak@nvidia.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=vincent.fu@samsung.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®