From: Krzysztof Kozlowski <krzk@kernel.org>
To: Suraj Gupta <suraj.gupta2@amd.com>,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, michal.simek@amd.com,
sean.anderson@linux.dev, radhey.shyam.pandey@amd.com,
horms@kernel.org
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, git@amd.com,
harini.katakam@amd.com
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: xlnx,axi-ethernet: Add bindings for AXI 2.5G MAC
Date: Tue, 19 Nov 2024 08:42:59 +0100 [thread overview]
Message-ID: <f5694621-2abb-4637-9826-97e7bde88b72@kernel.org> (raw)
In-Reply-To: <20241118081822.19383-2-suraj.gupta2@amd.com>
On 18/11/2024 09:18, Suraj Gupta wrote:
> AXI 1G/2.5G Ethernet subsystem supports 1G and 2.5G speeds. "max-speed"
> property is used to distinguish 1G and 2.5G MACs of AXI 1G/2.5G IP.
> max-speed is made a required property, and it breaks DT ABI but driver
> implementation ensures backward compatibility and assumes 1G when this
> property is absent.
> Modify existing bindings description for 2.5G MAC.
>
> Signed-off-by: Suraj Gupta <suraj.gupta2@amd.com>
Please start using b4. This thread is a mess.
Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets.
<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.
Please kindly resend and include all necessary To/Cc entries.
</form letter>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-19 7:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 8:18 [PATCH net-next 0/2] Add support for AXI 2.5G ethernet Suraj Gupta
2024-11-18 8:18 ` [PATCH net-next 1/2] dt-bindings: net: xlnx,axi-ethernet: Add bindings for AXI 2.5G MAC Suraj Gupta
2024-11-18 15:36 ` Sean Anderson
2024-11-18 15:54 ` Maxime Chevallier
2024-11-18 15:57 ` Sean Anderson
2024-11-19 1:38 ` Andrew Lunn
2024-11-19 9:40 ` Gupta, Suraj
2024-11-19 13:38 ` Andrew Lunn
2024-11-19 7:42 ` Krzysztof Kozlowski [this message]
2024-11-18 8:18 ` [PATCH net-next 2/2] net: axienet: Add support " Suraj Gupta
2024-11-18 14:42 ` Pandey, Radhey Shyam
2024-11-18 15:56 ` Russell King (Oracle)
2024-11-18 16:00 ` Sean Anderson
2024-11-18 16:08 ` Russell King (Oracle)
2024-11-19 10:28 ` Gupta, Suraj
2024-11-19 13:18 ` Russell King (Oracle)
2024-11-19 15:12 ` Russell King (Oracle)
2024-11-19 1:35 ` Andrew Lunn
2024-11-19 15:26 ` Sean Anderson
2024-11-19 15:49 ` Russell King (Oracle)
2024-11-19 16:42 ` Sean Anderson
2025-02-20 11:30 ` Gupta, Suraj
2025-02-20 11:44 ` Russell King (Oracle)
2025-02-20 12:17 ` Gupta, Suraj
2025-02-20 14:35 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5694621-2abb-4637-9826-97e7bde88b72@kernel.org \
--to=krzk@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=harini.katakam@amd.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=sean.anderson@linux.dev \
--cc=suraj.gupta2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®