From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758646AbXGVPdb (ORCPT ); Sun, 22 Jul 2007 11:33:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752537AbXGVPdY (ORCPT ); Sun, 22 Jul 2007 11:33:24 -0400 Received: from py-out-1112.google.com ([64.233.166.183]:62984 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbXGVPdW (ORCPT ); Sun, 22 Jul 2007 11:33:22 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=CH8DjLPxvqLrcSjDhZ6sYXr9rsX+mZLyS9+sdG5hLNVI1+4n98y4n2AB3KKz17Z9X76Q9zvyIQtgj6JfBd4Lbu6mhpkoNqFMFKg7wUmQ29TY2inQqmnkiStx71kEKqxcpdbdI/g4AG+FU9Vm1lHTYGgXUgbKMW/5+ceI5hxTJP0= Message-ID: Date: Sun, 22 Jul 2007 11:33:21 -0400 From: "=?ISO-8859-1?Q?C=E9dric_Augonnet?=" To: "Gabriel C" Subject: Re: voyager_{thread,cat}.c compile warnings Cc: "Linux Kernel Mailing List" In-Reply-To: <46A282B2.8070501@googlemail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_102398_1722779.1185118401216" References: <46A282B2.8070501@googlemail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org ------=_Part_102398_1722779.1185118401216 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi, 2007/7/21, Gabriel C : > Hi, > > I noticed this warnings on current git: > > > ... > > arch/i386/mach-voyager/voyager_thread.c: In function 'thread': > arch/i386/mach-voyager/voyager_thread.c:113: warning: no return statement= in function returning non-void > > ... > > I think return 0; is missing on line 112 here. > I guess there is no use in always returning 0, simply not returning anythin= g and putting a void type might be cleaner, especially as this function seems to never return. > > arch/i386/mach-voyager/voyager_cat.c: In function 'voyager_cat_init': > arch/i386/mach-voyager/voyager_cat.c:685: warning: comparison is always f= alse due to limited range of data type > arch/i386/mach-voyager/voyager_cat.c:755: warning: comparison is always f= alse due to limited range of data type > Hum perhaps it does not like the comparision of a __u16 and an unsigned int= ? I enclose some dummy patch that should perhaps solve these issues, could not test it as i don't have the hardware... just my 2 cents. Don't know if casting is an acceptable workaround though. > > > Regards, > > Gabriel C > Cheers, C=E9dric ------=_Part_102398_1722779.1185118401216 Content-Type: text/x-diff; name=voyager.patch; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_f4fouwxm Content-Disposition: attachment; filename="voyager.patch" U3VibWl0dGVkIGJ5OiBDZWRyaWMgQXVnb25uZXQgPGNlZHJpYy5hdWdvbm5ldEBlbnMtbHlvbi5v cmc+Ci0tLQpkaWZmIC11ck4gYS9hcmNoL2kzODYvbWFjaC12b3lhZ2VyL3ZveWFnZXJfY2F0LmMg Yi9hcmNoL2kzODYvbWFjaC12b3lhZ2VyL3ZveWFnZXJfY2F0LmMKLS0tIC9ob21lL2dvbm5ldC90 bXAvbGludXgtMi42LjIyL2FyY2gvaTM4Ni9tYWNoLXZveWFnZXIvdm95YWdlcl9jYXQuYwkyMDA3 LTA3LTIwIDExOjUwOjE3LjAwMDAwMDAwMCAtMDQwMAorKysgbGludXgtMi42LjIyL2FyY2gvaTM4 Ni9tYWNoLXZveWFnZXIvdm95YWdlcl9jYXQuYwkyMDA3LTA3LTIyIDExOjI0OjM0LjAwMDAwMDAw MCAtMDQwMApAQCAtNjgyLDcgKzY4Miw3IEBACiAJCQlvdXRiKFZPWUFHRVJfQ0FUX0VORCwgQ0FU X0NNRCk7CiAJCQljb250aW51ZTsKIAkJfQotCQlpZihlcHJvbV9zaXplID4gc2l6ZW9mKGVwcm9t X2J1ZikpIHsKKwkJaWYoKHVuc2lnbmVkKWVwcm9tX3NpemUgPiBzaXplb2YoZXByb21fYnVmKSkg ewogCQkJcHJpbnRrKCIqKldBUk5JTkcqKjogVm95YWdlciBpbnN1ZmZpY2llbnQgc2l6ZSB0byBy ZWFkIEVQUk9NIGRhdGEsIG1vZHVsZSAweCV4LiAgTmVlZCAlZFxuIiwgaSwgZXByb21fc2l6ZSk7 CiAJCQlvdXRiKFZPWUFHRVJfQ0FUX0VORCwgQ0FUX0NNRCk7CiAJCQljb250aW51ZTsKQEAgLTc1 Miw3ICs3NTIsNyBAQAogCQkJb3V0YihWT1lBR0VSX0NBVF9FTkQsIENBVF9DTUQpOwogCQkJY29u dGludWU7CiAJCX0KLQkJaWYoZXByb21fc2l6ZSA+IHNpemVvZihlcHJvbV9idWYpKSB7CisJCWlm KCh1bnNpZ25lZCllcHJvbV9zaXplID4gc2l6ZW9mKGVwcm9tX2J1ZikpIHsKIAkJCXByaW50aygi KipXQVJOSU5HKio6IFZveWFnZXIgaW5zdWZmaWNpZW50IHNpemUgdG8gcmVhZCBFUFJPTSBkYXRh LCBtb2R1bGUgMHgleC4gIE5lZWQgJWRcbiIsIGksIGVwcm9tX3NpemUpOwogCQkJb3V0YihWT1lB R0VSX0NBVF9FTkQsIENBVF9DTUQpOwogCQkJY29udGludWU7CmRpZmYgLXVyTiBhL2FyY2gvaTM4 Ni9tYWNoLXZveWFnZXIvdm95YWdlcl90aHJlYWQuYyBiL2FyY2gvaTM4Ni9tYWNoLXZveWFnZXIv dm95YWdlcl90aHJlYWQuYwotLS0gL2hvbWUvZ29ubmV0L3RtcC9saW51eC0yLjYuMjIvYXJjaC9p Mzg2L21hY2gtdm95YWdlci92b3lhZ2VyX3RocmVhZC5jCTIwMDctMDctMjAgMTE6NTA6MTcuMDAw MDAwMDAwIC0wNDAwCisrKyBsaW51eC0yLjYuMjIvYXJjaC9pMzg2L21hY2gtdm95YWdlci92b3lh Z2VyX3RocmVhZC5jCTIwMDctMDctMjIgMTE6Mjc6MTMuMDAwMDAwMDAwIC0wNDAwCkBAIC05Miw3 ICs5Miw3IEBACiAJfQogfQogCi1zdGF0aWMgaW50CitzdGF0aWMgdm9pZAogdGhyZWFkKHZvaWQg KnVudXNlZCkKIHsKIAlwcmludGsoS0VSTl9OT1RJQ0UgIlZveWFnZXIgc3RhcnRpbmcgbW9uaXRv ciB0aHJlYWRcbiIpOwo= ------=_Part_102398_1722779.1185118401216--