From: Jan Kiszka <jan.kiszka@siemens.com>
To: Tobias Waldekranz <tobias@waldekranz.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/gdb: relax requirement on symlink location
Date: Mon, 17 Oct 2016 17:45:04 +0200 [thread overview]
Message-ID: <f5707bef-a9d9-080c-e30b-814fccd7dce7@siemens.com> (raw)
In-Reply-To: <20161014100700.GA9188@gmail.com>
On 2016-10-14 12:07, Tobias Waldekranz wrote:
> The current construct for inserting the `scripts/gdb/` directory into
> the python path requires `vmlinux-gdb.py` to be symlinked in the root of
> the kernel build tree.
>
> By first resolving the symlink and inserting that path, the symlink can
> be placed in an arbitrary directory.
Can you provide a brief word on what this would enable (i.e. why we want
it)?
>
> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
> ---
> scripts/gdb/vmlinux-gdb.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/gdb/vmlinux-gdb.py b/scripts/gdb/vmlinux-gdb.py
> index ce82bf5..a9029f4 100644
> --- a/scripts/gdb/vmlinux-gdb.py
> +++ b/scripts/gdb/vmlinux-gdb.py
> @@ -13,7 +13,7 @@
>
> import os
>
> -sys.path.insert(0, os.path.dirname(__file__) + "/scripts/gdb")
> +sys.path.insert(0, os.path.dirname(os.path.realpath(__file__)))
>
> try:
> gdb.parse_and_eval("0")
>
Unfortunately, this breaks with modules that are generated, namely
constants.py. They are located in the build dir. Please suggest a
version that was tested successfully against both the existing and the
new use case.
Thanks,
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2016-10-17 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 10:07 Tobias Waldekranz
2016-10-17 15:45 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5707bef-a9d9-080c-e30b-814fccd7dce7@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tobias@waldekranz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®