From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C1522C08AD for ; Fri, 20 Mar 2026 10:31:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774002669; cv=none; b=Gh8DR4/dZnKE1/4xnvq0xuEq2hBdPzeIxHOsl+Y92b1f4gUqTV/1PkPfNQ95SE65VZv2Ez2IzcEM67QDWckdjDtaL/T5XTSwAl+oD+G/OmzKa0JNuiLN+OiyNPHslrmECvrqMYsm1JXjrhxRMPTMfF0yMkr87XGHOkZGABUkllA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774002669; c=relaxed/simple; bh=DYfUGB5UttLK7CI+1GFRQCWa2kXPekeiiS/8rxW8Iis=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ebgKCBefo7mS47WkI/eqzR6JVsw90K6vW5NvlBnfVm7g9RQoZsixshTI3j9Yttwx3P9/8yMdL3RlTFOPUltHOCsStsKzFK2IBNrCKU5BsSQ7LXd30iPOg3om6CRAo+ARH9sB7gClwIZkujSgOZLwtsR+f99QM9xo8/IXuVGYyUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w3X88-0006ot-B1; Fri, 20 Mar 2026 11:31:00 +0100 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w3X87-001E37-32; Fri, 20 Mar 2026 11:30:59 +0100 Received: from pza by lupine with local (Exim 4.98.2) (envelope-from ) id 1w3X87-000000005hA-3dGH; Fri, 20 Mar 2026 11:30:59 +0100 Message-ID: Subject: Re: [PATCH v2] i3c: master: dw-i3c: Fix missing reset assertion in remove() callback From: Philipp Zabel To: Felix Gu , Alexandre Belloni , Frank Li , Aniket Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 20 Mar 2026 11:30:59 +0100 In-Reply-To: <20260317-dw-i3c-v2-1-fa57e6394b1d@gmail.com> References: <20260317-dw-i3c-v2-1-fa57e6394b1d@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Di, 2026-03-17 at 01:48 +0800, Felix Gu wrote: > The reset line acquired during probe is currently left deasserted when > the driver is unbound. >=20 > Switch to devm_reset_control_get_optional_exclusive_deasserted() to > ensure the reset is automatically re-asserted by the devres core when > the driver is removed. >=20 > Fixes: 62fe9d06f570 ("i3c: dw: Add power management support") > Signed-off-by: Felix Gu > --- > Changes in v2: > - Switch to devm_reset_control_get_optional_exclusive_deasserted()=20 > suggested by Philipp Zabel. > - Link to v1: https://lore.kernel.org/r/20260316-dw-i3c-v1-1-ab41904fc780= @gmail.com > --- > drivers/i3c/master/dw-i3c-master.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i= 3c-master.c > index d87bde3f7700..f3dabd8d1225 100644 > --- a/drivers/i3c/master/dw-i3c-master.c > +++ b/drivers/i3c/master/dw-i3c-master.c > @@ -1606,13 +1606,11 @@ int dw_i3c_common_probe(struct dw_i3c_master *mas= ter, > if (IS_ERR(master->pclk)) > return PTR_ERR(master->pclk); > =20 > - master->core_rst =3D devm_reset_control_get_optional_exclusive(&pdev->d= ev, > - "core_rst"); > + master->core_rst =3D devm_reset_control_get_optional_exclusive_deassert= ed( > + &pdev->dev, "core_rst"); + master->core_rst =3D devm_reset_control_get_optional_exclusive_deasserted= (&pdev->dev, + "core_rst"); to make checkpatch --strict happy. Otherwise, Reviewed-by: Philipp Zabel regards Philipp