From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D98C77B60 for ; Wed, 26 Apr 2023 21:36:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239740AbjDZVgq (ORCPT ); Wed, 26 Apr 2023 17:36:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233181AbjDZVgm (ORCPT ); Wed, 26 Apr 2023 17:36:42 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 342431708 for ; Wed, 26 Apr 2023 14:36:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682545001; x=1714081001; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=wL8wMUykqXBicX84t13KYsITD+w3aIM/UR1X6YZVjPg=; b=iaRzrF8stuxgJ4NkzxU0NX7Od4dCVZG5SaMjHajKqlPBCmV8VmfeZBTC i6fpApArzphVJAC8qZmOsZ9y3dAvLIsAqCvLTO7OsT6POkJyUeezTSS/9 RpBRluFUaeSUeyxJDGnIm3eAD0Q6g9+Jd4yl0JHerRRyeNcsKH5aXjjkY D3z1zKDNISQcMMXf99Voci0II18K51HC+vyU7hvQFe9//Iov0V7Sc+x4w T7F5hHFUmzJl0s+8COag2kgT0uIXx9TkVE4B4tM/a7NYjt1EUiPfsJnYK Z6EhzOKaKL/jjnrMUI2YrTLm7SrAeT7+PfJiJW/nbz62Z0A60TwgOAfR3 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="346000686" X-IronPort-AV: E=Sophos;i="5.99,229,1677571200"; d="scan'208";a="346000686" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2023 14:36:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="724615398" X-IronPort-AV: E=Sophos;i="5.99,229,1677571200"; d="scan'208";a="724615398" Received: from ahajda-mobl.ger.corp.intel.com (HELO [10.213.8.187]) ([10.213.8.187]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2023 14:36:38 -0700 Message-ID: Date: Wed, 26 Apr 2023 23:36:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.10.0 Subject: Re: [PATCH v7 0/2] drm/i915: Hugepage manager and test for MTL Content-Language: en-US To: "Cavitt, Jonathan" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "Auld, Matthew" References: <20230425-hugepage-migrate-v7-0-fa6605a986c9@intel.com> From: Andrzej Hajda Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.04.2023 17:31, Cavitt, Jonathan wrote: > -----Original Message----- > From: Hajda, Andrzej > Sent: Wednesday, April 26, 2023 8:14 AM > To: intel-gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org; Cavitt, Jonathan ; Hajda, Andrzej ; Auld, Matthew > Subject: [PATCH v7 0/2] drm/i915: Hugepage manager and test for MTL >> This patchset patches sent by Jonathan and Andi, with >> addressed CI failures: >> 1. Fixed checking alignment of 64K pages on both Pre-Gen12 and Gen12. >> 2. Fixed start alignment of 2M pages. >> >> Regards >> Andrzej >> >> Jonathan Cavitt (2): >> drm/i915: Migrate platform-dependent mock hugepage selftests to live >> drm/i915: Use correct huge page manager for MTL >> >> .../gpu/drm/i915/gem/selftests/huge_pages.c | 88 +++++++++++++++---- >> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 +- >> 2 files changed, 71 insertions(+), 20 deletions(-) >> >> Cc: intel-gfx@lists.freedesktop.org >> Cc: linux-kernel@vger.kernel.org >> Cc: Jonathan Cavitt >> Cc: Andrzej Hajda >> Cc: Matthew Auld >> -- >> 2.39.2 >> >> --- >> Jonathan Cavitt (2): >> drm/i915: Migrate platform-dependent mock hugepage selftests to live >> drm/i915: Use correct huge page manager for MTL >> >> drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 105 ++++++++++++++++++------ >> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 +- >> 2 files changed, 82 insertions(+), 26 deletions(-) >> --- >> base-commit: 4d0066a1c0763d50b6fb017e27d12b081ce21b57 >> change-id: 20230425-hugepage-migrate-1869aaf31a6d >> >> Best regards, >> -- >> Andrzej Hajda > > Just reviewed the changes proper. It's been a while, so I don't remember everything > about the prior version, but I think I recognized what was changed: > > - I wasn't aware a 21 bit alignment was required for 2M page sizes. I'm glad you caught that. > - The extra debugging/error information will be helpful in the case of a failure. > - Grabbing the per-context VM instead of the ppgtt vm sounds good to me. > > Everything here looks amenable. > Acked-by: Jonathan Cavitt > Though, given I'm also one of the signed-off-bys, I don't know if me acking it is exactly above-board. > -Jonathan Cavitt Thanks for looking at it. CI spotted another issue: 2M pages are preferred over old-64K, if former are available. Fixed version sent. Regarding tags, I've kept your authorship, s-o-b, and added my Co-developed, if it is OK to you I will keep it this way. If you prefer otherwise let me know. Regards Andrzej >