From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8329C81208 for ; Tue, 23 Jan 2024 17:56:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706032569; cv=none; b=eNWQmCV6kKhdL20MZKgYXpRNcZqx73paTdjOCRMfFhtL82RbWBWX9+J/fSYcxHQhKH5k+NpdkGuxwJdgamWQGve3nwqu2qd4qor24cRyOWKK2nJSgKDY6KmuH1yotjM36nw+2xTqj9N87cI61C1glsqfZrbYjHiJnr5EpaxNFQE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706032569; c=relaxed/simple; bh=Kr7w+SGEwqQihNACAI+flJSJVscpWWcaaMGKuGdc9I4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X7HOASi/dW6M/wTzpoJHLkyytxRyiUZklcvGxezSgCajtKLfbqUQo5lMbr1ViT9qlu07BgTS8snTzUB1v4sNklES4LrE5LaIzkN0OOJI3H5bUvNgqaVumpvUXZmTKFORL+gyDJRzGfyoMG+Vu7h1hMsQqmXlWWLbaE9sTQk1378= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dHYPbyaz; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dHYPbyaz" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2cdeb954640so53022031fa.3 for ; Tue, 23 Jan 2024 09:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706032565; x=1706637365; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WsZ4KlUHiglOsCzCfXatA2rETh1XN4ZPTM126THuUHg=; b=dHYPbyaziPPSWKqT5rWuOtoNXKtw3ZOQj1AVUwhhT9ddAk2OMQq/JQUZMOhpcWKCJW 9vD3cHW8opbTSRbAhxJi2rS5ErzLPab2/JS4pBtxZ7IoaGkFlpRYNEQ0dTU+810V3TlA eEfBVJz+2R7kd1b3CtYize6ct9ZhryKlf8JCrar9bBw9N/iJ3ZNQOX8YaJTjdUBnbiMD L5zkIjX4HAG40A5TdZlFsNyO1iVpH/dk8foT02RiU4ZuSJvdhh4XpOMR04eMt8b9TGnK 5eXnAvmGAbRVRVV1Et1Eg9V7UvSuxx3+9Xr1y1+VTPZvUrDcBFO229ENnX7FDA+tKWrQ smyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706032565; x=1706637365; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WsZ4KlUHiglOsCzCfXatA2rETh1XN4ZPTM126THuUHg=; b=n78y5FEHy3vf2m+0s9z3xX3nRuxcyrJcv5yR8y/wBzjtYqnhiq4aB5Knc2+MZACutB 3916Ez5pXyut5yRzvRuEHDFKajAeYk3JngT91kCrma/8/lmx9QR98Co/x07gDCKgisYa VVMlIvxVVCMEMumbyH6zPaR4qAJYKhpzJBjqSi9rXDsIdVAS7dTEz5Bv0MX0WRSInpk3 Gj5fjVWwgNXAfI6DyuyU79CiJKwL7fwVa+INuwdVGKj59qEiyvUX6EkM+mVJyg8xAyhe 0zDvlqmtJmGlocLSZ7JYlaGJBDeMkSTn1vQ8LYOmDKZh/fsoRupWYQsMRYdaQodEvzCc om0w== X-Gm-Message-State: AOJu0Yw0Z3io5qtWiTIx9pWbMtX998q0dIqkIkPEa9/4+8GmZHnfmhHM 36CukByZJQcysO7Uro/c7nwJOFs3s/F268mWEmchOX5r+PIlwZQ70OvuJdXsDWs= X-Google-Smtp-Source: AGHT+IFmCLYzgjjZPiLgBJlOLM29I1/FO8zGdLnpI82VdMTXlCFvm48M4Uuf3x4GeJBr2Vn8ojX7mg== X-Received: by 2002:a05:6512:33c3:b0:50e:9a0d:d402 with SMTP id d3-20020a05651233c300b0050e9a0dd402mr3678975lfg.105.1706032565599; Tue, 23 Jan 2024 09:56:05 -0800 (PST) Received: from [172.30.205.123] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id o9-20020a056512050900b0050ef7f44884sm2335262lfb.199.2024.01.23.09.56.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jan 2024 09:56:05 -0800 (PST) Message-ID: Date: Tue, 23 Jan 2024 18:56:03 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 10/10] clk: qcom: Add camcc clock driver for x1e80100 Content-Language: en-US To: Abel Vesa Cc: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Neil Armstrong , Vladimir Zapolskiy , Dmitry Baryshkov , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Rajendra Nayak References: <20231214-x1e80100-clock-controllers-v2-0-2b0739bebd27@linaro.org> <20231214-x1e80100-clock-controllers-v2-10-2b0739bebd27@linaro.org> <624956b6-d7ea-43da-bb8d-32d9166a0272@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/23/24 12:49, Abel Vesa wrote: > On 23-12-16 14:39:48, Konrad Dybcio wrote: >> On 14.12.2023 17:49, Abel Vesa wrote: >>> From: Rajendra Nayak >>> >>> Add the camcc clock driver for x1e80100 >>> >>> Signed-off-by: Rajendra Nayak >>> Signed-off-by: Abel Vesa >>> --- >> [...] >> >>> +enum { >>> + DT_BI_TCXO, >>> + DT_BI_TCXO_AO, >>> + DT_SLEEP_CLK, >>> +}; >>> + >>> +enum { >>> + P_BI_TCXO, >> Please don't overload this define with DT_BI_TCXO_AO, add a new one >> for the active-only clock. Please also do this in other drivers in >> this series. > > Nope, that needs to stay if we want to align the dt bindings between > SM8550, SM8650 and this. At least for dispcc. But I would like to have > the same dt schema for the rest of the clock controller drivers between > platforms that share basically the same ip block. No, you're confusing the dt ordering enum (the first one) with the parent list enum (the one below that I'm commenting on). Konrad