From: Jens Axboe <axboe@kernel.dk>
To: Andrew Morton <akpm@linux-foundation.org>, linux@treblig.org
Cc: andriy.shevchenko@linux.intel.com, viro@zeniv.linux.org.uk,
corbet@lwn.net, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] relay: Remove unused relay_late_setup_files
Date: Wed, 23 Apr 2025 14:12:10 -0600 [thread overview]
Message-ID: <f57ec419-08ef-4a87-b4ac-fc60c5fd2d3d@kernel.dk> (raw)
In-Reply-To: <20250420140758.601ae8abaa03aacb33ce7084@linux-foundation.org>
On 4/20/25 3:07 PM, Andrew Morton wrote:
> On Sat, 19 Apr 2025 00:49:32 +0100 linux@treblig.org wrote:
>
>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>>
>> The last use of relay_late_setup_files() was removed in 2018
>> by commit 2b47733045aa ("drm/i915/guc: Merge log relay file and channel
>> creation")
>>
>> Remove it and the helper it used.
>>
>> relay_late_setup_files() was used for eventually registering
>> 'buffer only' channels. With it gone, delete the docs that
>> explain how to do that. Which suggests it should be possible
>> to lose the 'has_base_filename' flags.
>>
>> (Are there any other uses??)
>>
>
> For some reason get_maintainer points at Al and Andy for relay.c but my
> mental rolodex thinks "Axboe".
Heh, probably because I did dabble in it 20 YEARS AGO as we used it for
the original blktrace! I'm not saying we're both old, but...
> Jens, does this look OK?
Looks fine to me.
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
next prev parent reply other threads:[~2025-04-23 20:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 23:49 linux
2025-04-20 21:07 ` Andrew Morton
2025-04-23 20:12 ` Jens Axboe [this message]
2025-05-12 1:12 Jason Xing
2025-05-12 1:30 ` Dr. David Alan Gilbert
2025-05-12 2:22 ` Jason Xing
2025-05-12 11:50 ` Dr. David Alan Gilbert
2025-05-12 12:04 ` Jason Xing
2025-05-12 6:14 ` Andy Shevchenko
2025-05-12 6:17 ` Andy Shevchenko
2025-05-12 6:55 ` Jason Xing
2025-05-12 7:25 ` Andy Shevchenko
2025-05-12 6:53 ` Jason Xing
2025-05-12 7:21 ` Andy Shevchenko
2025-05-12 7:34 ` Jason Xing
2025-05-12 13:27 ` Jens Axboe
2025-05-12 14:55 ` Christoph Hellwig
2025-05-13 0:49 ` Jason Xing
2025-05-13 1:49 ` Jens Axboe
2025-05-13 2:17 ` Jason Xing
2025-05-13 13:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f57ec419-08ef-4a87-b4ac-fc60c5fd2d3d@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®