mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gergo Koteles <soyer@irl.hu>
To: "Ike Panhc" <ike.pan@canonical.com>,
	"Gašper Nemgar" <gasper.nemgar@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH] Fixed ideapad-laptop driver to support Yoga 9 2 in 1 14imh9 unknown keys
Date: Fri, 14 Mar 2025 12:52:39 +0100	[thread overview]
Message-ID: <f581c3d25a270801de35b7d0380cbd13c4c4a131.camel@irl.hu> (raw)
In-Reply-To: <4f1d9817-60b1-433d-b7a8-f37057e0980a@canonical.com>

Hi Gašper,

On 3/13/25 23:17, Gašper Nemgar wrote:
>  	/* Specific to some newer models */
>  	{ KE_KEY,	0x3e | IDEAPAD_WMI_KEY, { KEY_MICMUTE } },
>  	{ KE_KEY,	0x3f | IDEAPAD_WMI_KEY, { KEY_RFKILL } },
> +	/*Star- (User Asignable Key)*/

Asignable -> Assignable?
Could you please add a space before/after the body of the comment?

> +	{ KE_KEY,	0x44 | IDEAPAD_WMI_KEY, { KEY_PROG1 } },

Other Ideapads map this star key to KEY_FAVORITES, for consistency I
think it would be better if this one mapped there too.

Thanks,
Gergo



  reply	other threads:[~2025-03-14 11:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13 15:17 Gašper Nemgar
2025-03-14  4:38 ` Ike Panhc
2025-03-14 11:52   ` Gergo Koteles [this message]
2025-03-14 12:28     ` Gašper Nemgar
2025-03-14 14:02       ` Gergo Koteles
2025-03-14  9:34 ` Hans de Goede
     [not found]   ` <CAKi4K-hFHy4_F+fQghFNNR8cnkojPcE0uXQWsf5+5dbqjXGs0g@mail.gmail.com>
2025-03-16  8:41     ` Hans de Goede
2025-03-17 14:08       ` Peter F. Patel-Schneider
2025-03-17 15:20         ` Gašper Nemgar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f581c3d25a270801de35b7d0380cbd13c4c4a131.camel@irl.hu \
    --to=soyer@irl.hu \
    --cc=gasper.nemgar@gmail.com \
    --cc=ike.pan@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®