mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Daniel Kestrel <kestrelseventyfour@gmail.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: remoteproc: Add AVM WASP
Date: Fri, 4 Mar 2022 14:36:39 +0100	[thread overview]
Message-ID: <f58869e3-8b5c-ed4b-c11c-27a8e465c3a2@canonical.com> (raw)
In-Reply-To: <20220227115832.13490-3-kestrelseventyfour@gmail.com>

On 27/02/2022 12:58, Daniel Kestrel wrote:
> AVM Fritzbox router boards may contain an additional ATH79
> based SoC that has the wifi cards connected.
> This patch adds bindings for this remote processor.
> 
> Signed-off-by: Daniel Kestrel <kestrelseventyfour@gmail.com>
> ---
>  .../bindings/remoteproc/avm,wasp-rproc.yaml   | 56 +++++++++++++++++++
>  1 file changed, 56 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/remoteproc/avm,wasp-rproc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/avm,wasp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/avm,wasp-rproc.yaml
> new file mode 100644
> index 000000000000..8b39fafc60aa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/avm,wasp-rproc.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/remoteproc/avm,wasp-rproc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AVM WASP processor controller bindings
> +
> +maintainers:
> +  - Daniel Kestrel <kestrelseventyfour@gmail.com>
> +
> +description: |
> +  This document defines the bindings for the remoteproc component that loads and
> +  boots firmwares on the AVM Wireless Assistent Support Processor (WASP) SoC
> +  that is attached to some AVM Fritzbox devices (3390, 3490, 5490, 5491, 7490).
> +
> +properties:
> +  compatible:
> +    enum:
> +      - avm,fritzbox3390-wasp
> +      - avm,fritzboxx490-wasp

This should be specific compatible instead of wildcard "x490".

> +
> +  avm,wasp-mdio:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: Lantiq GSWIP switch mdio.
> +
> +  avm,wasp-port:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: Network port, where the WASP SoC is connected to.
> +
> +  avm,reset-gpios:
> +    description: Reset gpio of the WASP SoC.

maxItems

> +
> +  avm,startup-gpios:
> +    description: Startup gpio of the WASP SoC.

maxItems

> +
> +required:
> +  - compatible
> +  - avm,wasp-mdio
> +  - avm,wasp-port
> +  - avm,reset-gpios
> +  - avm,startup-gpios
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    remoteproc {
> +        compatible = "avm,fritzboxx490-wasp";
> +        avm,wasp-mdio = <&gswip_mdio>;
> +        avm,wasp-port = <&port5>;
> +        avm,reset-gpios = <&gpio 34 GPIO_ACTIVE_HIGH>;
> +        avm,startup-gpios = <&gpio 5 GPIO_ACTIVE_HIGH>;
> +    };


Best regards,
Krzysztof

  reply	other threads:[~2022-03-04 13:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-27 11:58 [PATCH v2 0/3] Add support for WASP SoC on AVM router boards Daniel Kestrel
2022-02-27 11:58 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add AVM Daniel Kestrel
2022-02-27 11:58 ` [PATCH v2 2/3] dt-bindings: remoteproc: Add AVM WASP Daniel Kestrel
2022-03-04 13:36   ` Krzysztof Kozlowski [this message]
2022-02-27 11:58 ` [PATCH v2 3/3] remoteproc: Add AVM WASP driver Daniel Kestrel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f58869e3-8b5c-ed4b-c11c-27a8e465c3a2@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kestrelseventyfour@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®